Collect all event creation logic in one place called EventCreateService
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
This commit is contained in:
parent
cce80d04fe
commit
d89130b097
|
@ -0,0 +1,56 @@
|
|||
# EventCreateService class
|
||||
#
|
||||
# Used for creating events feed on dashboard after certain user action
|
||||
#
|
||||
# Ex.
|
||||
# EventCreateService.new.new_issue(issue, current_user)
|
||||
#
|
||||
class EventCreateService
|
||||
def open_issue(issue, current_user)
|
||||
create_event(issue, current_user, Event::CREATED)
|
||||
end
|
||||
|
||||
def close_issue(issue, current_user)
|
||||
create_event(issue, current_user, Event::CLOSED)
|
||||
end
|
||||
|
||||
def reopen_issue(issue, current_user)
|
||||
create_event(issue, current_user, Event::REOPENED)
|
||||
end
|
||||
|
||||
def open_mr(merge_request, current_user)
|
||||
create_event(merge_request, current_user, Event::CREATED)
|
||||
end
|
||||
|
||||
def close_mr(merge_request, current_user)
|
||||
create_event(merge_request, current_user, Event::CLOSED)
|
||||
end
|
||||
|
||||
def reopen_mr(merge_request, current_user)
|
||||
create_event(merge_request, current_user, Event::REOPENED)
|
||||
end
|
||||
|
||||
def merge_mr(merge_request, current_user)
|
||||
create_event(merge_request, current_user, Event::MERGED)
|
||||
end
|
||||
|
||||
def open_milestone(milestone, current_user)
|
||||
create_event(milestone, current_user, Event::CREATED)
|
||||
end
|
||||
|
||||
def close_milestone(milestone, current_user)
|
||||
create_event(milestone, current_user, Event::CLOSED)
|
||||
end
|
||||
|
||||
private
|
||||
|
||||
def create_event(record, current_user, status)
|
||||
Event.create(
|
||||
project: record.project,
|
||||
target_id: record.id,
|
||||
target_type: record.class.name,
|
||||
action: status,
|
||||
author_id: current_user.id
|
||||
)
|
||||
end
|
||||
end
|
|
@ -0,0 +1,103 @@
|
|||
require 'spec_helper'
|
||||
|
||||
describe EventCreateService do
|
||||
let(:service) { EventCreateService.new }
|
||||
|
||||
describe 'Issues' do
|
||||
describe :open_issue do
|
||||
let(:issue) { create(:issue) }
|
||||
|
||||
it { service.open_issue(issue, issue.author).should be_true }
|
||||
|
||||
it "should create new event" do
|
||||
expect { service.open_issue(issue, issue.author) }.to change { Event.count }
|
||||
end
|
||||
end
|
||||
|
||||
describe :close_issue do
|
||||
let(:issue) { create(:issue) }
|
||||
|
||||
it { service.close_issue(issue, issue.author).should be_true }
|
||||
|
||||
it "should create new event" do
|
||||
expect { service.close_issue(issue, issue.author) }.to change { Event.count }
|
||||
end
|
||||
end
|
||||
|
||||
describe :reopen_issue do
|
||||
let(:issue) { create(:issue) }
|
||||
|
||||
it { service.reopen_issue(issue, issue.author).should be_true }
|
||||
|
||||
it "should create new event" do
|
||||
expect { service.reopen_issue(issue, issue.author) }.to change { Event.count }
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
describe 'Merge Requests' do
|
||||
describe :open_mr do
|
||||
let(:merge_request) { create(:merge_request) }
|
||||
|
||||
it { service.open_mr(merge_request, merge_request.author).should be_true }
|
||||
|
||||
it "should create new event" do
|
||||
expect { service.open_mr(merge_request, merge_request.author) }.to change { Event.count }
|
||||
end
|
||||
end
|
||||
|
||||
describe :close_mr do
|
||||
let(:merge_request) { create(:merge_request) }
|
||||
|
||||
it { service.close_mr(merge_request, merge_request.author).should be_true }
|
||||
|
||||
it "should create new event" do
|
||||
expect { service.close_mr(merge_request, merge_request.author) }.to change { Event.count }
|
||||
end
|
||||
end
|
||||
|
||||
describe :merge_mr do
|
||||
let(:merge_request) { create(:merge_request) }
|
||||
|
||||
it { service.merge_mr(merge_request, merge_request.author).should be_true }
|
||||
|
||||
it "should create new event" do
|
||||
expect { service.merge_mr(merge_request, merge_request.author) }.to change { Event.count }
|
||||
end
|
||||
end
|
||||
|
||||
describe :reopen_mr do
|
||||
let(:merge_request) { create(:merge_request) }
|
||||
|
||||
it { service.reopen_mr(merge_request, merge_request.author).should be_true }
|
||||
|
||||
it "should create new event" do
|
||||
expect { service.reopen_mr(merge_request, merge_request.author) }.to change { Event.count }
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
describe 'Milestone' do
|
||||
let(:user) { create :user }
|
||||
|
||||
describe :open_milestone do
|
||||
let(:milestone) { create(:milestone) }
|
||||
|
||||
it { service.open_milestone(milestone, user).should be_true }
|
||||
|
||||
it "should create new event" do
|
||||
expect { service.open_milestone(milestone, user) }.to change { Event.count }
|
||||
end
|
||||
end
|
||||
|
||||
describe :close_mr do
|
||||
let(:milestone) { create(:milestone) }
|
||||
|
||||
it { service.close_milestone(milestone, user).should be_true }
|
||||
|
||||
it "should create new event" do
|
||||
expect { service.close_milestone(milestone, user) }.to change { Event.count }
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
Loading…
Reference in New Issue