From d8a24003cbd66dc80393dae46299c5734d50b5e0 Mon Sep 17 00:00:00 2001 From: Pierre de La Morinerie Date: Tue, 18 Feb 2014 10:34:57 +0100 Subject: [PATCH] Don't write the project namespace in email subjects For instance, the email "Subject" field changes from: Mattt / Ground Control | Saving issue doesn't work sometimes (#1234) to: Ground Control | Saving issue doesn't work sometimes (#1234) Rationale: * Most people are receiving email notifications about a single fork: the project activity, issues and merge requests are happening either in a root repository or in a fork, but less often in several forks. * It removes noise from the email subject. The namespace of the project can still be read in the email body. * For Entreprise users that have a single namespace "MyEntreprise", having this repeated in every email subject is very noisy. --- app/mailers/notify.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/mailers/notify.rb b/app/mailers/notify.rb index 666cef4d3cb..3a4c9cf73b9 100644 --- a/app/mailers/notify.rb +++ b/app/mailers/notify.rb @@ -56,7 +56,7 @@ class Notify < ActionMailer::Base # => "Lorem ipsum | Dolor sit amet" def subject(*extra) subject = "" - subject << "#{@project.name_with_namespace} | " if @project + subject << "#{@project.name} | " if @project subject << extra.join(' | ') if extra.present? subject end