kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Remove useless increment when creating a new board list

Browse source
This commit is contained in:
Douglas Barbosa Alexandre 2016-08-15 23:20:16 -03:00
parent 847ebce90a
commit d8fc783bb9
1 changed files with 2 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
app/services/boards/lists/create_service.rb
View file

@ -3,15 +3,13 @@ module Boards
class CreateService < Boards::BaseService
def execute
List.transaction do
position = find_next_position
increment_higher_lists(position)
create_list_at(position)
create_list_at(next_position)
end
end
private
def find_next_position
def next_position
max_position = board.lists.label.maximum(:position)
max_position.nil? ? 0 : max_position.succ
end
@ -19,11 +17,6 @@ module Boards
def create_list_at(position)
board.lists.create(params.merge(list_type: :label, position: position))
end
def increment_higher_lists(position)
board.lists.label.where('position >= ?', position)
.update_all('position = position + 1')
end
end
end
end