Move has_trace? to CommitStatus than GenericCommitStatus

Feedback: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7617#note_18762721
2016-11-22 13:36:19 +08:00 · 2016-11-22 13:36:19 +08:00 · da9726170c
parent a2fb636153
commit da9726170c
2 changed files with 8 additions and 8 deletions
--- a/app/models/commit_status.rb
+++ b/app/models/commit_status.rb
@ -135,15 +135,19 @@ class CommitStatus < ActiveRecord::Base
    allow_failure? && (failed? || canceled?)
  end

-  def playable?
-    false
-  end
-
  def duration
    calculate_duration
  end

+  def playable?
+    false
+  end
+
  def stuck?
    false
  end
+
+  def has_trace?
+    false
+  end
 end
--- a/app/models/generic_commit_status.rb
+++ b/app/models/generic_commit_status.rb
@ -12,8 +12,4 @@ class GenericCommitStatus < CommitStatus
  def tags
    [:external]
  end
-
-  def has_trace?
-    false
-  end
 end