Refactor create service spec
before: 1 minute 11.81 seconds after: 52.47 seconds
This commit is contained in:
parent
7902395f1f
commit
daf26fa0db
|
@ -0,0 +1,4 @@
|
|||
---
|
||||
title: Refactor create service spec
|
||||
merge_request: 7609
|
||||
author: Semyon Pupkov
|
|
@ -1,150 +1,150 @@
|
|||
require 'spec_helper'
|
||||
|
||||
describe Projects::CreateService, services: true do
|
||||
describe :create_by_user do
|
||||
describe Projects::CreateService, '#execute', services: true do
|
||||
let(:user) { create :user }
|
||||
let(:opts) do
|
||||
{
|
||||
name: "GitLab",
|
||||
namespace: user.namespace
|
||||
}
|
||||
end
|
||||
|
||||
it 'creates labels on Project creation if there are templates' do
|
||||
Label.create(title: "bug", template: true)
|
||||
project = create_project(user, opts)
|
||||
|
||||
expect(project.labels).not_to be_empty
|
||||
end
|
||||
|
||||
context 'user namespace' do
|
||||
it do
|
||||
project = create_project(user, opts)
|
||||
|
||||
expect(project).to be_valid
|
||||
expect(project.owner).to eq(user)
|
||||
expect(project.team.masters).to include(user)
|
||||
expect(project.namespace).to eq(user.namespace)
|
||||
end
|
||||
end
|
||||
|
||||
context 'group namespace' do
|
||||
let(:group) do
|
||||
create(:group).tap do |group|
|
||||
group.add_owner(user)
|
||||
end
|
||||
end
|
||||
|
||||
before do
|
||||
@user = create :user
|
||||
@opts = {
|
||||
name: "GitLab",
|
||||
namespace: @user.namespace
|
||||
}
|
||||
user.refresh_authorized_projects # Ensure cache is warm
|
||||
end
|
||||
|
||||
it 'creates labels on Project creation if there are templates' do
|
||||
Label.create(title: "bug", template: true)
|
||||
project = create_project(@user, @opts)
|
||||
project.reload
|
||||
it do
|
||||
project = create_project(user, opts.merge!(namespace_id: group.id))
|
||||
|
||||
expect(project.labels).not_to be_empty
|
||||
expect(project).to be_valid
|
||||
expect(project.owner).to eq(group)
|
||||
expect(project.namespace).to eq(group)
|
||||
expect(user.authorized_projects).to include(project)
|
||||
end
|
||||
end
|
||||
|
||||
context 'error handling' do
|
||||
it 'handles invalid options' do
|
||||
opts.merge!({ default_branch: 'master' } )
|
||||
expect(create_project(user, opts)).to eq(nil)
|
||||
end
|
||||
end
|
||||
|
||||
context 'wiki_enabled creates repository directory' do
|
||||
context 'wiki_enabled true creates wiki repository directory' do
|
||||
it do
|
||||
project = create_project(user, opts)
|
||||
path = ProjectWiki.new(project, user).send(:path_to_repo)
|
||||
|
||||
expect(File.exist?(path)).to be_truthy
|
||||
end
|
||||
end
|
||||
|
||||
context 'user namespace' do
|
||||
context 'wiki_enabled false does not create wiki repository directory' do
|
||||
it do
|
||||
opts.merge!(wiki_enabled: false)
|
||||
project = create_project(user, opts)
|
||||
path = ProjectWiki.new(project, user).send(:path_to_repo)
|
||||
|
||||
expect(File.exist?(path)).to be_falsey
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
context 'builds_enabled global setting' do
|
||||
let(:project) { create_project(user, opts) }
|
||||
|
||||
subject { project.builds_enabled? }
|
||||
|
||||
context 'global builds_enabled false does not enable CI by default' do
|
||||
before do
|
||||
@project = create_project(@user, @opts)
|
||||
project.project_feature.update_attribute(:builds_access_level, ProjectFeature::DISABLED)
|
||||
end
|
||||
|
||||
it { expect(@project).to be_valid }
|
||||
it { expect(@project.owner).to eq(@user) }
|
||||
it { expect(@project.team.masters).to include(@user) }
|
||||
it { expect(@project.namespace).to eq(@user.namespace) }
|
||||
it { is_expected.to be_falsey }
|
||||
end
|
||||
|
||||
context 'group namespace' do
|
||||
context 'global builds_enabled true does enable CI by default' do
|
||||
before do
|
||||
@group = create :group
|
||||
@group.add_owner(@user)
|
||||
|
||||
@user.refresh_authorized_projects # Ensure cache is warm
|
||||
|
||||
@opts.merge!(namespace_id: @group.id)
|
||||
@project = create_project(@user, @opts)
|
||||
project.project_feature.update_attribute(:builds_access_level, ProjectFeature::ENABLED)
|
||||
end
|
||||
|
||||
it { expect(@project).to be_valid }
|
||||
it { expect(@project.owner).to eq(@group) }
|
||||
it { expect(@project.namespace).to eq(@group) }
|
||||
it { expect(@user.authorized_projects).to include(@project) }
|
||||
it { is_expected.to be_truthy }
|
||||
end
|
||||
end
|
||||
|
||||
context 'restricted visibility level' do
|
||||
before do
|
||||
stub_application_setting(restricted_visibility_levels: [Gitlab::VisibilityLevel::PUBLIC])
|
||||
|
||||
opts.merge!(
|
||||
visibility_level: Gitlab::VisibilityLevel.options['Public']
|
||||
)
|
||||
end
|
||||
|
||||
context 'error handling' do
|
||||
it 'handles invalid options' do
|
||||
@opts.merge!({ default_branch: 'master' } )
|
||||
expect(create_project(@user, @opts)).to eq(nil)
|
||||
end
|
||||
it 'does not allow a restricted visibility level for non-admins' do
|
||||
project = create_project(user, opts)
|
||||
expect(project).to respond_to(:errors)
|
||||
expect(project.errors.messages).to have_key(:visibility_level)
|
||||
expect(project.errors.messages[:visibility_level].first).to(
|
||||
match('restricted by your GitLab administrator')
|
||||
)
|
||||
end
|
||||
|
||||
context 'wiki_enabled creates repository directory' do
|
||||
context 'wiki_enabled true creates wiki repository directory' do
|
||||
before do
|
||||
@project = create_project(@user, @opts)
|
||||
@path = ProjectWiki.new(@project, @user).send(:path_to_repo)
|
||||
end
|
||||
it 'allows a restricted visibility level for admins' do
|
||||
admin = create(:admin)
|
||||
project = create_project(admin, opts)
|
||||
|
||||
it { expect(File.exist?(@path)).to be_truthy }
|
||||
end
|
||||
expect(project.errors.any?).to be(false)
|
||||
expect(project.saved?).to be(true)
|
||||
end
|
||||
end
|
||||
|
||||
context 'wiki_enabled false does not create wiki repository directory' do
|
||||
before do
|
||||
@opts.merge!(wiki_enabled: false)
|
||||
@project = create_project(@user, @opts)
|
||||
@path = ProjectWiki.new(@project, @user).send(:path_to_repo)
|
||||
end
|
||||
context 'repository creation' do
|
||||
it 'synchronously creates the repository' do
|
||||
expect_any_instance_of(Project).to receive(:create_repository)
|
||||
|
||||
it { expect(File.exist?(@path)).to be_falsey }
|
||||
end
|
||||
project = create_project(user, opts)
|
||||
expect(project).to be_valid
|
||||
expect(project.owner).to eq(user)
|
||||
expect(project.namespace).to eq(user.namespace)
|
||||
end
|
||||
end
|
||||
|
||||
context 'when there is an active service template' do
|
||||
before do
|
||||
create(:service, project: nil, template: true, active: true)
|
||||
end
|
||||
|
||||
context 'builds_enabled global setting' do
|
||||
let(:project) { create_project(@user, @opts) }
|
||||
it 'creates a service from this template' do
|
||||
project = create_project(user, opts)
|
||||
|
||||
subject { project.builds_enabled? }
|
||||
|
||||
context 'global builds_enabled false does not enable CI by default' do
|
||||
before do
|
||||
project.project_feature.update_attribute(:builds_access_level, ProjectFeature::DISABLED)
|
||||
end
|
||||
|
||||
it { is_expected.to be_falsey }
|
||||
end
|
||||
|
||||
context 'global builds_enabled true does enable CI by default' do
|
||||
before do
|
||||
project.project_feature.update_attribute(:builds_access_level, ProjectFeature::ENABLED)
|
||||
end
|
||||
|
||||
it { is_expected.to be_truthy }
|
||||
end
|
||||
end
|
||||
|
||||
context 'restricted visibility level' do
|
||||
before do
|
||||
stub_application_setting(restricted_visibility_levels: [Gitlab::VisibilityLevel::PUBLIC])
|
||||
|
||||
@opts.merge!(
|
||||
visibility_level: Gitlab::VisibilityLevel.options['Public']
|
||||
)
|
||||
end
|
||||
|
||||
it 'does not allow a restricted visibility level for non-admins' do
|
||||
project = create_project(@user, @opts)
|
||||
expect(project).to respond_to(:errors)
|
||||
expect(project.errors.messages).to have_key(:visibility_level)
|
||||
expect(project.errors.messages[:visibility_level].first).to(
|
||||
match('restricted by your GitLab administrator')
|
||||
)
|
||||
end
|
||||
|
||||
it 'allows a restricted visibility level for admins' do
|
||||
admin = create(:admin)
|
||||
project = create_project(admin, @opts)
|
||||
|
||||
expect(project.errors.any?).to be(false)
|
||||
expect(project.saved?).to be(true)
|
||||
end
|
||||
end
|
||||
|
||||
context 'repository creation' do
|
||||
it 'synchronously creates the repository' do
|
||||
expect_any_instance_of(Project).to receive(:create_repository)
|
||||
|
||||
project = create_project(@user, @opts)
|
||||
expect(project).to be_valid
|
||||
expect(project.owner).to eq(@user)
|
||||
expect(project.namespace).to eq(@user.namespace)
|
||||
end
|
||||
end
|
||||
|
||||
context 'when there is an active service template' do
|
||||
before do
|
||||
create(:service, project: nil, template: true, active: true)
|
||||
end
|
||||
|
||||
it 'creates a service from this template' do
|
||||
project = create_project(@user, @opts)
|
||||
project.reload
|
||||
|
||||
expect(project.services.count).to eq 1
|
||||
end
|
||||
expect(project.services.count).to eq 1
|
||||
end
|
||||
end
|
||||
|
||||
|
|
Loading…
Reference in New Issue