More descriptive comments, feedback:

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5620#note_13539571
This commit is contained in:
Lin Jen-Shin 2016-08-03 17:33:34 +08:00
parent 853b0dffe7
commit db123d29e7
1 changed files with 6 additions and 2 deletions

View File

@ -7,8 +7,12 @@ module ServiceParams
:build_key, :server, :teamcity_url, :drone_url, :build_type,
:description, :issues_url, :new_issue_url, :restrict_to_branch, :channel,
:colorize_messages, :channels,
# See app/helpers/services_helper.rb
# for why we need issues_events and merge_requests_events.
# We're using `issues_events` and `merge_requests_events`
# in the view so we still need to explicitly state them
# here. `Service#event_names` would only give
# `issue_events` and `merge_request_events` (singular!)
# See app/helpers/services_helper.rb for how we
# make those event names plural as special case.
:issues_events, :merge_requests_events,
:notify_only_broken_builds, :notify_only_broken_pipelines,
:add_pusher, :send_from_committer_email, :disable_diffs,