Refactor Clusters::CreateService spec
This commit is contained in:
parent
0ac2d8ab13
commit
dbb8644c24
|
@ -4,11 +4,11 @@ describe Clusters::CreateService do
|
|||
let(:access_token) { 'xxx' }
|
||||
let(:project) { create(:project) }
|
||||
let(:user) { create(:user) }
|
||||
let(:result) { described_class.new(project, user, params).execute(access_token) }
|
||||
|
||||
subject { described_class.new(project, user, params).execute(access_token) }
|
||||
|
||||
context 'when provider is gcp' do
|
||||
context 'when project has no clusters' do
|
||||
context 'when correct params' do
|
||||
shared_context 'valid params' do
|
||||
let(:params) do
|
||||
{
|
||||
name: 'test-cluster',
|
||||
|
@ -21,27 +21,9 @@ describe Clusters::CreateService do
|
|||
}
|
||||
}
|
||||
end
|
||||
|
||||
it 'creates a cluster object and performs a worker' do
|
||||
expect(ClusterProvisionWorker).to receive(:perform_async)
|
||||
|
||||
expect { result }
|
||||
.to change { Clusters::Cluster.count }.by(1)
|
||||
.and change { Clusters::Providers::Gcp.count }.by(1)
|
||||
|
||||
expect(result.name).to eq('test-cluster')
|
||||
expect(result.user).to eq(user)
|
||||
expect(result.project).to eq(project)
|
||||
expect(result.provider.gcp_project_id).to eq('gcp-project')
|
||||
expect(result.provider.zone).to eq('us-central1-a')
|
||||
expect(result.provider.num_nodes).to eq(1)
|
||||
expect(result.provider.machine_type).to eq('machine_type-a')
|
||||
expect(result.provider.access_token).to eq(access_token)
|
||||
expect(result.platform).to be_nil
|
||||
end
|
||||
end
|
||||
|
||||
context 'when invalid params' do
|
||||
shared_context 'invalid params' do
|
||||
let(:params) do
|
||||
{
|
||||
name: 'test-cluster',
|
||||
|
@ -54,36 +36,58 @@ describe Clusters::CreateService do
|
|||
}
|
||||
}
|
||||
end
|
||||
end
|
||||
|
||||
shared_examples 'create cluster' do
|
||||
it 'creates a cluster object and performs a worker' do
|
||||
expect(ClusterProvisionWorker).to receive(:perform_async)
|
||||
|
||||
expect { subject }
|
||||
.to change { Clusters::Cluster.count }.by(1)
|
||||
.and change { Clusters::Providers::Gcp.count }.by(1)
|
||||
|
||||
expect(subject.name).to eq('test-cluster')
|
||||
expect(subject.user).to eq(user)
|
||||
expect(subject.project).to eq(project)
|
||||
expect(subject.provider.gcp_project_id).to eq('gcp-project')
|
||||
expect(subject.provider.zone).to eq('us-central1-a')
|
||||
expect(subject.provider.num_nodes).to eq(1)
|
||||
expect(subject.provider.machine_type).to eq('machine_type-a')
|
||||
expect(subject.provider.access_token).to eq(access_token)
|
||||
expect(subject.platform).to be_nil
|
||||
end
|
||||
end
|
||||
|
||||
shared_examples 'error' do
|
||||
it 'returns an error' do
|
||||
expect(ClusterProvisionWorker).not_to receive(:perform_async)
|
||||
expect { result }.to change { Clusters::Cluster.count }.by(0)
|
||||
expect(result.errors[:"provider_gcp.gcp_project_id"]).to be_present
|
||||
expect { subject }.to change { Clusters::Cluster.count }.by(0)
|
||||
expect(subject.errors[:"provider_gcp.gcp_project_id"]).to be_present
|
||||
end
|
||||
end
|
||||
|
||||
|
||||
context 'when project has no clusters' do
|
||||
context 'when correct params' do
|
||||
include_context 'valid params'
|
||||
|
||||
include_examples 'create cluster'
|
||||
end
|
||||
|
||||
context 'when invalid params' do
|
||||
include_context 'invalid params'
|
||||
|
||||
include_examples 'error'
|
||||
end
|
||||
end
|
||||
|
||||
context 'when project has a cluster' do
|
||||
let(:params) do
|
||||
{
|
||||
name: 'test-cluster',
|
||||
provider_type: :gcp,
|
||||
provider_gcp_attributes: {
|
||||
gcp_project_id: 'gcp-project',
|
||||
zone: 'us-central1-a',
|
||||
num_nodes: 1,
|
||||
machine_type: 'machine_type-a'
|
||||
}
|
||||
}
|
||||
end
|
||||
|
||||
before do
|
||||
Clusters::Cluster.create(params.merge(user: user, projects: [project]))
|
||||
end
|
||||
include_context 'valid params'
|
||||
let!(:cluster) { create(:cluster, :provided_by_gcp, projects: [project]) }
|
||||
|
||||
it 'does not create a cluster' do
|
||||
expect(ClusterProvisionWorker).not_to receive(:perform_async)
|
||||
expect { result }.to raise_error(Exception).and change { Clusters::Cluster.count }.by(0)
|
||||
expect { subject }.to raise_error(ArgumentError).and change { Clusters::Cluster.count }.by(0)
|
||||
end
|
||||
end
|
||||
end
|
||||
|
|
Loading…
Reference in New Issue