From dbd581112dacade61c5863d33533f93ac06de206 Mon Sep 17 00:00:00 2001 From: Annabel Dunstone Date: Wed, 13 Jul 2016 13:37:16 -0500 Subject: [PATCH] Fix icon alignment; reduce side padding on table cells; add tag and fork icon for pipeline ref --- app/assets/stylesheets/pages/pipelines.scss | 37 ++++++++++++------- .../projects/ci/pipelines/_pipeline.html.haml | 5 ++- 2 files changed, 27 insertions(+), 15 deletions(-) diff --git a/app/assets/stylesheets/pages/pipelines.scss b/app/assets/stylesheets/pages/pipelines.scss index cbf8297f387..bbb67d46025 100644 --- a/app/assets/stylesheets/pages/pipelines.scss +++ b/app/assets/stylesheets/pages/pipelines.scss @@ -1,7 +1,7 @@ .pipelines { .stage { - max-width: 80px; - width: 80px; + max-width: 90px; + width: 90px; overflow: hidden; text-overflow: ellipsis; white-space: nowrap; @@ -30,13 +30,17 @@ } .table.builds { - min-width: 1100px; + min-width: 1200px; tr { th { - padding: 16px; + padding: 16px 8px; border: none; } + + td { + padding: 10px 8px; + } } tbody { @@ -46,9 +50,8 @@ .branch-commit { .branch-name { - margin-left: 8px; font-weight: bold; - max-width: 180px; + max-width: 150px; overflow: hidden; display: inline-block; white-space: nowrap; @@ -57,10 +60,15 @@ } svg { - margin: 0 6px; height: 14px; width: auto; vertical-align: middle; + fill: $table-text-gray; + } + + .fa { + font-size: 12px; + color: $table-text-gray; } .commit-id { @@ -88,6 +96,12 @@ } } + .icon-container { + display: inline-block; + text-align: center; + width: 20px; + } + .duration, .finished-at { color: $table-text-gray; @@ -98,15 +112,10 @@ } svg { - height: 12px; - width: auto; + width: 12px; + height: auto; vertical-align: middle; } - - .fa, - svg { - margin-right: 5px; - } } .pipeline-actions { diff --git a/app/views/projects/ci/pipelines/_pipeline.html.haml b/app/views/projects/ci/pipelines/_pipeline.html.haml index 4ef72ff5d2a..70d72f72bca 100644 --- a/app/views/projects/ci/pipelines/_pipeline.html.haml +++ b/app/views/projects/ci/pipelines/_pipeline.html.haml @@ -10,8 +10,11 @@ = link_to namespace_project_pipeline_path(@project.namespace, @project, pipeline.id) do %span ##{pipeline.id} - if pipeline.ref + .icon-container + = pipeline.tag? ? icon('tag') : icon('code-fork') = link_to pipeline.ref, namespace_project_commits_path(@project.namespace, @project, pipeline.ref), class: "monospace branch-name" - = custom_icon("icon_commit") + .icon-container + = custom_icon("icon_commit") = link_to pipeline.short_sha, namespace_project_commit_path(@project.namespace, @project, pipeline.sha), class: "commit-id monospace" - if pipeline.tag? %span.label.label-primary tag