Just use default_branch, feedback:

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13176885
This commit is contained in:
Lin Jen-Shin 2016-07-20 01:29:44 +08:00
parent 091142118e
commit dc6afd575f
2 changed files with 6 additions and 6 deletions

View file

@ -6,7 +6,7 @@ describe Ci::Build, models: true do
let(:pipeline) do
create(:ci_pipeline, project: project,
sha: project.commit.id,
ref: 'fix',
ref: project.default_branch,
status: 'success')
end
@ -680,8 +680,8 @@ describe Ci::Build, models: true do
end
context 'with succeed pipeline' do
it 'returns builds for ref' do
builds = project.latest_successful_builds_for('fix')
it 'returns builds for ref for default_branch' do
builds = project.latest_successful_builds_for
expect(builds).to contain_exactly(build)
end
@ -700,7 +700,7 @@ describe Ci::Build, models: true do
end
it 'returns empty relation' do
builds = project.latest_successful_builds_for('fix')
builds = project.latest_successful_builds_for
expect(builds).to be_kind_of(ActiveRecord::Relation)
expect(builds).to be_empty

View file

@ -192,8 +192,8 @@ describe API::API, api: true do
let(:pipeline) do
create(:ci_pipeline,
project: project,
sha: project.commit('fix').sha,
ref: 'fix')
sha: project.commit.sha,
ref: project.default_branch)
end
let(:build) { create(:ci_build, :success, :artifacts, pipeline: pipeline) }