kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Emit `toggleSubscription` event on component instead of eventHub

This commit is contained in:
Kushal Pandya 2018-05-02 15:23:30 +05:30
parent c22a3fa0c5
commit de3194bf89
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/assets/javascripts/sidebar/components/subscriptions/subscriptions.vue
View File

@ -3,7 +3,6 @@
import icon from '~/vue_shared/components/icon.vue';
import toggleButton from '~/vue_shared/components/toggle_button.vue';
import tooltip from '~/vue_shared/directives/tooltip';
import eventHub from '../../event_hub';
const ICON_ON = 'notifications';
const ICON_OFF = 'notifications-off';
@ -48,7 +47,7 @@
},
methods: {
toggleSubscription() {
eventHub.$emit('toggleSubscription', this.id);
this.$emit('toggleSubscription', this.id);
},
},
};

8
spec/javascripts/sidebar/subscriptions_spec.js
View File

@ -39,4 +39,12 @@ describe('Subscriptions', function () {
expect(vm.$refs.toggleButton.$el.querySelector('.project-feature-toggle')).toHaveClass('is-checked');
});
it('toggleSubscription method emits `toggleSubscription` event on component', () => {
vm = mountComponent(Subscriptions, { subscribed: true });
spyOn(vm, '$emit');
vm.toggleSubscription();
expect(vm.$emit).toHaveBeenCalledWith('toggleSubscription', jasmine.any(Object));
});
});