diff --git a/.gitlab/issue_templates/Actionable Insight - Product change.md b/.gitlab/issue_templates/Actionable Insight - Product change.md index 7277cb7e9f2..6c030220636 100644 --- a/.gitlab/issue_templates/Actionable Insight - Product change.md +++ b/.gitlab/issue_templates/Actionable Insight - Product change.md @@ -29,4 +29,5 @@ This issue template is for an actionable insight that requires a change in the p /confidential /label ~"Actionable Insight::Product change" +/label ~"SUS" diff --git a/.rubocop.yml b/.rubocop.yml index 2280fe222ea..caa9d72ef47 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -517,24 +517,6 @@ Graphql/Descriptions: RSpec/ImplicitSubject: Enabled: false -# WIP See https://gitlab.com/gitlab-org/gitlab/-/issues/211580 -RSpec/LeakyConstantDeclaration: - Enabled: true - Exclude: - - 'spec/db/schema_spec.rb' - - 'spec/lib/feature_spec.rb' - - 'spec/lib/gitlab/config/entry/simplifiable_spec.rb' - - 'spec/lib/gitlab/quick_actions/dsl_spec.rb' - - 'spec/lib/marginalia_spec.rb' - - 'spec/mailers/notify_spec.rb' - - 'spec/models/concerns/batch_destroy_dependent_associations_spec.rb' - - 'spec/models/concerns/bulk_insert_safe_spec.rb' - - 'spec/models/concerns/bulk_insertable_associations_spec.rb' - - 'spec/models/concerns/triggerable_hooks_spec.rb' - - 'spec/models/repository_spec.rb' - - 'spec/services/clusters/applications/check_installation_progress_service_spec.rb' - - 'spec/support/shared_examples/quick_actions/issuable/issuable_quick_actions_shared_examples.rb' - RSpec/EmptyLineAfterHook: Enabled: false diff --git a/.rubocop_todo/rspec/leaky_constant_declaration.yml b/.rubocop_todo/rspec/leaky_constant_declaration.yml new file mode 100644 index 00000000000..b8b3980ef4f --- /dev/null +++ b/.rubocop_todo/rspec/leaky_constant_declaration.yml @@ -0,0 +1,15 @@ +--- +RSpec/LeakyConstantDeclaration: + Exclude: + - spec/db/schema_spec.rb + - spec/lib/gitlab/config/entry/simplifiable_spec.rb + - spec/lib/gitlab/quick_actions/dsl_spec.rb + - spec/lib/marginalia_spec.rb + - spec/mailers/notify_spec.rb + - spec/models/concerns/batch_destroy_dependent_associations_spec.rb + - spec/models/concerns/bulk_insert_safe_spec.rb + - spec/models/concerns/bulk_insertable_associations_spec.rb + - spec/models/concerns/triggerable_hooks_spec.rb + - spec/models/repository_spec.rb + - spec/services/clusters/applications/check_installation_progress_service_spec.rb + - spec/support/shared_examples/quick_actions/issuable/issuable_quick_actions_shared_examples.rb diff --git a/PROCESS.md b/PROCESS.md index 67abe2f0a98..2757075e354 100644 --- a/PROCESS.md +++ b/PROCESS.md @@ -22,7 +22,7 @@ - [Code format](#code-format) - [Issue fixed in newer version](#issue-fixed-in-newer-version) - [Improperly formatted merge request](#improperly-formatted-merge-request) - - [Accepting merge requests](#accepting-merge-requests) + - [Seeking community contributions](#seeking-community-contributions) - [Only accepting merge requests with green tests](#only-accepting-merge-requests-with-green-tests) @@ -195,14 +195,14 @@ Thanks for your interest in improving the GitLab codebase! Please update your merge request according to the [contributing guidelines](https://gitlab.com/gitlab-org/gitlab/blob/master/doc/development/contributing/merge_request_workflow.md#merge-request-guidelines). ``` -### Accepting merge requests +### Seeking community contributions ``` Is there an issue on the [issue tracker](https://gitlab.com/gitlab-org/gitlab/issues) that is similar to this? Could you please link it here? Please be aware that new functionality that is not marked -[`Accepting merge requests`](https://docs.gitlab.com/ee/development/contributing/issue_workflow.html#label-for-community-contributors) +[`Seeking community contributions`](https://docs.gitlab.com/ee/development/contributing/issue_workflow.html#label-for-community-contributors) might not make it into GitLab. ``` diff --git a/app/assets/javascripts/analytics/shared/components/daterange.vue b/app/assets/javascripts/analytics/shared/components/daterange.vue index a5b9c40b9c9..7df66d1b2be 100644 --- a/app/assets/javascripts/analytics/shared/components/daterange.vue +++ b/app/assets/javascripts/analytics/shared/components/daterange.vue @@ -1,5 +1,5 @@