kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

use $ sign to make it clear when dealing with jQuery object

Browse source
This commit is contained in:
Mike Greiling 2016-12-11 21:35:19 -06:00
parent 4f8087d62b
commit de427dc589
1 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
app/assets/javascripts/preview_markdown.js
View file

@ -16,19 +16,19 @@
MarkdownPreview.prototype.ajaxCache = {};
MarkdownPreview.prototype.showPreview = function(form) {
MarkdownPreview.prototype.showPreview = function($form) {
var mdText, preview;
preview = form.find('.js-md-preview');
mdText = form.find('textarea.markdown-area').val();
preview = $form.find('.js-md-preview');
mdText = $form.find('textarea.markdown-area').val();
if (mdText.trim().length === 0) {
preview.text('Nothing to preview.');
this.hideReferencedUsers(form);
this.hideReferencedUsers($form);
} else {
preview.text('Loading...');
this.renderMarkdown(mdText, (function(response) {
preview.html(response.body);
preview.renderGFM();
this.renderReferencedUsers(response.references.users, form);
this.renderReferencedUsers(response.references.users, $form);
}).bind(this));
}
};
@ -58,13 +58,13 @@
});
};
MarkdownPreview.prototype.hideReferencedUsers = function(form) {
form.find('.referenced-users').hide();
MarkdownPreview.prototype.hideReferencedUsers = function($form) {
$form.find('.referenced-users').hide();
};
MarkdownPreview.prototype.renderReferencedUsers = function(users, form) {
MarkdownPreview.prototype.renderReferencedUsers = function(users, $form) {
var referencedUsers;
referencedUsers = form.find('.referenced-users');
referencedUsers = $form.find('.referenced-users');
if (referencedUsers.length) {
if (users.length >= this.referenceThreshold) {
referencedUsers.show();