kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Remove 'build-page' from 'ide-terminal' element 

CE Port

**Why?**
The styles applied to `.build-page .top-bar` were mostly
unecessary for the IDE terminal. The static positioning might
have also been causing a strange line to show up in the terminal.
This commit is contained in:
Paul Slaughter 2019-06-06 20:48:02 -05:00
parent f08abfcc32
commit de4b2c6a10
No known key found for this signature in database
GPG Key ID: DF5690803C68282A
2 changed files with 17 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
app/assets/stylesheets/framework/mixins.scss
View File

@ -218,16 +218,22 @@
}
}
@mixin build-trace-top-bar($height) {
// Used in EE for Web Terminal
@mixin build-trace-bar($height) {
height: $height;
min-height: $height;
background: $gray-light;
border: 1px solid $border-color;
color: $gl-text-color;
padding: $grid-size;
}
@mixin build-trace-top-bar($height) {
@include build-trace-bar($height);
position: -webkit-sticky;
position: sticky;
top: $header-height;
padding: $grid-size;
.with-performance-bar & {
top: $header-height + $performance-bar-height;

18
app/assets/stylesheets/page_bundles/_ide_mixins.scss
View File

@ -2,17 +2,17 @@
display: flex;
flex-direction: column;
height: 100%;
margin-top: -$grid-size;
margin-bottom: -$grid-size;
&.build-page .top-bar {
top: 0;
height: auto;
font-size: 12px;
border-top-right-radius: $border-radius-default;
}
.top-bar {
@include build-trace-bar(35px);
top: 0;
font-size: 12px;
border-top-right-radius: $border-radius-default;
margin-left: -$gl-padding;
.controllers {
@include build-controllers(15px, center, false, 0, inline, 0);
}
}
}