feedback code review

This commit is contained in:
Pascal Betz 2016-09-07 21:59:29 +02:00
parent 1112b5a283
commit de6a44fae6
3 changed files with 3 additions and 2 deletions

View File

@ -12,6 +12,7 @@ v 8.12.0 (unreleased)
- Change merge_error column from string to text type
- Reduce contributions calendar data payload (ClemMakesApps)
- Add `web_url` field to issue, merge request, and snippet API objects (Ben Boeckel)
- Move parsing of sidekiq ps into helper !6245 (pascalbetz)
- Expose `sha` and `merge_commit_sha` in merge request API (Ben Boeckel)
- Set path for all JavaScript cookies to honor GitLab's subdirectory setting !5627 (Mike Greiling)
- Fix bug where pagination is still displayed despite all todos marked as done (ClemMakesApps)

View File

@ -6,7 +6,7 @@ module SidekiqHelper
if match
match[1..6]
else
%w{? ? ? ? ? ?}
%w[? ? ? ? ? ?]
end
end
end

View File

@ -29,7 +29,7 @@
%tbody
- @sidekiq_processes.each do |process|
%td= gitlab_config.user
-parse_sidekiq_ps(process).each do |value|
- parse_sidekiq_ps(process).each do |value|
%td= value
.clearfix
%p