Merge branch 'update-rubocop' into 'master'
Update rubocop to 0.41.2 Adds a couple of cops to the TODO files, but I wanted [a specific cop](https://github.com/bbatsov/rubocop/pull/3135/files) which just had about 65 offences, so Ill do that later. See merge request !4999
This commit is contained in:
Robert Speicher
commit
dfea11e1e7
4 changed files with 473 additions and 364 deletions
361
.rubocop.yml
361
.rubocop.yml
|
|
@ -2,6 +2,8 @@ require:
|
|||
- rubocop-rspec
|
||||
- ./rubocop/rubocop
|
||||
|
||||
inherit_from: .rubocop_todo.yml
|
||||
|
||||
AllCops:
|
||||
TargetRubyVersion: 2.1
|
||||
# Cop names are not displayed in offense messages by default. Change behavior
|
||||
|
|
@ -52,14 +54,6 @@ Style/AlignArray:
|
|||
Style/AlignHash:
|
||||
Enabled: true
|
||||
|
||||
# Align the parameters of a method call if they span more than one line.
|
||||
Style/AlignParameters:
|
||||
Enabled: false
|
||||
|
||||
# Use &&/|| instead of and/or.
|
||||
Style/AndOr:
|
||||
Enabled: false
|
||||
|
||||
# Use `Array#join` instead of `Array#*`.
|
||||
Style/ArrayJoin:
|
||||
Enabled: true
|
||||
|
|
@ -80,10 +74,6 @@ Style/Attr:
|
|||
Style/BeginBlock:
|
||||
Enabled: true
|
||||
|
||||
# Checks if usage of %() or %Q() matches configuration.
|
||||
Style/BarePercentLiterals:
|
||||
Enabled: false
|
||||
|
||||
# Do not use block comments.
|
||||
Style/BlockComments:
|
||||
Enabled: true
|
||||
|
|
@ -97,14 +87,6 @@ Style/BlockEndNewline:
|
|||
Style/BlockDelimiters:
|
||||
Enabled: true
|
||||
|
||||
# Enforce braces style around hash parameters.
|
||||
Style/BracesAroundHashParameters:
|
||||
Enabled: false
|
||||
|
||||
# Avoid explicit use of the case equality operator(===).
|
||||
Style/CaseEquality:
|
||||
Enabled: false
|
||||
|
||||
# Indentation of when in a case/when/[else/]end.
|
||||
Style/CaseIndentation:
|
||||
Enabled: true
|
||||
|
|
@ -133,24 +115,10 @@ Style/ClassMethods:
|
|||
Style/ClassVars:
|
||||
Enabled: true
|
||||
|
||||
# Do not use :: for method call.
|
||||
Style/ColonMethodCall:
|
||||
Enabled: false
|
||||
|
||||
# Checks formatting of special comments (TODO, FIXME, OPTIMIZE, HACK, REVIEW).
|
||||
Style/CommentAnnotation:
|
||||
Enabled: false
|
||||
|
||||
# Indentation of comments.
|
||||
Style/CommentIndentation:
|
||||
Enabled: true
|
||||
|
||||
# Use the return value of `if` and `case` statements for assignment to a
|
||||
# variable and variable comparison instead of assigning that variable
|
||||
# inside of each branch.
|
||||
Style/ConditionalAssignment:
|
||||
Enabled: false
|
||||
|
||||
# Constants should use SCREAMING_SNAKE_CASE.
|
||||
Style/ConstantName:
|
||||
Enabled: true
|
||||
|
|
@ -159,34 +127,14 @@ Style/ConstantName:
|
|||
Style/DefWithParentheses:
|
||||
Enabled: true
|
||||
|
||||
# Checks for use of deprecated Hash methods.
|
||||
Style/DeprecatedHashMethods:
|
||||
Enabled: false
|
||||
|
||||
# Document classes and non-namespace modules.
|
||||
Style/Documentation:
|
||||
Enabled: false
|
||||
|
||||
# Checks the position of the dot in multi-line method calls.
|
||||
Style/DotPosition:
|
||||
Enabled: false
|
||||
|
||||
# Checks for uses of double negation (!!).
|
||||
Style/DoubleNegation:
|
||||
Enabled: false
|
||||
|
||||
# Prefer `each_with_object` over `inject` or `reduce`.
|
||||
Style/EachWithObject:
|
||||
Enabled: false
|
||||
|
||||
# Align elses and elsifs correctly.
|
||||
Style/ElseAlignment:
|
||||
Enabled: true
|
||||
|
||||
# Avoid empty else-clauses.
|
||||
Style/EmptyElse:
|
||||
Enabled: false
|
||||
|
||||
# Use empty lines between defs.
|
||||
Style/EmptyLineBetweenDefs:
|
||||
Enabled: false
|
||||
|
|
@ -215,10 +163,6 @@ Style/EmptyLinesAroundModuleBody:
|
|||
Style/EmptyLinesAroundMethodBody:
|
||||
Enabled: false
|
||||
|
||||
# Prefer literals to Array.new/Hash.new/String.new.
|
||||
Style/EmptyLiteral:
|
||||
Enabled: false
|
||||
|
||||
# Avoid the use of END blocks.
|
||||
Style/EndBlock:
|
||||
Enabled: true
|
||||
|
|
@ -231,10 +175,6 @@ Style/EndOfLine:
|
|||
Style/EvenOdd:
|
||||
Enabled: true
|
||||
|
||||
# Do not use unnecessary spacing.
|
||||
Style/ExtraSpacing:
|
||||
Enabled: false
|
||||
|
||||
# Use snake_case for source file names.
|
||||
Style/FileName:
|
||||
Enabled: true
|
||||
|
|
@ -252,31 +192,15 @@ Style/FlipFlop:
|
|||
Style/For:
|
||||
Enabled: true
|
||||
|
||||
# Enforce the use of Kernel#sprintf, Kernel#format or String#%.
|
||||
Style/FormatString:
|
||||
Enabled: false
|
||||
|
||||
# Do not introduce global variables.
|
||||
Style/GlobalVars:
|
||||
Enabled: true
|
||||
|
||||
# Check for conditionals that can be replaced with guard clauses.
|
||||
Style/GuardClause:
|
||||
Enabled: false
|
||||
|
||||
# Prefer Ruby 1.9 hash syntax `{ a: 1, b: 2 }`
|
||||
# over 1.8 syntax `{ :a => 1, :b => 2 }`.
|
||||
Style/HashSyntax:
|
||||
Enabled: true
|
||||
|
||||
# Finds if nodes inside else, which can be converted to elsif.
|
||||
Style/IfInsideElse:
|
||||
Enabled: false
|
||||
|
||||
# Favor modifier if/unless usage when you have a single-line body.
|
||||
Style/IfUnlessModifier:
|
||||
Enabled: false
|
||||
|
||||
# Do not use if x; .... Use the ternary operator instead.
|
||||
Style/IfWithSemicolon:
|
||||
Enabled: true
|
||||
|
|
@ -299,22 +223,10 @@ Style/IndentationConsistency:
|
|||
Style/IndentationWidth:
|
||||
Enabled: true
|
||||
|
||||
# Checks the indentation of the first element in an array literal.
|
||||
Style/IndentArray:
|
||||
Enabled: false
|
||||
|
||||
# Checks the indentation of the first key in a hash literal.
|
||||
Style/IndentHash:
|
||||
Enabled: false
|
||||
|
||||
# Use Kernel#loop for infinite loops.
|
||||
Style/InfiniteLoop:
|
||||
Enabled: true
|
||||
|
||||
# Use the new lambda literal syntax for single-line blocks.
|
||||
Style/Lambda:
|
||||
Enabled: false
|
||||
|
||||
# Use lambda.call(...) instead of lambda.(...).
|
||||
Style/LambdaCall:
|
||||
Enabled: true
|
||||
|
|
@ -323,14 +235,6 @@ Style/LambdaCall:
|
|||
Style/LeadingCommentSpace:
|
||||
Enabled: true
|
||||
|
||||
# Use \ instead of + or << to concatenate two string literals at line end.
|
||||
Style/LineEndConcatenation:
|
||||
Enabled: false
|
||||
|
||||
# Do not use parentheses for method calls with no arguments.
|
||||
Style/MethodCallParentheses:
|
||||
Enabled: false
|
||||
|
||||
# Checks if the method definitions have or don't have parentheses.
|
||||
Style/MethodDefParentheses:
|
||||
Enabled: true
|
||||
|
|
@ -387,39 +291,18 @@ Style/MultilineMethodDefinitionBraceLayout:
|
|||
Style/MultilineOperationIndentation:
|
||||
Enabled: false
|
||||
|
||||
# Avoid multi-line `? :` (the ternary operator), use if/unless instead.
|
||||
Style/MultilineTernaryOperator:
|
||||
Enabled: false
|
||||
|
||||
# Do not assign mutable objects to constants.
|
||||
Style/MutableConstant:
|
||||
Enabled: false
|
||||
|
||||
# Favor unless over if for negative conditions (or control flow or).
|
||||
Style/NegatedIf:
|
||||
Enabled: true
|
||||
|
||||
# Favor until over while for negative conditions.
|
||||
Style/NegatedWhile:
|
||||
Enabled: false
|
||||
|
||||
# Avoid using nested modifiers.
|
||||
Style/NestedModifier:
|
||||
Enabled: true
|
||||
|
||||
# Parenthesize method calls which are nested inside the argument list of
|
||||
# another parenthesized method call.
|
||||
Style/NestedParenthesizedCalls:
|
||||
Enabled: false
|
||||
|
||||
# Use one expression per branch in a ternary operator.
|
||||
Style/NestedTernaryOperator:
|
||||
Enabled: true
|
||||
|
||||
# Use `next` to skip iteration instead of a condition at the end.
|
||||
Style/Next:
|
||||
Enabled: false
|
||||
|
||||
# Prefer x.nil? to x == nil.
|
||||
Style/NilComparison:
|
||||
Enabled: true
|
||||
|
|
@ -444,51 +327,10 @@ Style/OneLineConditional:
|
|||
Style/OpMethod:
|
||||
Enabled: true
|
||||
|
||||
# Check for simple usages of parallel assignment. It will only warn when
|
||||
# the number of variables matches on both sides of the assignment.
|
||||
Style/ParallelAssignment:
|
||||
Enabled: false
|
||||
|
||||
# Don't use parentheses around the condition of an if/unless/while.
|
||||
Style/ParenthesesAroundCondition:
|
||||
Enabled: true
|
||||
|
||||
# Use `%`-literal delimiters consistently.
|
||||
Style/PercentLiteralDelimiters:
|
||||
Enabled: false
|
||||
|
||||
# Checks if uses of %Q/%q match the configured preference.
|
||||
Style/PercentQLiterals:
|
||||
Enabled: false
|
||||
|
||||
# Avoid Perl-style regex back references.
|
||||
Style/PerlBackrefs:
|
||||
Enabled: false
|
||||
|
||||
# Check the names of predicate methods.
|
||||
Style/PredicateName:
|
||||
Enabled: false
|
||||
|
||||
# Use proc instead of Proc.new.
|
||||
Style/Proc:
|
||||
Enabled: false
|
||||
|
||||
# Checks the arguments passed to raise/fail.
|
||||
Style/RaiseArgs:
|
||||
Enabled: false
|
||||
|
||||
# Don't use begin blocks when they are not needed.
|
||||
Style/RedundantBegin:
|
||||
Enabled: false
|
||||
|
||||
# Checks for an obsolete RuntimeException argument in raise/fail.
|
||||
Style/RedundantException:
|
||||
Enabled: false
|
||||
|
||||
# Checks usages of Object#freeze on immutable objects.
|
||||
Style/RedundantFreeze:
|
||||
Enabled: false
|
||||
|
||||
# Checks for parentheses that seem not to serve any purpose.
|
||||
Style/RedundantParentheses:
|
||||
Enabled: true
|
||||
|
|
@ -497,24 +339,6 @@ Style/RedundantParentheses:
|
|||
Style/RedundantReturn:
|
||||
Enabled: true
|
||||
|
||||
# Don't use self where it's not needed.
|
||||
Style/RedundantSelf:
|
||||
Enabled: false
|
||||
|
||||
# Use %r for regular expressions matching more than `MaxSlashes` '/'
|
||||
# characters. Use %r only for regular expressions matching more
|
||||
# than `MaxSlashes` '/' character.
|
||||
Style/RegexpLiteral:
|
||||
Enabled: false
|
||||
|
||||
# Avoid using rescue in its modifier form.
|
||||
Style/RescueModifier:
|
||||
Enabled: false
|
||||
|
||||
# Checks for places where self-assignment shorthand should have been used.
|
||||
Style/SelfAssignment:
|
||||
Enabled: false
|
||||
|
||||
# Don't use semicolons to terminate expressions.
|
||||
Style/Semicolon:
|
||||
Enabled: true
|
||||
|
|
@ -524,14 +348,6 @@ Style/SignalException:
|
|||
EnforcedStyle: only_raise
|
||||
Enabled: true
|
||||
|
||||
# Enforces the names of some block params.
|
||||
Style/SingleLineBlockParams:
|
||||
Enabled: false
|
||||
|
||||
# Avoid single-line methods.
|
||||
Style/SingleLineMethods:
|
||||
Enabled: false
|
||||
|
||||
# Use spaces after colons.
|
||||
Style/SpaceAfterColon:
|
||||
Enabled: true
|
||||
|
|
@ -553,11 +369,6 @@ Style/SpaceAfterNot:
|
|||
Style/SpaceAfterSemicolon:
|
||||
Enabled: true
|
||||
|
||||
# Checks that the equals signs in parameter default assignments have or don't
|
||||
# have surrounding space depending on configuration.
|
||||
Style/SpaceAroundEqualsInParameterDefault:
|
||||
Enabled: false
|
||||
|
||||
# Use a space around keywords if appropriate.
|
||||
Style/SpaceAroundKeyword:
|
||||
Enabled: true
|
||||
|
|
@ -566,10 +377,6 @@ Style/SpaceAroundKeyword:
|
|||
Style/SpaceAroundOperators:
|
||||
Enabled: true
|
||||
|
||||
# Checks that the left block brace has or doesn't have space before it.
|
||||
Style/SpaceBeforeBlockBraces:
|
||||
Enabled: false
|
||||
|
||||
# No spaces before commas.
|
||||
Style/SpaceBeforeComma:
|
||||
Enabled: true
|
||||
|
|
@ -578,33 +385,14 @@ Style/SpaceBeforeComma:
|
|||
Style/SpaceBeforeComment:
|
||||
Enabled: true
|
||||
|
||||
# Checks that exactly one space is used between a method name and the first
|
||||
# argument for method calls without parentheses.
|
||||
Style/SpaceBeforeFirstArg:
|
||||
Enabled: false
|
||||
|
||||
# No spaces before semicolons.
|
||||
Style/SpaceBeforeSemicolon:
|
||||
Enabled: true
|
||||
|
||||
# Checks that block braces have or don't have surrounding space.
|
||||
# For blocks taking parameters, checks that the left brace has or doesn't
|
||||
# have trailing space.
|
||||
Style/SpaceInsideBlockBraces:
|
||||
Enabled: false
|
||||
|
||||
# No spaces after [ or before ].
|
||||
Style/SpaceInsideBrackets:
|
||||
Enabled: false
|
||||
|
||||
# Use spaces inside hash literal braces - or don't.
|
||||
Style/SpaceInsideHashLiteralBraces:
|
||||
Enabled: true
|
||||
|
||||
# No spaces after ( or before ).
|
||||
Style/SpaceInsideParens:
|
||||
Enabled: false
|
||||
|
||||
# No spaces inside range literals.
|
||||
Style/SpaceInsideRangeLiteral:
|
||||
Enabled: true
|
||||
|
|
@ -614,10 +402,6 @@ Style/SpaceInsideStringInterpolation:
|
|||
EnforcedStyle: no_space
|
||||
Enabled: true
|
||||
|
||||
# Avoid Perl-style global variables.
|
||||
Style/SpecialGlobalVars:
|
||||
Enabled: false
|
||||
|
||||
# Check for the usage of parentheses around stabby lambda arguments.
|
||||
Style/StabbyLambdaParentheses:
|
||||
EnforcedStyle: require_parentheses
|
||||
|
|
@ -627,25 +411,12 @@ Style/StabbyLambdaParentheses:
|
|||
Style/StringLiterals:
|
||||
Enabled: false
|
||||
|
||||
# Checks if uses of quotes inside expressions in interpolated strings match the
|
||||
# configured preference.
|
||||
Style/StringLiteralsInInterpolation:
|
||||
Enabled: false
|
||||
|
||||
# Checks if configured preferred methods are used over non-preferred.
|
||||
Style/StringMethods:
|
||||
PreferredMethods:
|
||||
intern: to_sym
|
||||
Enabled: true
|
||||
|
||||
# Use %i or %I for arrays of symbols.
|
||||
Style/SymbolArray:
|
||||
Enabled: false
|
||||
|
||||
# Use symbols as procs instead of blocks when possible.
|
||||
Style/SymbolProc:
|
||||
Enabled: false
|
||||
|
||||
# No hard tabs.
|
||||
Style/Tab:
|
||||
Enabled: true
|
||||
|
|
@ -654,40 +425,10 @@ Style/Tab:
|
|||
Style/TrailingBlankLines:
|
||||
Enabled: true
|
||||
|
||||
# Checks for trailing comma in array and hash literals.
|
||||
Style/TrailingCommaInLiteral:
|
||||
Enabled: false
|
||||
|
||||
# Checks for trailing comma in argument lists.
|
||||
Style/TrailingCommaInArguments:
|
||||
Enabled: false
|
||||
|
||||
# Avoid trailing whitespace.
|
||||
Style/TrailingWhitespace:
|
||||
Enabled: false
|
||||
|
||||
# Checks for the usage of unneeded trailing underscores at the end of
|
||||
# parallel variable assignment.
|
||||
Style/TrailingUnderscoreVariable:
|
||||
Enabled: false
|
||||
|
||||
# Prefer attr_* methods to trivial readers/writers.
|
||||
Style/TrivialAccessors:
|
||||
Enabled: false
|
||||
|
||||
# Do not use unless with else. Rewrite these with the positive case first.
|
||||
Style/UnlessElse:
|
||||
Enabled: false
|
||||
|
||||
# Checks for %W when interpolation is not needed.
|
||||
Style/UnneededCapitalW:
|
||||
Enabled: true
|
||||
|
||||
# TODO: Enable UnneededInterpolation Cop.
|
||||
# Checks for strings that are just an interpolated expression.
|
||||
Style/UnneededInterpolation:
|
||||
Enabled: false
|
||||
|
||||
# Checks for %q/%Q when single quotes or double quotes would do.
|
||||
Style/UnneededPercentQ:
|
||||
Enabled: false
|
||||
|
|
@ -717,12 +458,6 @@ Style/WhileUntilModifier:
|
|||
Style/WordArray:
|
||||
Enabled: false
|
||||
|
||||
# TODO: Enable ZeroLengthPredicate Cop.
|
||||
# Use #empty? when testing for objects of length 0.
|
||||
Style/ZeroLengthPredicate:
|
||||
Enabled: false
|
||||
|
||||
|
||||
#################### Metrics ################################
|
||||
|
||||
# A calculated magnitude based on number of assignments,
|
||||
|
|
@ -776,15 +511,6 @@ Metrics/PerceivedComplexity:
|
|||
Lint/AmbiguousOperator:
|
||||
Enabled: true
|
||||
|
||||
# Checks for ambiguous regexp literals in the first argument of a method
|
||||
# invocation without parentheses.
|
||||
Lint/AmbiguousRegexpLiteral:
|
||||
Enabled: false
|
||||
|
||||
# Don't use assignment in conditions.
|
||||
Lint/AssignmentInCondition:
|
||||
Enabled: false
|
||||
|
||||
# Align block ends correctly.
|
||||
Lint/BlockAlignment:
|
||||
Enabled: true
|
||||
|
|
@ -810,14 +536,6 @@ Lint/DefEndAlignment:
|
|||
Lint/DeprecatedClassMethods:
|
||||
Enabled: true
|
||||
|
||||
# Check for duplicate method definitions.
|
||||
Lint/DuplicateMethods:
|
||||
Enabled: false
|
||||
|
||||
# Check for duplicate keys in hash literals.
|
||||
Lint/DuplicatedKey:
|
||||
Enabled: false
|
||||
|
||||
# Check for immutable argument given to each_with_object.
|
||||
Lint/EachWithObjectArgument:
|
||||
Enabled: true
|
||||
|
|
@ -830,10 +548,6 @@ Lint/ElseLayout:
|
|||
Lint/EmptyEnsure:
|
||||
Enabled: true
|
||||
|
||||
# Checks for empty string interpolation.
|
||||
Lint/EmptyInterpolation:
|
||||
Enabled: false
|
||||
|
||||
# Align ends correctly.
|
||||
Lint/EndAlignment:
|
||||
Enabled: true
|
||||
|
|
@ -858,21 +572,11 @@ Lint/FloatOutOfRange:
|
|||
Lint/FormatParameterMismatch:
|
||||
Enabled: true
|
||||
|
||||
# Don't suppress exception.
|
||||
Lint/HandleExceptions:
|
||||
Enabled: false
|
||||
|
||||
# Checks for adjacent string literals on the same line, which could better be
|
||||
# represented as a single string literal.
|
||||
Lint/ImplicitStringConcatenation:
|
||||
Enabled: true
|
||||
|
||||
# TODO: Enable IneffectiveAccessModifier Cop.
|
||||
# Checks for attempts to use `private` or `protected` to set the visibility
|
||||
# of a class method, which does not work.
|
||||
Lint/IneffectiveAccessModifier:
|
||||
Enabled: false
|
||||
|
||||
# Checks for invalid character literals with a non-escaped whitespace
|
||||
# character.
|
||||
Lint/InvalidCharacterLiteral:
|
||||
|
|
@ -886,11 +590,6 @@ Lint/LiteralInCondition:
|
|||
Lint/LiteralInInterpolation:
|
||||
Enabled: true
|
||||
|
||||
# Use Kernel#loop with break rather than begin/end/until or begin/end/while
|
||||
# for post-loop tests.
|
||||
Lint/Loop:
|
||||
Enabled: false
|
||||
|
||||
# Do not use nested method definitions.
|
||||
Lint/NestedMethodDefinition:
|
||||
Enabled: true
|
||||
|
|
@ -916,13 +615,8 @@ Lint/RequireParentheses:
|
|||
Lint/RescueException:
|
||||
Enabled: true
|
||||
|
||||
# Do not use the same name as outer local variable for block arguments
|
||||
# or block local variables.
|
||||
Lint/ShadowingOuterLocalVariable:
|
||||
Enabled: false
|
||||
|
||||
# 'Checks for Object#to_s usage in string interpolation.
|
||||
Lint/StringConversionInInterpolation:
|
||||
# Checks for the order which exceptions are rescued to avoid rescueing a less specific exception before a more specific exception.
|
||||
Lint/ShadowedException:
|
||||
Enabled: false
|
||||
|
||||
# Do not use prefix `_` for a variable that is used.
|
||||
|
|
@ -935,22 +629,10 @@ Lint/UnderscorePrefixedVariableName:
|
|||
Lint/UnneededDisable:
|
||||
Enabled: false
|
||||
|
||||
# Checks for unused block arguments.
|
||||
Lint/UnusedBlockArgument:
|
||||
Enabled: false
|
||||
|
||||
# Checks for unused method arguments.
|
||||
Lint/UnusedMethodArgument:
|
||||
Enabled: false
|
||||
|
||||
# Unreachable code.
|
||||
Lint/UnreachableCode:
|
||||
Enabled: true
|
||||
|
||||
# Checks for useless access modifiers.
|
||||
Lint/UselessAccessModifier:
|
||||
Enabled: false
|
||||
|
||||
# Checks for useless assignment to a local variable.
|
||||
Lint/UselessAssignment:
|
||||
Enabled: true
|
||||
|
|
@ -983,11 +665,6 @@ Performance/Casecmp:
|
|||
Performance/DoubleStartEndWith:
|
||||
Enabled: true
|
||||
|
||||
# TODO: Enable EndWith Cop.
|
||||
# Use `end_with?` instead of a regex match anchored to the end of a string.
|
||||
Performance/EndWith:
|
||||
Enabled: false
|
||||
|
||||
# Use `strip` instead of `lstrip.rstrip`.
|
||||
Performance/LstripRstrip:
|
||||
Enabled: true
|
||||
|
|
@ -996,24 +673,6 @@ Performance/LstripRstrip:
|
|||
Performance/RangeInclude:
|
||||
Enabled: true
|
||||
|
||||
# TODO: Enable RedundantBlockCall Cop.
|
||||
# Use `yield` instead of `block.call`.
|
||||
Performance/RedundantBlockCall:
|
||||
Enabled: false
|
||||
|
||||
# TODO: Enable RedundantMatch Cop.
|
||||
# Use `=~` instead of `String#match` or `Regexp#match` in a context where the
|
||||
# returned `MatchData` is not needed.
|
||||
Performance/RedundantMatch:
|
||||
Enabled: false
|
||||
|
||||
# TODO: Enable RedundantMerge Cop.
|
||||
# Use `Hash#[]=`, rather than `Hash#merge!` with a single key-value pair.
|
||||
Performance/RedundantMerge:
|
||||
# Max number of key-value pairs to consider an offense
|
||||
MaxKeyValuePairs: 2
|
||||
Enabled: false
|
||||
|
||||
# Use `sort` instead of `sort_by { |x| x }`.
|
||||
Performance/RedundantSortBy:
|
||||
Enabled: true
|
||||
|
|
@ -1082,18 +741,6 @@ Rails/ReadWriteAttribute:
|
|||
Rails/ScopeArgs:
|
||||
Enabled: true
|
||||
|
||||
# Checks the correct usage of time zone aware methods.
|
||||
# http://danilenko.org/2012/7/6/rails_timezones
|
||||
Rails/TimeZone:
|
||||
Enabled: false
|
||||
|
||||
# Use validates :attribute, hash of validations.
|
||||
Rails/Validation:
|
||||
Enabled: false
|
||||
|
||||
Rails/UniqBeforePluck:
|
||||
Enabled: false
|
||||
|
||||
##################### RSpec ##################################
|
||||
|
||||
# Check that instances are not being stubbed globally.
|
||||
|
|
|
|||
462
.rubocop_todo.yml
Normal file
462
.rubocop_todo.yml
Normal file
|
|
@ -0,0 +1,462 @@
|
|||
# This configuration was generated by
|
||||
# `rubocop --auto-gen-config --exclude-limit 0`
|
||||
# on 2016-07-13 12:36:08 -0600 using RuboCop version 0.41.2.
|
||||
# The point is for the user to remove these configuration records
|
||||
# one by one as the offenses are removed from the code base.
|
||||
# Note that changes in the inspected code, or installation of new
|
||||
# versions of RuboCop, may require this file to be generated again.
|
||||
|
||||
# Offense count: 154
|
||||
Lint/AmbiguousRegexpLiteral:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 43
|
||||
# Configuration parameters: AllowSafeAssignment.
|
||||
Lint/AssignmentInCondition:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 14
|
||||
Lint/HandleExceptions:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 21
|
||||
Lint/IneffectiveAccessModifier:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 2
|
||||
Lint/Loop:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 15
|
||||
Lint/ShadowingOuterLocalVariable:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 3
|
||||
# Cop supports --auto-correct.
|
||||
Lint/StringConversionInInterpolation:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 44
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
|
||||
Lint/UnusedBlockArgument:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 129
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
|
||||
Lint/UnusedMethodArgument:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 11
|
||||
Lint/UselessAccessModifier:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 12
|
||||
# Cop supports --auto-correct.
|
||||
Performance/PushSplat:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 2
|
||||
# Cop supports --auto-correct.
|
||||
Performance/RedundantBlockCall:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 4
|
||||
# Cop supports --auto-correct.
|
||||
Performance/RedundantMatch:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 24
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: MaxKeyValuePairs.
|
||||
Performance/RedundantMerge:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 60
|
||||
Rails/OutputSafety:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 128
|
||||
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
||||
# SupportedStyles: strict, flexible
|
||||
Rails/TimeZone:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 12
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: Include.
|
||||
# Include: app/models/**/*.rb
|
||||
Rails/Validation:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 217
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
|
||||
# SupportedStyles: with_first_parameter, with_fixed_indentation
|
||||
Style/AlignParameters:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 32
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
||||
# SupportedStyles: always, conditionals
|
||||
Style/AndOr:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 47
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
||||
# SupportedStyles: percent_q, bare_percent
|
||||
Style/BarePercentLiterals:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 258
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
||||
# SupportedStyles: braces, no_braces, context_dependent
|
||||
Style/BracesAroundHashParameters:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 5
|
||||
Style/CaseEquality:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 19
|
||||
# Cop supports --auto-correct.
|
||||
Style/ColonMethodCall:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 3
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: Keywords.
|
||||
# Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW
|
||||
Style/CommentAnnotation:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 34
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle, SupportedStyles, SingleLineConditionsOnly.
|
||||
# SupportedStyles: assign_to_condition, assign_inside_condition
|
||||
Style/ConditionalAssignment:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 789
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
||||
# SupportedStyles: leading, trailing
|
||||
Style/DotPosition:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 13
|
||||
Style/DoubleNegation:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 3
|
||||
Style/EachWithObject:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 30
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
||||
# SupportedStyles: empty, nil, both
|
||||
Style/EmptyElse:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 3
|
||||
# Cop supports --auto-correct.
|
||||
Style/EmptyLiteral:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 123
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
|
||||
Style/ExtraSpacing:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 7
|
||||
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
||||
# SupportedStyles: format, sprintf, percent
|
||||
Style/FormatString:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 48
|
||||
# Configuration parameters: MinBodyLength.
|
||||
Style/GuardClause:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 11
|
||||
Style/IfInsideElse:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 177
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: MaxLineLength.
|
||||
Style/IfUnlessModifier:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 52
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
|
||||
# SupportedStyles: special_inside_parentheses, consistent, align_brackets
|
||||
Style/IndentArray:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 89
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
|
||||
# SupportedStyles: special_inside_parentheses, consistent, align_braces
|
||||
Style/IndentHash:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 12
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
||||
# SupportedStyles: line_count_dependent, lambda, literal
|
||||
Style/Lambda:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 6
|
||||
# Cop supports --auto-correct.
|
||||
Style/LineEndConcatenation:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 13
|
||||
# Cop supports --auto-correct.
|
||||
Style/MethodCallParentheses:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 3
|
||||
Style/MultilineTernaryOperator:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 62
|
||||
# Cop supports --auto-correct.
|
||||
Style/MutableConstant:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 10
|
||||
# Cop supports --auto-correct.
|
||||
Style/NestedParenthesizedCalls:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 12
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
|
||||
# SupportedStyles: skip_modifier_ifs, always
|
||||
Style/Next:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 8
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedOctalStyle, SupportedOctalStyles.
|
||||
# SupportedOctalStyles: zero_with_o, zero_only
|
||||
Style/NumericLiteralPrefix:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 29
|
||||
# Cop supports --auto-correct.
|
||||
Style/ParallelAssignment:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 208
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: PreferredDelimiters.
|
||||
Style/PercentLiteralDelimiters:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 11
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
||||
# SupportedStyles: lower_case_q, upper_case_q
|
||||
Style/PercentQLiterals:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 13
|
||||
# Cop supports --auto-correct.
|
||||
Style/PerlBackrefs:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 32
|
||||
# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
|
||||
# NamePrefix: is_, has_, have_
|
||||
# NamePrefixBlacklist: is_, has_, have_
|
||||
# NameWhitelist: is_a?
|
||||
Style/PredicateName:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 28
|
||||
# Cop supports --auto-correct.
|
||||
Style/PreferredHashMethods:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 6
|
||||
# Cop supports --auto-correct.
|
||||
Style/Proc:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 20
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
||||
# SupportedStyles: compact, exploded
|
||||
Style/RaiseArgs:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 3
|
||||
# Cop supports --auto-correct.
|
||||
Style/RedundantBegin:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 1
|
||||
# Cop supports --auto-correct.
|
||||
Style/RedundantException:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 23
|
||||
# Cop supports --auto-correct.
|
||||
Style/RedundantFreeze:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 377
|
||||
# Cop supports --auto-correct.
|
||||
Style/RedundantSelf:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 94
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes.
|
||||
# SupportedStyles: slashes, percent_r, mixed
|
||||
Style/RegexpLiteral:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 17
|
||||
# Cop supports --auto-correct.
|
||||
Style/RescueModifier:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 2
|
||||
# Cop supports --auto-correct.
|
||||
Style/SelfAssignment:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 2
|
||||
# Configuration parameters: Methods.
|
||||
# Methods: {"reduce"=>["a", "e"]}, {"inject"=>["a", "e"]}
|
||||
Style/SingleLineBlockParams:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 50
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: AllowIfMethodIsEmpty.
|
||||
Style/SingleLineMethods:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 14
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
||||
# SupportedStyles: space, no_space
|
||||
Style/SpaceAroundEqualsInParameterDefault:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 119
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
||||
# SupportedStyles: space, no_space
|
||||
Style/SpaceBeforeBlockBraces:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 11
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: AllowForAlignment.
|
||||
Style/SpaceBeforeFirstArg:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 130
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
|
||||
# SupportedStyles: space, no_space
|
||||
Style/SpaceInsideBlockBraces:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 98
|
||||
# Cop supports --auto-correct.
|
||||
Style/SpaceInsideBrackets:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 60
|
||||
# Cop supports --auto-correct.
|
||||
Style/SpaceInsideParens:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 5
|
||||
# Cop supports --auto-correct.
|
||||
Style/SpaceInsidePercentLiteralDelimiters:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 36
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: SupportedStyles.
|
||||
# SupportedStyles: use_perl_names, use_english_names
|
||||
Style/SpecialGlobalVars:
|
||||
EnforcedStyle: use_perl_names
|
||||
|
||||
# Offense count: 30
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
||||
# SupportedStyles: single_quotes, double_quotes
|
||||
Style/StringLiteralsInInterpolation:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 24
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: IgnoredMethods.
|
||||
# IgnoredMethods: respond_to, define_method
|
||||
Style/SymbolProc:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 23
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
|
||||
# SupportedStyles: comma, consistent_comma, no_comma
|
||||
Style/TrailingCommaInArguments:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 113
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
|
||||
# SupportedStyles: comma, consistent_comma, no_comma
|
||||
Style/TrailingCommaInLiteral:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 7
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: AllowNamedUnderscoreVariables.
|
||||
Style/TrailingUnderscoreVariable:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 90
|
||||
# Cop supports --auto-correct.
|
||||
Style/TrailingWhitespace:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 2
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
|
||||
# Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
|
||||
Style/TrivialAccessors:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 3
|
||||
# Cop supports --auto-correct.
|
||||
Style/UnlessElse:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 13
|
||||
# Cop supports --auto-correct.
|
||||
Style/UnneededInterpolation:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 8
|
||||
# Cop supports --auto-correct.
|
||||
Style/ZeroLengthPredicate:
|
||||
Enabled: false
|
||||
2
Gemfile
2
Gemfile
|
|
@ -299,7 +299,7 @@ group :development, :test do
|
|||
gem 'spring-commands-spinach', '~> 1.1.0'
|
||||
gem 'spring-commands-teaspoon', '~> 0.0.2'
|
||||
|
||||
gem 'rubocop', '~> 0.40.0', require: false
|
||||
gem 'rubocop', '~> 0.41.2', require: false
|
||||
gem 'rubocop-rspec', '~> 1.5.0', require: false
|
||||
gem 'scss_lint', '~> 0.47.0', require: false
|
||||
gem 'simplecov', '~> 0.11.0', require: false
|
||||
|
|
|
|||
12
Gemfile.lock
12
Gemfile.lock
|
|
@ -58,7 +58,7 @@ GEM
|
|||
faraday_middleware-multi_json (~> 0.0)
|
||||
oauth2 (~> 1.0)
|
||||
asciidoctor (1.5.3)
|
||||
ast (2.2.0)
|
||||
ast (2.3.0)
|
||||
attr_encrypted (3.0.1)
|
||||
encryptor (~> 3.0.0)
|
||||
attr_required (1.0.0)
|
||||
|
|
@ -473,7 +473,7 @@ GEM
|
|||
orm_adapter (0.5.0)
|
||||
paranoia (2.1.4)
|
||||
activerecord (~> 4.0)
|
||||
parser (2.3.1.0)
|
||||
parser (2.3.1.2)
|
||||
ast (~> 2.2)
|
||||
pg (0.18.4)
|
||||
pkg-config (1.1.7)
|
||||
|
|
@ -606,8 +606,8 @@ GEM
|
|||
rspec-retry (0.4.5)
|
||||
rspec-core
|
||||
rspec-support (3.5.0)
|
||||
rubocop (0.40.0)
|
||||
parser (>= 2.3.1.0, < 3.0)
|
||||
rubocop (0.41.2)
|
||||
parser (>= 2.3.1.1, < 3.0)
|
||||
powerpack (~> 0.1)
|
||||
rainbow (>= 1.99.1, < 3.0)
|
||||
ruby-progressbar (~> 1.7)
|
||||
|
|
@ -758,7 +758,7 @@ GEM
|
|||
unf (0.1.4)
|
||||
unf_ext
|
||||
unf_ext (0.0.7.2)
|
||||
unicode-display_width (1.0.5)
|
||||
unicode-display_width (1.1.0)
|
||||
unicorn (4.9.0)
|
||||
kgio (~> 2.6)
|
||||
rack
|
||||
|
|
@ -937,7 +937,7 @@ DEPENDENCIES
|
|||
rqrcode-rails3 (~> 0.1.7)
|
||||
rspec-rails (~> 3.5.0)
|
||||
rspec-retry (~> 0.4.5)
|
||||
rubocop (~> 0.40.0)
|
||||
rubocop (~> 0.41.2)
|
||||
rubocop-rspec (~> 1.5.0)
|
||||
ruby-fogbugz (~> 0.2.1)
|
||||
sanitize (~> 2.0)
|
||||
|
|
|
|||
Loading…
Reference in a new issue