Fixed issue link href

This commit is contained in:
Phil Hughes 2017-01-30 16:26:42 +00:00 committed by Fatih Acet
parent 6c828906a2
commit e140675eef
3 changed files with 16 additions and 6 deletions

View file

@ -9,7 +9,7 @@
gl.issueBoards.IssuesModal = Vue.extend({
props: [
'blankStateImage', 'newIssuePath', 'bulkUpdatePath',
'blankStateImage', 'newIssuePath', 'bulkUpdatePath', 'issueLinkBase',
],
data() {
return ModalStore.store;
@ -81,7 +81,9 @@
v-if="showAddIssuesModal">
<div class="add-issues-container">
<modal-header></modal-header>
<modal-list v-if="!loading && showList"></modal-list>
<modal-list
:issue-link-base="issueLinkBase"
v-if="!loading && showList"></modal-list>
<empty-state
v-if="(!loading && issues.length === 0) || (activeTab === 'selected' && selectedIssues.length === 0)"
:image="blankStateImage"

View file

@ -6,6 +6,9 @@
const ModalStore = gl.issueBoards.ModalStore;
gl.issueBoards.ModalList = Vue.extend({
props: [
'issueLinkBase',
],
data() {
return ModalStore.store;
},
@ -34,7 +37,11 @@
},
},
methods: {
toggleIssue: ModalStore.toggleIssue.bind(ModalStore),
toggleIssue(e, issue) {
if (e.target.tagName !== 'A') {
ModalStore.toggleIssue(issue);
}
},
listHeight() {
return this.$refs.list.getBoundingClientRect().height;
},
@ -100,10 +107,10 @@
<div
class="card"
:class="{ 'is-active': issue.selected }"
@click="toggleIssue(issue)">
@click="toggleIssue($event, issue)">
<issue-card-inner
:issue="issue"
:issue-link-base="'/'">
:issue-link-base="issueLinkBase">
</issue-card-inner>
<span
v-if="issue.selected"

View file

@ -28,4 +28,5 @@
= render "projects/boards/components/sidebar"
%board-add-issues-modal{ "blank-state-image" => render('shared/empty_states/icons/issues.svg'),
"new-issue-path" => new_namespace_project_issue_path(@project.namespace, @project),
"bulk-update-path" => bulk_update_namespace_project_issues_path(@project.namespace, @project) }
"bulk-update-path" => bulk_update_namespace_project_issues_path(@project.namespace, @project),
":issue-link-base" => "issueLinkBase" }