Rename ActiverecordSerialize cop
This cop has been renamed to ActiveRecordSerialize to match the way "ActiveRecord" is usually written.
This commit is contained in:
parent
6f1e00ea36
commit
e1a3bf30b6
|
@ -13,13 +13,13 @@ class ApplicationSetting < ActiveRecord::Base
|
|||
[\r\n] # any number of newline characters
|
||||
}x
|
||||
|
||||
serialize :restricted_visibility_levels # rubocop:disable Cop/ActiverecordSerialize
|
||||
serialize :import_sources # rubocop:disable Cop/ActiverecordSerialize
|
||||
serialize :disabled_oauth_sign_in_sources, Array # rubocop:disable Cop/ActiverecordSerialize
|
||||
serialize :domain_whitelist, Array # rubocop:disable Cop/ActiverecordSerialize
|
||||
serialize :domain_blacklist, Array # rubocop:disable Cop/ActiverecordSerialize
|
||||
serialize :repository_storages # rubocop:disable Cop/ActiverecordSerialize
|
||||
serialize :sidekiq_throttling_queues, Array # rubocop:disable Cop/ActiverecordSerialize
|
||||
serialize :restricted_visibility_levels # rubocop:disable Cop/ActiveRecordSerialize
|
||||
serialize :import_sources # rubocop:disable Cop/ActiveRecordSerialize
|
||||
serialize :disabled_oauth_sign_in_sources, Array # rubocop:disable Cop/ActiveRecordSerialize
|
||||
serialize :domain_whitelist, Array # rubocop:disable Cop/ActiveRecordSerialize
|
||||
serialize :domain_blacklist, Array # rubocop:disable Cop/ActiveRecordSerialize
|
||||
serialize :repository_storages # rubocop:disable Cop/ActiveRecordSerialize
|
||||
serialize :sidekiq_throttling_queues, Array # rubocop:disable Cop/ActiveRecordSerialize
|
||||
|
||||
cache_markdown_field :sign_in_text
|
||||
cache_markdown_field :help_page_text
|
||||
|
|
|
@ -1,5 +1,5 @@
|
|||
class AuditEvent < ActiveRecord::Base
|
||||
serialize :details, Hash # rubocop:disable Cop/ActiverecordSerialize
|
||||
serialize :details, Hash # rubocop:disable Cop/ActiveRecordSerialize
|
||||
|
||||
belongs_to :user, foreign_key: :author_id
|
||||
|
||||
|
|
|
@ -19,8 +19,8 @@ module Ci
|
|||
)
|
||||
end
|
||||
|
||||
serialize :options # rubocop:disable Cop/ActiverecordSerialize
|
||||
serialize :yaml_variables, Gitlab::Serializer::Ci::Variables # rubocop:disable Cop/ActiverecordSerialize
|
||||
serialize :options # rubocop:disable Cop/ActiveRecordSerialize
|
||||
serialize :yaml_variables, Gitlab::Serializer::Ci::Variables # rubocop:disable Cop/ActiveRecordSerialize
|
||||
|
||||
delegate :name, to: :project, prefix: true
|
||||
|
||||
|
|
|
@ -6,7 +6,7 @@ module Ci
|
|||
belongs_to :pipeline, foreign_key: :commit_id
|
||||
has_many :builds
|
||||
|
||||
serialize :variables # rubocop:disable Cop/ActiverecordSerialize
|
||||
serialize :variables # rubocop:disable Cop/ActiveRecordSerialize
|
||||
|
||||
def user_variables
|
||||
return [] unless variables
|
||||
|
|
|
@ -6,9 +6,9 @@ class DiffNote < Note
|
|||
|
||||
NOTEABLE_TYPES = %w(MergeRequest Commit).freeze
|
||||
|
||||
serialize :original_position, Gitlab::Diff::Position # rubocop:disable Cop/ActiverecordSerialize
|
||||
serialize :position, Gitlab::Diff::Position # rubocop:disable Cop/ActiverecordSerialize
|
||||
serialize :change_position, Gitlab::Diff::Position # rubocop:disable Cop/ActiverecordSerialize
|
||||
serialize :original_position, Gitlab::Diff::Position # rubocop:disable Cop/ActiveRecordSerialize
|
||||
serialize :position, Gitlab::Diff::Position # rubocop:disable Cop/ActiveRecordSerialize
|
||||
serialize :change_position, Gitlab::Diff::Position # rubocop:disable Cop/ActiveRecordSerialize
|
||||
|
||||
validates :original_position, presence: true
|
||||
validates :position, presence: true
|
||||
|
|
|
@ -50,7 +50,7 @@ class Event < ActiveRecord::Base
|
|||
belongs_to :target, polymorphic: true # rubocop:disable Cop/PolymorphicAssociations
|
||||
|
||||
# For Hash only
|
||||
serialize :data # rubocop:disable Cop/ActiverecordSerialize
|
||||
serialize :data # rubocop:disable Cop/ActiveRecordSerialize
|
||||
|
||||
# Callbacks
|
||||
after_create :reset_project_activity
|
||||
|
|
|
@ -1,9 +1,9 @@
|
|||
class WebHookLog < ActiveRecord::Base
|
||||
belongs_to :web_hook
|
||||
|
||||
serialize :request_headers, Hash # rubocop:disable Cop/ActiverecordSerialize
|
||||
serialize :request_data, Hash # rubocop:disable Cop/ActiverecordSerialize
|
||||
serialize :response_headers, Hash # rubocop:disable Cop/ActiverecordSerialize
|
||||
serialize :request_headers, Hash # rubocop:disable Cop/ActiveRecordSerialize
|
||||
serialize :request_data, Hash # rubocop:disable Cop/ActiveRecordSerialize
|
||||
serialize :response_headers, Hash # rubocop:disable Cop/ActiveRecordSerialize
|
||||
|
||||
validates :web_hook, presence: true
|
||||
|
||||
|
|
|
@ -7,7 +7,7 @@
|
|||
class LegacyDiffNote < Note
|
||||
include NoteOnDiff
|
||||
|
||||
serialize :st_diff # rubocop:disable Cop/ActiverecordSerialize
|
||||
serialize :st_diff # rubocop:disable Cop/ActiveRecordSerialize
|
||||
|
||||
validates :line_code, presence: true, line_code: true
|
||||
|
||||
|
|
|
@ -26,7 +26,7 @@ class MergeRequest < ActiveRecord::Base
|
|||
|
||||
belongs_to :assignee, class_name: "User"
|
||||
|
||||
serialize :merge_params, Hash # rubocop:disable Cop/ActiverecordSerialize
|
||||
serialize :merge_params, Hash # rubocop:disable Cop/ActiveRecordSerialize
|
||||
|
||||
after_create :ensure_merge_request_diff, unless: :importing?
|
||||
after_update :reload_diff_if_branch_changed
|
||||
|
|
|
@ -12,8 +12,8 @@ class MergeRequestDiff < ActiveRecord::Base
|
|||
belongs_to :merge_request
|
||||
has_many :merge_request_diff_files, -> { order(:merge_request_diff_id, :relative_order) }
|
||||
|
||||
serialize :st_commits # rubocop:disable Cop/ActiverecordSerialize
|
||||
serialize :st_diffs # rubocop:disable Cop/ActiverecordSerialize
|
||||
serialize :st_commits # rubocop:disable Cop/ActiveRecordSerialize
|
||||
serialize :st_diffs # rubocop:disable Cop/ActiveRecordSerialize
|
||||
|
||||
state_machine :state, initial: :empty do
|
||||
state :collected
|
||||
|
|
|
@ -3,7 +3,7 @@ class PersonalAccessToken < ActiveRecord::Base
|
|||
include TokenAuthenticatable
|
||||
add_authentication_token_field :token
|
||||
|
||||
serialize :scopes, Array # rubocop:disable Cop/ActiverecordSerialize
|
||||
serialize :scopes, Array # rubocop:disable Cop/ActiveRecordSerialize
|
||||
|
||||
belongs_to :user
|
||||
|
||||
|
|
|
@ -10,7 +10,7 @@ class ProjectImportData < ActiveRecord::Base
|
|||
insecure_mode: true,
|
||||
algorithm: 'aes-256-cbc'
|
||||
|
||||
serialize :data, JSON # rubocop:disable Cop/ActiverecordSerialize
|
||||
serialize :data, JSON # rubocop:disable Cop/ActiveRecordSerialize
|
||||
|
||||
validates :project, presence: true
|
||||
|
||||
|
|
|
@ -1,5 +1,5 @@
|
|||
class SentNotification < ActiveRecord::Base
|
||||
serialize :position, Gitlab::Diff::Position # rubocop:disable Cop/ActiverecordSerialize
|
||||
serialize :position, Gitlab::Diff::Position # rubocop:disable Cop/ActiveRecordSerialize
|
||||
|
||||
belongs_to :project
|
||||
belongs_to :noteable, polymorphic: true # rubocop:disable Cop/PolymorphicAssociations
|
||||
|
|
|
@ -2,7 +2,7 @@
|
|||
# and implement a set of methods
|
||||
class Service < ActiveRecord::Base
|
||||
include Sortable
|
||||
serialize :properties, JSON # rubocop:disable Cop/ActiverecordSerialize
|
||||
serialize :properties, JSON # rubocop:disable Cop/ActiveRecordSerialize
|
||||
|
||||
default_value_for :active, false
|
||||
default_value_for :push_events, true
|
||||
|
|
|
@ -41,7 +41,7 @@ class User < ActiveRecord::Base
|
|||
otp_secret_encryption_key: Gitlab::Application.secrets.otp_key_base
|
||||
|
||||
devise :two_factor_backupable, otp_number_of_backup_codes: 10
|
||||
serialize :otp_backup_codes, JSON # rubocop:disable Cop/ActiverecordSerialize
|
||||
serialize :otp_backup_codes, JSON # rubocop:disable Cop/ActiveRecordSerialize
|
||||
|
||||
devise :lockable, :recoverable, :rememberable, :trackable,
|
||||
:validatable, :omniauthable, :confirmable, :registerable
|
||||
|
|
|
@ -3,7 +3,7 @@ require_relative '../model_helpers'
|
|||
module RuboCop
|
||||
module Cop
|
||||
# Cop that prevents the use of `serialize` in ActiveRecord models.
|
||||
class ActiverecordSerialize < RuboCop::Cop::Cop
|
||||
class ActiveRecordSerialize < RuboCop::Cop::Cop
|
||||
include ModelHelpers
|
||||
|
||||
MSG = 'Do not store serialized data in the database, use separate columns and/or tables instead'.freeze
|
|
@ -1,6 +1,6 @@
|
|||
require_relative 'cop/custom_error_class'
|
||||
require_relative 'cop/gem_fetcher'
|
||||
require_relative 'cop/activerecord_serialize'
|
||||
require_relative 'cop/active_record_serialize'
|
||||
require_relative 'cop/redirect_with_status'
|
||||
require_relative 'cop/polymorphic_associations'
|
||||
require_relative 'cop/project_path_helper'
|
||||
|
|
|
@ -1,9 +1,9 @@
|
|||
require 'spec_helper'
|
||||
require 'rubocop'
|
||||
require 'rubocop/rspec/support'
|
||||
require_relative '../../../rubocop/cop/activerecord_serialize'
|
||||
require_relative '../../../rubocop/cop/active_record_serialize'
|
||||
|
||||
describe RuboCop::Cop::ActiverecordSerialize do
|
||||
describe RuboCop::Cop::ActiveRecordSerialize do
|
||||
include CopHelper
|
||||
|
||||
subject(:cop) { described_class.new }
|
Loading…
Reference in New Issue