From e1f037980fda1620c2ba6ed407c35349989275fa Mon Sep 17 00:00:00 2001 From: Richard Clamp Date: Wed, 8 Nov 2017 12:13:47 +0000 Subject: [PATCH] Fix test selection in Test::Integration::Mattermost In ce3b81b953f we changed Test::Integration::Mattermost#perform to consume a required positional parameter and pass on the rest of the arguments to the superclass. There was an error in implementation here and instead of splatting the files array to produce no additional arguments, we passed in the default case an empty array. This had the effect of calling rspec with no test files, rather than expected default of 'qa/specs/features` Here we correct that bug, and re-add the :core suite, as that was a poor deuction in the investagtion for 74d6b8a211. --- qa/qa/scenario/test/integration/mattermost.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qa/qa/scenario/test/integration/mattermost.rb b/qa/qa/scenario/test/integration/mattermost.rb index 59d7dcd3d23..0220da929ce 100644 --- a/qa/qa/scenario/test/integration/mattermost.rb +++ b/qa/qa/scenario/test/integration/mattermost.rb @@ -7,11 +7,11 @@ module QA # including staging and on-premises installation. # class Mattermost < Scenario::Entrypoint - tags :mattermost + tags :core, :mattermost def perform(address, mattermost, *files) Runtime::Scenario.mattermost = mattermost - super(address, files) + super(address, *files) end end end