kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Improve PipelinesFinder spec so that it does not depend on hard-coded database IDs

Browse source 
Fixes failed builds such as https://gitlab.com/gitlab-org/gitlab-ce/builds/3919501
This commit is contained in:
Stan Hu 2016-09-09 16:21:46 -04:00
parent 796bdf1dcb
commit e300e9d5ef
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
spec/finders/pipelines_finder_spec.rb
View file

@ -43,9 +43,10 @@ describe PipelinesFinder do
let(:params) { { scope: 'running' } }
it 'orders in descending order on ID' do
create(:ci_pipeline, project: project, ref: 'feature')
feature_pipeline = create(:ci_pipeline, project: project, ref: 'feature')
expect(subject.map(&:id)).to eq [3, 2, 1]
expected_ids = [feature_pipeline.id, branch_pipeline.id, tag_pipeline.id].sort.reverse
expect(subject.map(&:id)).to eq expected_ids
end
end
end