Suppress whitespace warnings in squash error messages
These are obscuring the real error, which is confusing for everyone.
This commit is contained in:
parent
bb0fe96f75
commit
e351f67874
2 changed files with 15 additions and 1 deletions
|
@ -2206,7 +2206,7 @@ module Gitlab
|
|||
with_worktree(squash_path, branch, sparse_checkout_files: diff_files, env: env) do
|
||||
# Apply diff of the `diff_range` to the worktree
|
||||
diff = run_git!(%W(diff --binary #{diff_range}))
|
||||
run_git!(%w(apply --index), chdir: squash_path, env: env) do |stdin|
|
||||
run_git!(%w(apply --index --whitespace=nowarn), chdir: squash_path, env: env) do |stdin|
|
||||
stdin.binmode
|
||||
stdin.write(diff)
|
||||
end
|
||||
|
|
|
@ -2283,6 +2283,20 @@ describe Gitlab::Git::Repository, seed_helper: true do
|
|||
expect(subject).to match(/\h{40}/)
|
||||
end
|
||||
end
|
||||
|
||||
context 'with trailing whitespace in an invalid patch', :skip_gitaly_mock do
|
||||
let(:diff) { "diff --git a/README.md b/README.md\nindex faaf198..43c5edf 100644\n--- a/README.md\n+++ b/README.md\n@@ -1,4 +1,4 @@\n-testme\n+ \n ====== \n \n Sample repo for testing gitlab features\n" }
|
||||
|
||||
it 'does not include whitespace warnings in the error' do
|
||||
allow(repository).to receive(:run_git!).and_call_original
|
||||
allow(repository).to receive(:run_git!).with(%W(diff --binary #{start_sha}...#{end_sha})).and_return(diff.force_encoding('ASCII-8BIT'))
|
||||
|
||||
expect { subject }.to raise_error do |error|
|
||||
expect(error).to be_a(described_class::GitError)
|
||||
expect(error.message).not_to include('trailing whitespace')
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
|
|
Loading…
Reference in a new issue