kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Simplify implementation of environments serializer

Browse source
This commit is contained in:
Grzegorz Bizon 2017-02-07 13:11:15 +01:00
parent 14bf5c1009
commit e4cb073bc0
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
app/serializers/environment_serializer.rb
View file

@ -1,5 +1,5 @@
class EnvironmentSerializer < BaseSerializer
Struct.new('Item', :name, :size, :id, :latest)
Item = Struct.new(:name, :size, :latest)
entity EnvironmentEntity
@ -41,11 +41,10 @@ class EnvironmentSerializer < BaseSerializer
'COUNT(*) AS environments_count',
'MAX(id) AS last_environment_id')
environments = resource.where(id: items.map(&:last))
.order('COALESCE(environment_type, name) ASC')
environments = resource.where(id: items.map(&:last)).index_by(&:id)
items.zip(environments).map do |item|
Struct::Item.new(*item.flatten)
items.map do |name, size, id|
Item.new(name, size, environments[id])
end
end
end