From e57d99947a8837ef3bfe20022f4c5b3ad735ec8f Mon Sep 17 00:00:00 2001 From: Brett Walker Date: Wed, 5 Sep 2018 08:14:16 -0500 Subject: [PATCH] remove guard clause and add comment on performace --- lib/feature.rb | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/lib/feature.rb b/lib/feature.rb index 15ce487ad4e..f4b57376313 100644 --- a/lib/feature.rb +++ b/lib/feature.rb @@ -42,12 +42,16 @@ class Feature persisted_names.include?(feature.name.to_s) end + # use `default_enabled: true` to default the flag to being `enabled` + # unless set explicitly. The default is `disabled` def enabled?(key, thing = nil, default_enabled: false) feature = Feature.get(key) - return feature.enabled?(thing) unless default_enabled - # If the feature has been set, always evaluate - Feature.persisted?(feature) ? feature.enabled?(thing) : true + # If we're not default enabling the flag or the feature has been set, always evaluate. + # `persisted?` can potentially generate DB queries and also checks for inclusion + # in an array of feature names (177 at last count), possibly reducing performance by half. + # So we only perform the `persisted` check if `default_enabled: true` + !default_enabled || Feature.persisted?(feature) ? feature.enabled?(thing) : true end def disabled?(key, thing = nil, default_enabled: false)