kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Allow for the passing of options to external_link

Browse source
This commit is contained in:
jakeburden 2019-09-03 17:26:39 -04:00
parent 90dc19e9f0
commit e6090e713b
2 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/helpers/external_link_helper.rb
View file

@ -1,8 +1,8 @@
# frozen_string_literal: true
module ExternalLinkHelper
def external_link(body, url)
link_to url, target: '_blank', rel: 'noopener noreferrer' do
def external_link(body, url, options = {})
link_to url, { target: '_blank', rel: 'noopener noreferrer' }.merge(options) do
"#{body} #{icon('external-link')}".html_safe
end
end

5
spec/helpers/external_link_helper_spec.rb
View file

@ -9,4 +9,9 @@ describe ExternalLinkHelper do
expect(external_link('https://gitlab.com', 'https://gitlab.com').to_s)
.to eq('<a target="_blank" rel="noopener noreferrer" href="https://gitlab.com">https://gitlab.com <i aria-hidden="true" data-hidden="true" class="fa fa-external-link"></i></a>')
end
it 'allows options when creating external link with icon' do
expect(external_link('https://gitlab.com', 'https://gitlab.com', { "data-foo": "bar", class: "externalLink" }).to_s)
.to eq('<a target="_blank" rel="noopener noreferrer" data-foo="bar" class="externalLink" href="https://gitlab.com">https://gitlab.com <i aria-hidden="true" data-hidden="true" class="fa fa-external-link"></i></a>')
end
end