Improve readability of specs for pipeline stages
This commit is contained in:
parent
cff9c16be7
commit
e66b0414cb
|
@ -122,55 +122,80 @@ describe Ci::Pipeline, models: true do
|
|||
end
|
||||
end
|
||||
|
||||
describe '#stages' do
|
||||
describe 'pipeline stages' do
|
||||
before do
|
||||
create(:commit_status, pipeline: pipeline, stage: 'build', name: 'linux', stage_idx: 0, status: 'success')
|
||||
create(:commit_status, pipeline: pipeline, stage: 'build', name: 'mac', stage_idx: 0, status: 'failed')
|
||||
create(:commit_status, pipeline: pipeline, stage: 'deploy', name: 'staging', stage_idx: 2, status: 'running')
|
||||
create(:commit_status, pipeline: pipeline, stage: 'test', name: 'rspec', stage_idx: 1, status: 'success')
|
||||
create(:commit_status, pipeline: pipeline,
|
||||
stage: 'build',
|
||||
name: 'linux',
|
||||
stage_idx: 0,
|
||||
status: 'success')
|
||||
|
||||
create(:commit_status, pipeline: pipeline,
|
||||
stage: 'build',
|
||||
name: 'mac',
|
||||
stage_idx: 0,
|
||||
status: 'failed')
|
||||
|
||||
create(:commit_status, pipeline: pipeline,
|
||||
stage: 'deploy',
|
||||
name: 'staging',
|
||||
stage_idx: 2,
|
||||
status: 'running')
|
||||
|
||||
create(:commit_status, pipeline: pipeline,
|
||||
stage: 'test',
|
||||
name: 'rspec',
|
||||
stage_idx: 1,
|
||||
status: 'success')
|
||||
end
|
||||
|
||||
subject { pipeline.stages }
|
||||
describe '#stages' do
|
||||
subject { pipeline.stages }
|
||||
|
||||
context 'stages list' do
|
||||
it 'returns ordered list of stages' do
|
||||
expect(subject.map(&:name)).to eq(%w[build test deploy])
|
||||
end
|
||||
end
|
||||
|
||||
it 'returns a valid number of stages' do
|
||||
expect(pipeline.stages_count).to eq(3)
|
||||
end
|
||||
|
||||
it 'returns a valid names of stages' do
|
||||
expect(pipeline.stages_name).to eq(['build', 'test', 'deploy'])
|
||||
end
|
||||
|
||||
context 'stages with statuses' do
|
||||
let(:statuses) do
|
||||
subject.map do |stage|
|
||||
[stage.name, stage.status]
|
||||
context 'stages list' do
|
||||
it 'returns ordered list of stages' do
|
||||
expect(subject.map(&:name)).to eq(%w[build test deploy])
|
||||
end
|
||||
end
|
||||
|
||||
it 'returns list of stages with statuses' do
|
||||
expect(statuses).to eq([['build', 'failed'],
|
||||
['test', 'success'],
|
||||
['deploy', 'running']
|
||||
])
|
||||
end
|
||||
|
||||
context 'when build is retried' do
|
||||
before do
|
||||
create(:commit_status, pipeline: pipeline, stage: 'build', name: 'mac', stage_idx: 0, status: 'success')
|
||||
context 'stages with statuses' do
|
||||
let(:statuses) do
|
||||
subject.map { |stage| [stage.name, stage.status] }
|
||||
end
|
||||
|
||||
it 'ignores the previous state' do
|
||||
expect(statuses).to eq([['build', 'success'],
|
||||
it 'returns list of stages with correct statuses' do
|
||||
expect(statuses).to eq([['build', 'failed'],
|
||||
['test', 'success'],
|
||||
['deploy', 'running']
|
||||
])
|
||||
['deploy', 'running']])
|
||||
end
|
||||
|
||||
context 'when commit status is retried' do
|
||||
before do
|
||||
create(:commit_status, pipeline: pipeline,
|
||||
stage: 'build',
|
||||
name: 'mac',
|
||||
stage_idx: 0,
|
||||
status: 'success')
|
||||
end
|
||||
|
||||
it 'ignores the previous state' do
|
||||
expect(statuses).to eq([['build', 'success'],
|
||||
['test', 'success'],
|
||||
['deploy', 'running']])
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
describe '#stages_count' do
|
||||
it 'returns a valid number of stages' do
|
||||
expect(pipeline.stages_count).to eq(3)
|
||||
end
|
||||
end
|
||||
|
||||
describe '#stages_name' do
|
||||
it 'returns a valid names of stages' do
|
||||
expect(pipeline.stages_name).to eq(['build', 'test', 'deploy'])
|
||||
end
|
||||
end
|
||||
end
|
||||
|
|
Loading…
Reference in New Issue