diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 94d8d40c10f..300706a4d8e 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -325,7 +325,6 @@ Performance/Sum: - 'lib/container_registry/tag.rb' - 'lib/gitlab/ci/reports/test_suite_comparer.rb' - 'lib/gitlab/diff/file.rb' - - 'lib/gitlab/sherlock/transaction.rb' - 'lib/gitlab/usage_data.rb' - 'lib/peek/views/detailed_view.rb' - 'spec/models/namespace/root_storage_statistics_spec.rb' diff --git a/.rubocop_todo/database/multiple_databases.yml b/.rubocop_todo/database/multiple_databases.yml index f2768276060..7329d178dc1 100644 --- a/.rubocop_todo/database/multiple_databases.yml +++ b/.rubocop_todo/database/multiple_databases.yml @@ -26,7 +26,6 @@ Database/MultipleDatabases: - lib/gitlab/import_export/group/relation_tree_restorer.rb - lib/gitlab/legacy_github_import/importer.rb - lib/gitlab/seeder.rb - - lib/gitlab/sherlock/query.rb - lib/system_check/orphans/repository_check.rb - spec/db/schema_spec.rb - spec/initializers/database_config_spec.rb diff --git a/.rubocop_todo/rails/time_zone.yml b/.rubocop_todo/rails/time_zone.yml index 0e2b036c312..86d0632ac47 100644 --- a/.rubocop_todo/rails/time_zone.yml +++ b/.rubocop_todo/rails/time_zone.yml @@ -76,7 +76,6 @@ Rails/TimeZone: - lib/gitlab/prometheus/queries/additional_metrics_environment_query.rb - lib/gitlab/prometheus/queries/matched_metric_query.rb - lib/gitlab/prometheus_client.rb - - lib/gitlab/sherlock/transaction.rb - lib/gitlab/task_helpers.rb - lib/gitlab/x509/tag.rb - lib/grafana/time_window.rb @@ -141,7 +140,6 @@ Rails/TimeZone: - spec/lib/gitlab/prometheus/queries/additional_metrics_deployment_query_spec.rb - spec/lib/gitlab/prometheus/queries/deployment_query_spec.rb - spec/lib/gitlab/prometheus/queries/validate_query_spec.rb - - spec/lib/gitlab/sherlock/transaction_spec.rb - spec/lib/gitlab/sidekiq_logging/json_formatter_spec.rb - spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/strategies/until_executing_spec.rb - spec/lib/gitlab/updated_notes_paginator_spec.rb diff --git a/app/assets/javascripts/vue_merge_request_widget/components/states/merge_checks_failed.vue b/app/assets/javascripts/vue_merge_request_widget/components/states/merge_checks_failed.vue index 574ff8b3b2f..701ef89304c 100644 --- a/app/assets/javascripts/vue_merge_request_widget/components/states/merge_checks_failed.vue +++ b/app/assets/javascripts/vue_merge_request_widget/components/states/merge_checks_failed.vue @@ -6,7 +6,7 @@ export default { i18n: { approvalNeeded: s__('mrWidget|Merge blocked: this merge request must be approved.'), blockingMergeRequests: s__( - 'mrWidget|Merge blocked: you can only merge once above items are resolved.', + 'mrWidget|Merge blocked: you can only merge after the above items are resolved.', ), }, components: { diff --git a/app/assets/javascripts/vue_shared/components/sidebar/labels_select_widget/dropdown_contents.vue b/app/assets/javascripts/vue_shared/components/sidebar/labels_select_widget/dropdown_contents.vue index 13a6dd43207..0fa64a29b3a 100644 --- a/app/assets/javascripts/vue_shared/components/sidebar/labels_select_widget/dropdown_contents.vue +++ b/app/assets/javascripts/vue_shared/components/sidebar/labels_select_widget/dropdown_contents.vue @@ -179,6 +179,9 @@ export default { this.searchKey = ''; this.setFocus(); }, + selectFirstItem() { + this.$refs.dropdownContentsView.selectFirstItem(); + }, }, }; @@ -204,11 +207,13 @@ export default { @toggleDropdownContentsCreateView="toggleDropdownContent" @closeDropdown="$emit('closeDropdown')" @input="debouncedSearchKeyUpdate" + @searchEnter="selectFirstItem" />