From e7393191ee209beb1d39727384e4be21434415c6 Mon Sep 17 00:00:00 2001 From: Andreas Brandl Date: Sun, 18 Mar 2018 17:00:41 +0100 Subject: [PATCH] Replace public_send calls. --- app/models/concerns/atomic_internal_id.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/models/concerns/atomic_internal_id.rb b/app/models/concerns/atomic_internal_id.rb index 6895c7d7e95..4b66725a3e6 100644 --- a/app/models/concerns/atomic_internal_id.rb +++ b/app/models/concerns/atomic_internal_id.rb @@ -27,12 +27,12 @@ module AtomicInternalId module ClassMethods def has_internal_id(column, scope:, init:) # rubocop:disable Naming/PredicateName before_validation(on: :create) do - if self.public_send(column).blank? # rubocop:disable GitlabSecurity/PublicSend - scope_attrs = { scope => self.public_send(scope) } # rubocop:disable GitlabSecurity/PublicSend + if read_attribute(column).blank? + scope_attrs = { scope => association(scope).reader } usage = self.class.table_name.to_sym new_iid = InternalId.generate_next(self, scope_attrs, usage, init) - self.public_send("#{column}=", new_iid) # rubocop:disable GitlabSecurity/PublicSend + write_attribute(column, new_iid) end end