From b7860b30aa4cf9d6b40ef2766912b366d916a9c7 Mon Sep 17 00:00:00 2001 From: Felipe Artur Date: Fri, 7 Jul 2017 19:21:00 -0300 Subject: [PATCH] fix milestones finder failing spec --- app/finders/milestones_finder.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/finders/milestones_finder.rb b/app/finders/milestones_finder.rb index 23c42a5f662..0a5a0ea2f35 100644 --- a/app/finders/milestones_finder.rb +++ b/app/finders/milestones_finder.rb @@ -49,7 +49,8 @@ class MilestonesFinder if params.has_key?(:order) items.reorder(params[:order]) else - items.reorder('due_date ASC') + order_statement = Gitlab::Database.nulls_last_order('due_date', 'ASC') + items.reorder(order_statement) end end end