Extract anonymous user context in pipelines specs
This commit is contained in:
parent
6a7a31b82a
commit
e83ae21d98
1 changed files with 255 additions and 244 deletions
|
@ -7,148 +7,55 @@ describe 'Pipelines', :feature, :js do
|
|||
include WaitForAjax
|
||||
|
||||
let(:project) { create(:empty_project) }
|
||||
let(:user) { create(:user) }
|
||||
|
||||
before do
|
||||
login_as(user)
|
||||
project.team << [user, :developer]
|
||||
end
|
||||
context 'when user is logged in' do
|
||||
let(:user) { create(:user) }
|
||||
|
||||
describe 'GET /:project/pipelines' do
|
||||
let(:project) { create(:project) }
|
||||
|
||||
let!(:pipeline) do
|
||||
create(
|
||||
:ci_empty_pipeline,
|
||||
project: project,
|
||||
ref: 'master',
|
||||
status: 'running',
|
||||
sha: project.commit.id,
|
||||
)
|
||||
before do
|
||||
login_as(user)
|
||||
project.team << [user, :developer]
|
||||
end
|
||||
|
||||
[:all, :running, :branches].each do |scope|
|
||||
context "when displaying #{scope}" do
|
||||
describe 'GET /:project/pipelines' do
|
||||
let(:project) { create(:project) }
|
||||
|
||||
let!(:pipeline) do
|
||||
create(
|
||||
:ci_empty_pipeline,
|
||||
project: project,
|
||||
ref: 'master',
|
||||
status: 'running',
|
||||
sha: project.commit.id,
|
||||
)
|
||||
end
|
||||
|
||||
[:all, :running, :branches].each do |scope|
|
||||
context "when displaying #{scope}" do
|
||||
before do
|
||||
visit_project_pipelines(scope: scope)
|
||||
end
|
||||
|
||||
it 'contains pipeline commit short SHA' do
|
||||
expect(page).to have_content(pipeline.short_sha)
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
context 'when pipeline is cancelable' do
|
||||
let!(:build) do
|
||||
create(:ci_build, pipeline: pipeline,
|
||||
stage: 'test',
|
||||
commands: 'test')
|
||||
end
|
||||
|
||||
before do
|
||||
visit_project_pipelines(scope: scope)
|
||||
build.run
|
||||
visit_project_pipelines
|
||||
end
|
||||
|
||||
it 'contains pipeline commit short SHA' do
|
||||
expect(page).to have_content(pipeline.short_sha)
|
||||
end
|
||||
end
|
||||
end
|
||||
it { expect(page).to have_link('Cancel') }
|
||||
|
||||
context 'anonymous access' do
|
||||
let(:project) { create(:project, :public) }
|
||||
|
||||
before do
|
||||
logout
|
||||
visit_project_pipelines
|
||||
end
|
||||
|
||||
it { expect(page).to have_http_status(:success) }
|
||||
end
|
||||
|
||||
context 'when pipeline is cancelable' do
|
||||
let!(:build) do
|
||||
create(:ci_build, pipeline: pipeline,
|
||||
stage: 'test',
|
||||
commands: 'test')
|
||||
end
|
||||
|
||||
before do
|
||||
build.run
|
||||
visit_project_pipelines
|
||||
end
|
||||
|
||||
it { expect(page).to have_link('Cancel') }
|
||||
|
||||
it { expect(page).to have_selector('.ci-running') }
|
||||
|
||||
context 'when canceling' do
|
||||
before { click_link('Cancel') }
|
||||
|
||||
it { expect(page).not_to have_link('Cancel') }
|
||||
it { expect(page).to have_selector('.ci-canceled') }
|
||||
end
|
||||
end
|
||||
|
||||
context 'when pipeline is retryable' do
|
||||
let!(:build) do
|
||||
create(:ci_build, pipeline: pipeline,
|
||||
stage: 'test',
|
||||
commands: 'test')
|
||||
end
|
||||
|
||||
before do
|
||||
build.drop
|
||||
visit_project_pipelines
|
||||
end
|
||||
|
||||
it { expect(page).to have_link('Retry') }
|
||||
it { expect(page).to have_selector('.ci-failed') }
|
||||
|
||||
context 'when retrying' do
|
||||
before { click_link('Retry') }
|
||||
|
||||
it { expect(page).not_to have_link('Retry') }
|
||||
it { expect(page).to have_selector('.ci-running') }
|
||||
end
|
||||
end
|
||||
|
||||
context 'with manual actions' do
|
||||
let!(:manual) do
|
||||
create(:ci_build, :manual,
|
||||
pipeline: pipeline,
|
||||
name: 'manual build',
|
||||
stage: 'test',
|
||||
commands: 'test')
|
||||
end
|
||||
|
||||
before { visit_project_pipelines }
|
||||
|
||||
it 'has a dropdown with play button' do
|
||||
expect(page).to have_selector('.dropdown-toggle.btn.btn-default .icon-play')
|
||||
end
|
||||
|
||||
it 'has link to the manual action' do
|
||||
find('.js-pipeline-dropdown-manual-actions').click
|
||||
|
||||
expect(page).to have_link('Manual build')
|
||||
end
|
||||
|
||||
context 'when manual action was played' do
|
||||
before do
|
||||
find('.js-pipeline-dropdown-manual-actions').click
|
||||
click_link('Manual build')
|
||||
end
|
||||
|
||||
it 'enqueues manual action job' do
|
||||
expect(manual.reload).to be_pending
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
context 'for generic statuses' do
|
||||
context 'when running' do
|
||||
let!(:running) do
|
||||
create(:generic_commit_status,
|
||||
status: 'running',
|
||||
pipeline: pipeline,
|
||||
stage: 'test'
|
||||
)
|
||||
end
|
||||
|
||||
before { visit_project_pipelines }
|
||||
|
||||
it 'is cancelable' do
|
||||
expect(page).to have_link('Cancel')
|
||||
end
|
||||
|
||||
it 'has pipeline running' do
|
||||
expect(page).to have_selector('.ci-running')
|
||||
end
|
||||
|
||||
context 'when canceling' do
|
||||
before { click_link('Cancel') }
|
||||
|
@ -158,162 +65,266 @@ describe 'Pipelines', :feature, :js do
|
|||
end
|
||||
end
|
||||
|
||||
context 'when failed' do
|
||||
let!(:status) do
|
||||
create(:generic_commit_status, :pending,
|
||||
pipeline: pipeline,
|
||||
stage: 'test')
|
||||
context 'when pipeline is retryable' do
|
||||
let!(:build) do
|
||||
create(:ci_build, pipeline: pipeline,
|
||||
stage: 'test',
|
||||
commands: 'test')
|
||||
end
|
||||
|
||||
before do
|
||||
status.drop
|
||||
build.drop
|
||||
visit_project_pipelines
|
||||
end
|
||||
|
||||
it 'is not retryable' do
|
||||
expect(page).not_to have_link('Retry')
|
||||
end
|
||||
it { expect(page).to have_link('Retry') }
|
||||
it { expect(page).to have_selector('.ci-failed') }
|
||||
|
||||
it 'has failed pipeline' do
|
||||
expect(page).to have_selector('.ci-failed')
|
||||
context 'when retrying' do
|
||||
before { click_link('Retry') }
|
||||
|
||||
it { expect(page).not_to have_link('Retry') }
|
||||
it { expect(page).to have_selector('.ci-running') }
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
context 'downloadable pipelines' do
|
||||
context 'with artifacts' do
|
||||
let!(:with_artifacts) do
|
||||
create(:ci_build, :artifacts, :success,
|
||||
context 'with manual actions' do
|
||||
let!(:manual) do
|
||||
create(:ci_build, :manual,
|
||||
pipeline: pipeline,
|
||||
name: 'rspec tests',
|
||||
stage: 'test')
|
||||
name: 'manual build',
|
||||
stage: 'test',
|
||||
commands: 'test')
|
||||
end
|
||||
|
||||
before { visit_project_pipelines }
|
||||
|
||||
it 'has artifats' do
|
||||
expect(page).to have_selector('.build-artifacts')
|
||||
it 'has a dropdown with play button' do
|
||||
expect(page).to have_selector('.dropdown-toggle.btn.btn-default .icon-play')
|
||||
end
|
||||
|
||||
it 'has artifacts download dropdown' do
|
||||
find('.js-pipeline-dropdown-download').click
|
||||
it 'has link to the manual action' do
|
||||
find('.js-pipeline-dropdown-manual-actions').click
|
||||
|
||||
expect(page).to have_link(with_artifacts.name)
|
||||
expect(page).to have_link('Manual build')
|
||||
end
|
||||
|
||||
context 'when manual action was played' do
|
||||
before do
|
||||
find('.js-pipeline-dropdown-manual-actions').click
|
||||
click_link('Manual build')
|
||||
end
|
||||
|
||||
it 'enqueues manual action job' do
|
||||
expect(manual.reload).to be_pending
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
context 'with artifacts expired' do
|
||||
let!(:with_artifacts_expired) do
|
||||
create(:ci_build, :artifacts_expired, :success,
|
||||
pipeline: pipeline,
|
||||
name: 'rspec',
|
||||
stage: 'test')
|
||||
context 'for generic statuses' do
|
||||
context 'when running' do
|
||||
let!(:running) do
|
||||
create(:generic_commit_status,
|
||||
status: 'running',
|
||||
pipeline: pipeline,
|
||||
stage: 'test'
|
||||
)
|
||||
end
|
||||
|
||||
before { visit_project_pipelines }
|
||||
|
||||
it 'is cancelable' do
|
||||
expect(page).to have_link('Cancel')
|
||||
end
|
||||
|
||||
it 'has pipeline running' do
|
||||
expect(page).to have_selector('.ci-running')
|
||||
end
|
||||
|
||||
context 'when canceling' do
|
||||
before { click_link('Cancel') }
|
||||
|
||||
it { expect(page).not_to have_link('Cancel') }
|
||||
it { expect(page).to have_selector('.ci-canceled') }
|
||||
end
|
||||
end
|
||||
|
||||
context 'when failed' do
|
||||
let!(:status) do
|
||||
create(:generic_commit_status, :pending,
|
||||
pipeline: pipeline,
|
||||
stage: 'test')
|
||||
end
|
||||
|
||||
before do
|
||||
status.drop
|
||||
visit_project_pipelines
|
||||
end
|
||||
|
||||
it 'is not retryable' do
|
||||
expect(page).not_to have_link('Retry')
|
||||
end
|
||||
|
||||
it 'has failed pipeline' do
|
||||
expect(page).to have_selector('.ci-failed')
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
context 'downloadable pipelines' do
|
||||
context 'with artifacts' do
|
||||
let!(:with_artifacts) do
|
||||
create(:ci_build, :artifacts, :success,
|
||||
pipeline: pipeline,
|
||||
name: 'rspec tests',
|
||||
stage: 'test')
|
||||
end
|
||||
|
||||
before { visit_project_pipelines }
|
||||
|
||||
it 'has artifats' do
|
||||
expect(page).to have_selector('.build-artifacts')
|
||||
end
|
||||
|
||||
it 'has artifacts download dropdown' do
|
||||
find('.js-pipeline-dropdown-download').click
|
||||
|
||||
expect(page).to have_link(with_artifacts.name)
|
||||
end
|
||||
end
|
||||
|
||||
context 'with artifacts expired' do
|
||||
let!(:with_artifacts_expired) do
|
||||
create(:ci_build, :artifacts_expired, :success,
|
||||
pipeline: pipeline,
|
||||
name: 'rspec',
|
||||
stage: 'test')
|
||||
end
|
||||
|
||||
before { visit_project_pipelines }
|
||||
|
||||
it { expect(page).not_to have_selector('.build-artifacts') }
|
||||
end
|
||||
|
||||
context 'without artifacts' do
|
||||
let!(:without_artifacts) do
|
||||
create(:ci_build, :success,
|
||||
pipeline: pipeline,
|
||||
name: 'rspec',
|
||||
stage: 'test')
|
||||
end
|
||||
|
||||
before { visit_project_pipelines }
|
||||
|
||||
it { expect(page).not_to have_selector('.build-artifacts') }
|
||||
end
|
||||
end
|
||||
|
||||
context 'mini pipleine graph' do
|
||||
let!(:build) do
|
||||
create(:ci_build, pipeline: pipeline,
|
||||
stage: 'build',
|
||||
name: 'build')
|
||||
end
|
||||
|
||||
before { visit_project_pipelines }
|
||||
|
||||
it { expect(page).not_to have_selector('.build-artifacts') }
|
||||
end
|
||||
context 'when clicking a graph stage' do
|
||||
it 'should open a dropdown' do
|
||||
find('.js-builds-dropdown-button').trigger('click')
|
||||
|
||||
context 'without artifacts' do
|
||||
let!(:without_artifacts) do
|
||||
create(:ci_build, :success,
|
||||
pipeline: pipeline,
|
||||
name: 'rspec',
|
||||
stage: 'test')
|
||||
end
|
||||
expect(page).to have_link build.name
|
||||
end
|
||||
|
||||
before { visit_project_pipelines }
|
||||
it 'should be possible to retry the failed build' do
|
||||
find('.js-builds-dropdown-button').trigger('click')
|
||||
|
||||
it { expect(page).not_to have_selector('.build-artifacts') }
|
||||
end
|
||||
end
|
||||
|
||||
context 'mini pipleine graph' do
|
||||
let!(:build) do
|
||||
create(:ci_build, pipeline: pipeline,
|
||||
stage: 'build',
|
||||
name: 'build')
|
||||
end
|
||||
|
||||
before { visit_project_pipelines }
|
||||
|
||||
context 'when clicking a graph stage' do
|
||||
it 'should open a dropdown' do
|
||||
find('.js-builds-dropdown-button').trigger('click')
|
||||
|
||||
expect(page).to have_link build.name
|
||||
end
|
||||
|
||||
it 'should be possible to retry the failed build' do
|
||||
find('.js-builds-dropdown-button').trigger('click')
|
||||
|
||||
find('a.ci-action-icon-container').trigger('click')
|
||||
expect(page).not_to have_content('Cancel running')
|
||||
find('a.ci-action-icon-container').trigger('click')
|
||||
expect(page).not_to have_content('Cancel running')
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
describe 'POST /:project/pipelines' do
|
||||
let(:project) { create(:project) }
|
||||
describe 'POST /:project/pipelines' do
|
||||
let(:project) { create(:project) }
|
||||
|
||||
before do
|
||||
visit new_namespace_project_pipeline_path(project.namespace, project)
|
||||
end
|
||||
|
||||
context 'for valid commit' do
|
||||
before { fill_in('pipeline[ref]', with: 'master') }
|
||||
|
||||
context 'with gitlab-ci.yml' do
|
||||
before { stub_ci_pipeline_to_return_yaml_file }
|
||||
|
||||
it 'creates a new pipeline' do
|
||||
expect { click_on 'Create pipeline' }
|
||||
.to change { Ci::Pipeline.count }.by(1)
|
||||
end
|
||||
end
|
||||
|
||||
context 'without gitlab-ci.yml' do
|
||||
before { click_on 'Create pipeline' }
|
||||
|
||||
it { expect(page).to have_content('Missing .gitlab-ci.yml file') }
|
||||
end
|
||||
end
|
||||
|
||||
context 'for invalid commit' do
|
||||
before do
|
||||
fill_in('pipeline[ref]', with: 'invalid-reference')
|
||||
click_on 'Create pipeline'
|
||||
visit new_namespace_project_pipeline_path(project.namespace, project)
|
||||
end
|
||||
|
||||
it { expect(page).to have_content('Reference not found') }
|
||||
context 'for valid commit' do
|
||||
before { fill_in('pipeline[ref]', with: 'master') }
|
||||
|
||||
context 'with gitlab-ci.yml' do
|
||||
before { stub_ci_pipeline_to_return_yaml_file }
|
||||
|
||||
it 'creates a new pipeline' do
|
||||
expect { click_on 'Create pipeline' }
|
||||
.to change { Ci::Pipeline.count }.by(1)
|
||||
end
|
||||
end
|
||||
|
||||
context 'without gitlab-ci.yml' do
|
||||
before { click_on 'Create pipeline' }
|
||||
|
||||
it { expect(page).to have_content('Missing .gitlab-ci.yml file') }
|
||||
end
|
||||
end
|
||||
|
||||
context 'for invalid commit' do
|
||||
before do
|
||||
fill_in('pipeline[ref]', with: 'invalid-reference')
|
||||
click_on 'Create pipeline'
|
||||
end
|
||||
|
||||
it { expect(page).to have_content('Reference not found') }
|
||||
end
|
||||
end
|
||||
|
||||
describe 'Create pipelines' do
|
||||
let(:project) { create(:project) }
|
||||
|
||||
before do
|
||||
visit new_namespace_project_pipeline_path(project.namespace, project)
|
||||
end
|
||||
|
||||
describe 'new pipeline page' do
|
||||
it 'has field to add a new pipeline' do
|
||||
expect(page).to have_field('pipeline[ref]')
|
||||
expect(page).to have_content('Create for')
|
||||
end
|
||||
end
|
||||
|
||||
describe 'find pipelines' do
|
||||
it 'shows filtered pipelines', js: true do
|
||||
fill_in('pipeline[ref]', with: 'fix')
|
||||
find('input#ref').native.send_keys(:keydown)
|
||||
|
||||
within('.ui-autocomplete') do
|
||||
expect(page).to have_selector('li', text: 'fix')
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
describe 'Create pipelines' do
|
||||
let(:project) { create(:project) }
|
||||
|
||||
context 'when user is not logged in' do
|
||||
before do
|
||||
visit new_namespace_project_pipeline_path(project.namespace, project)
|
||||
visit namespace_project_pipelines_path(project.namespace, project)
|
||||
end
|
||||
|
||||
describe 'new pipeline page' do
|
||||
it 'has field to add a new pipeline' do
|
||||
expect(page).to have_field('pipeline[ref]')
|
||||
expect(page).to have_content('Create for')
|
||||
end
|
||||
context 'when project is public' do
|
||||
let(:project) { create(:project, :public) }
|
||||
|
||||
it { expect(page).to have_content 'No pipelines to show' }
|
||||
it { expect(page).to have_http_status(:success) }
|
||||
end
|
||||
|
||||
describe 'find pipelines' do
|
||||
it 'shows filtered pipelines', js: true do
|
||||
fill_in('pipeline[ref]', with: 'fix')
|
||||
find('input#ref').native.send_keys(:keydown)
|
||||
context 'when project is private' do
|
||||
let(:project) { create(:project, :private) }
|
||||
|
||||
within('.ui-autocomplete') do
|
||||
expect(page).to have_selector('li', text: 'fix')
|
||||
end
|
||||
end
|
||||
it { expect(page).to have_content 'You need to sign in' }
|
||||
end
|
||||
end
|
||||
|
||||
|
|
Loading…
Reference in a new issue