From e99d2e196cd87ed071f856f80ae085c7be640876 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Fri, 30 Sep 2022 12:08:43 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- Gemfile | 2 +- Gemfile.checksum | 2 +- Gemfile.lock | 4 +- app/assets/javascripts/api/user_api.js | 4 +- app/assets/javascripts/awards_handler.js | 4 +- .../badges/components/badge_form.vue | 14 +- .../badges/components/badge_settings.vue | 8 +- .../stores/modules/batch_comments/actions.js | 12 +- .../javascripts/behaviors/preview_markdown.js | 4 +- .../blob/file_template_mediator.js | 4 +- app/assets/javascripts/blob/openapi/index.js | 4 +- app/assets/javascripts/blob/viewer/index.js | 6 +- .../javascripts/blob_edit/blob_bundle.js | 4 +- app/assets/javascripts/blob_edit/edit_blob.js | 6 +- .../components/new_deploy_token.vue | 332 ++++++++++++++++++ app/assets/javascripts/deploy_tokens/index.js | 33 ++ .../notes/components/discussion_counter.vue | 7 +- .../project/components/cleanup_image_tags.vue | 7 +- .../container_expiration_policy.vue | 2 +- .../pages/groups/settings/ci_cd/show/index.js | 2 + .../pages/groups/settings/index.js | 2 + .../projects/settings/ci_cd/show/index.js | 2 + .../pages/projects/settings/index.js | 2 + .../components/extensions/base.vue | 1 - .../components/state_container.vue | 4 +- app/views/ci/variables/_index.html.haml | 8 +- ...close_reopen_draft_report_toggle.html.haml | 3 +- .../shared/deploy_tokens/_index.html.haml | 20 +- ..._simplify_find_local_branches_response.yml | 8 - config/initializers/sawyer_patch.rb | 10 + doc/administration/auth/cognito.md | 51 +-- doc/user/profile/index.md | 4 +- .../filter/pathological_markdown_filter.rb | 27 -- .../pipeline/plain_markdown_pipeline.rb | 1 - lib/gitlab/gitaly_client/ref_service.rb | 8 +- lib/gitlab/github_import/client.rb | 6 +- .../importer/protected_branches_importer.rb | 6 +- .../pull_requests_reviews_importer.rb | 2 + .../github_import/parallel_scheduling.rb | 2 + .../github_import/representation/diff_note.rb | 2 +- .../github_import/representation/issue.rb | 2 +- .../representation/issue_event.rb | 2 +- .../github_import/representation/note.rb | 2 +- .../representation/protected_branch.rb | 6 +- .../representation/pull_request.rb | 2 +- .../representation/pull_request_review.rb | 2 +- .../github_import/representation/user.rb | 2 +- lib/gitlab/github_import/user_finder.rb | 4 +- locale/gitlab.pot | 29 +- .../groups/settings/repository_spec.rb | 34 +- .../close_reopen_report_toggle_spec.rb | 10 +- .../merge_request_discussion_lock_spec.rb | 4 +- .../user_manages_subscription_spec.rb | 2 +- .../user_marks_merge_request_as_draft_spec.rb | 4 +- .../settings/repository_settings_spec.rb | 2 +- .../components/new_deploy_token_spec.js | 103 ++++++ .../components/cleanup_image_tags_spec.js | 32 +- .../container_expiration_policy_spec.js | 37 +- .../settings/project/settings/mock_data.js | 9 + spec/initializers/sawyer_patch_spec.rb | 24 +- .../pathological_markdown_filter_spec.rb | 27 -- .../lib/banzai/pipeline/full_pipeline_spec.rb | 14 +- .../external_database_checker_spec.rb | 2 +- .../gitlab/gitaly_client/ref_service_spec.rb | 32 +- spec/lib/gitlab/github_import/client_spec.rb | 16 + .../github_import/parallel_scheduling_spec.rb | 2 +- .../features/deploy_token_shared_examples.rb | 24 +- workhorse/go.mod | 2 +- workhorse/go.sum | 3 +- 69 files changed, 824 insertions(+), 240 deletions(-) create mode 100644 app/assets/javascripts/deploy_tokens/components/new_deploy_token.vue create mode 100644 app/assets/javascripts/deploy_tokens/index.js delete mode 100644 config/feature_flags/undefined/gitaly_simplify_find_local_branches_response.yml delete mode 100644 lib/banzai/filter/pathological_markdown_filter.rb create mode 100644 spec/frontend/deploy_tokens/components/new_deploy_token_spec.js delete mode 100644 spec/lib/banzai/filter/pathological_markdown_filter_spec.rb diff --git a/Gemfile b/Gemfile index a7e79f26b3e..f1e3960b637 100644 --- a/Gemfile +++ b/Gemfile @@ -165,7 +165,7 @@ gem 'html-pipeline', '~> 2.13.2' gem 'deckar01-task_list', '2.3.1' gem 'gitlab-markup', '~> 1.8.0' gem 'github-markup', '~> 1.7.0', require: 'github/markup' -gem 'commonmarker', '~> 0.23.4' +gem 'commonmarker', '~> 0.23.6' gem 'kramdown', '~> 2.3.1' gem 'RedCloth', '~> 4.3.2' gem 'rdoc', '~> 6.3.2' diff --git a/Gemfile.checksum b/Gemfile.checksum index 89864b6a182..66bc388c922 100644 --- a/Gemfile.checksum +++ b/Gemfile.checksum @@ -79,7 +79,7 @@ {"name":"claide-plugins","version":"0.9.2","platform":"ruby","checksum":"c7ea78bc067ab23bce8515497cdcdcb8f01c86dadfbe13c44644e382922c1c2e"}, {"name":"coderay","version":"1.1.3","platform":"ruby","checksum":"dc530018a4684512f8f38143cd2a096c9f02a1fc2459edcfe534787a7fc77d4b"}, {"name":"colored2","version":"3.1.2","platform":"ruby","checksum":"b13c2bd7eeae2cf7356a62501d398e72fde78780bd26aec6a979578293c28b4a"}, -{"name":"commonmarker","version":"0.23.4","platform":"ruby","checksum":"95d9cb050576376374a66d71a4feab3562e0955aab9d80a3e8606a5cf5e9c7ce"}, +{"name":"commonmarker","version":"0.23.6","platform":"ruby","checksum":"c8aeaaaff4ba497bf180f762db63a0069794fafb6eff221224c9c8199d337b38"}, {"name":"concurrent-ruby","version":"1.1.10","platform":"ruby","checksum":"244cb1ca0d91ec2c15ca2209507c39fb163336994428e16fbd3f465c87bd8e68"}, {"name":"connection_pool","version":"2.2.5","platform":"ruby","checksum":"13a8fc3921ce4df8e04fb65f1037251decb08d74757b41163688bd1c1feccd39"}, {"name":"contracts","version":"0.11.0","platform":"ruby","checksum":"df6e438efa89c31dd3095851c3f7a25dfdae36b35ff1d4547f1d92941b3c7286"}, diff --git a/Gemfile.lock b/Gemfile.lock index 0b4e32e6257..355cffc292d 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -282,7 +282,7 @@ GEM open4 (~> 1.3) coderay (1.1.3) colored2 (3.1.2) - commonmarker (0.23.4) + commonmarker (0.23.6) concurrent-ruby (1.1.10) connection_pool (2.2.5) contracts (0.11.0) @@ -1557,7 +1557,7 @@ DEPENDENCIES capybara-screenshot (~> 1.0.22) carrierwave (~> 1.3) charlock_holmes (~> 0.7.7) - commonmarker (~> 0.23.4) + commonmarker (~> 0.23.6) concurrent-ruby (~> 1.1) connection_pool (~> 2.0) countries (~> 3.0) diff --git a/app/assets/javascripts/api/user_api.js b/app/assets/javascripts/api/user_api.js index c743b18d572..369abe95d49 100644 --- a/app/assets/javascripts/api/user_api.js +++ b/app/assets/javascripts/api/user_api.js @@ -1,5 +1,5 @@ import { DEFAULT_PER_PAGE } from '~/api'; -import createFlash from '~/flash'; +import { createAlert } from '~/flash'; import { __ } from '~/locale'; import axios from '../lib/utils/axios_utils'; import { buildApiUrl } from './api_utils'; @@ -55,7 +55,7 @@ export function getUserProjects(userId, query, options, callback) { }) .then(({ data }) => callback(data)) .catch(() => - createFlash({ + createAlert({ message: __('Something went wrong while fetching projects'), }), ); diff --git a/app/assets/javascripts/awards_handler.js b/app/assets/javascripts/awards_handler.js index a3ffb4df7b7..9ab1d6bfd80 100644 --- a/app/assets/javascripts/awards_handler.js +++ b/app/assets/javascripts/awards_handler.js @@ -7,7 +7,7 @@ import { getEmojiScoreWithIntent } from '~/emoji/utils'; import { getCookie, setCookie, scrollToElement } from '~/lib/utils/common_utils'; import * as Emoji from '~/emoji'; import { dispose, fixTitle } from '~/tooltips'; -import createFlash from './flash'; +import { createAlert } from '~/flash'; import axios from './lib/utils/axios_utils'; import { isInVueNoteablePage } from './lib/utils/dom_utils'; import { __ } from './locale'; @@ -491,7 +491,7 @@ export class AwardsHandler { } }) .catch(() => - createFlash({ + createAlert({ message: __('Something went wrong on our end.'), }), ); diff --git a/app/assets/javascripts/badges/components/badge_form.vue b/app/assets/javascripts/badges/components/badge_form.vue index d1570e16639..f68666f8a0c 100644 --- a/app/assets/javascripts/badges/components/badge_form.vue +++ b/app/assets/javascripts/badges/components/badge_form.vue @@ -2,7 +2,7 @@ import { GlLoadingIcon, GlFormInput, GlFormGroup, GlButton, GlSafeHtmlDirective } from '@gitlab/ui'; import { escape, debounce } from 'lodash'; import { mapActions, mapState } from 'vuex'; -import createFlash from '~/flash'; +import { createAlert, VARIANT_INFO } from '~/flash'; import { s__, sprintf } from '~/locale'; import createEmptyBadge from '../empty_badge'; import Badge from './badge.vue'; @@ -136,14 +136,14 @@ export default { if (this.isEditing) { return this.saveBadge() .then(() => { - createFlash({ + createAlert({ message: s__('Badges|Badge saved.'), - type: 'notice', + variant: VARIANT_INFO, }); this.wasValidated = false; }) .catch((error) => { - createFlash({ + createAlert({ message: s__( 'Badges|Saving the badge failed, please check the entered URLs and try again.', ), @@ -154,14 +154,14 @@ export default { return this.addBadge() .then(() => { - createFlash({ + createAlert({ message: s__('Badges|New badge added.'), - type: 'notice', + variant: VARIANT_INFO, }); this.wasValidated = false; }) .catch((error) => { - createFlash({ + createAlert({ message: s__( 'Badges|Adding the badge failed, please check the entered URLs and try again.', ), diff --git a/app/assets/javascripts/badges/components/badge_settings.vue b/app/assets/javascripts/badges/components/badge_settings.vue index 0303930de5d..a7a21d65475 100644 --- a/app/assets/javascripts/badges/components/badge_settings.vue +++ b/app/assets/javascripts/badges/components/badge_settings.vue @@ -1,7 +1,7 @@ + diff --git a/app/assets/javascripts/deploy_tokens/index.js b/app/assets/javascripts/deploy_tokens/index.js new file mode 100644 index 00000000000..334c9930f4b --- /dev/null +++ b/app/assets/javascripts/deploy_tokens/index.js @@ -0,0 +1,33 @@ +import Vue from 'vue'; +import NewDeployToken from './components/new_deploy_token.vue'; + +export default function initDeployTokens() { + const el = document.getElementById('js-new-deploy-token'); + + if (el == null) return null; + + const { + createNewTokenPath, + deployTokensHelpUrl, + containerRegistryEnabled, + packagesRegistryEnabled, + tokenType, + } = el.dataset; + return new Vue({ + el, + components: { + NewDeployToken, + }, + render(createElement) { + return createElement(NewDeployToken, { + props: { + createNewTokenPath, + deployTokensHelpUrl, + containerRegistryEnabled: containerRegistryEnabled !== undefined, + packagesRegistryEnabled: packagesRegistryEnabled !== undefined, + tokenType, + }, + }); + }, + }); +} diff --git a/app/assets/javascripts/notes/components/discussion_counter.vue b/app/assets/javascripts/notes/components/discussion_counter.vue index 6521b86edbb..37935e9c3c6 100644 --- a/app/assets/javascripts/notes/components/discussion_counter.vue +++ b/app/assets/javascripts/notes/components/discussion_counter.vue @@ -81,16 +81,18 @@ export default { :class="{ 'gl-bg-orange-50': blocksMerge && !allResolved, 'gl-bg-gray-50': !blocksMerge || allResolved, - 'gl-pr-2': !allResolved, }" data-testid="discussions-counter-text" >