kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Fix a "can't modify frozen Hash" error in lib/api/services.rb in development env

Browse source 
Signed-off-by: Rémy Coutable <remy@rymai.me>
This commit is contained in:
Rémy Coutable 2018-02-27 17:04:34 +01:00
parent 7d12f3a84e
commit ea32e1c41f
No known key found for this signature in database
GPG key ID: 46DF07E5CD9E96AB
1 changed files with 11 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
lib/api/services.rb
View file

@ -139,7 +139,7 @@ module API
} }
].freeze ].freeze
SERVICES = { services = {
'asana' => [ 'asana' => [
{ {
required: true, required: true,
@ -673,9 +673,9 @@ module API
desc: 'The password of the user' desc: 'The password of the user'
} }
] ]
}.freeze }
SERVICE_CLASSES = [ service_classes = [
AsanaService, AsanaService,
AssemblaService, AssemblaService,
BambooService, BambooService,
@ -704,10 +704,10 @@ module API
MattermostService, MattermostService,
MicrosoftTeamsService, MicrosoftTeamsService,
TeamcityService TeamcityService
].freeze ]
if Rails.env.development? if Rails.env.development?
SERVICES['mock-ci'] = [ services['mock-ci'] = [
{ {
required: true, required: true,
name: :mock_service_url, name: :mock_service_url,
@ -715,16 +715,19 @@ module API
desc: 'URL to the mock service' desc: 'URL to the mock service'
} }
] ]
SERVICES['mock-deployment'] = [] services['mock-deployment'] = []
SERVICES['mock-monitoring'] = [] services['mock-monitoring'] = []
SERVICE_CLASSES += [ service_classes += [
MockCiService, MockCiService,
MockDeploymentService, MockDeploymentService,
MockMonitoringService MockMonitoringService
] ]
end end
SERVICES = services.freeze
SERVICE_CLASSES = service_classes.freeze
SERVICE_CLASSES.each do |service| SERVICE_CLASSES.each do |service|
event_names = service.try(:event_names) || next event_names = service.try(:event_names) || next
event_names.each do |event_name| event_names.each do |event_name|