Explain why we use select all for project_url_constrainer.rb

2017-08-09 12:41:20 +00:00 · 2017-08-09 12:41:20 +00:00 · ec2d6b495b
commit ec2d6b495b
parent 22c02bc22a
1 changed files with 2 additions and 0 deletions
--- a/lib/constraints/project_url_constrainer.rb
+++ b/lib/constraints/project_url_constrainer.rb
@ -6,6 +6,8 @@ class ProjectUrlConstrainer

    return false unless DynamicPathValidator.valid_project_path?(full_path)

+    # We intentionally allow SELECT(*) here so result of this query can be used
+    # as cache for further Project.find_by_full_path calls within request 
    Project.find_by_full_path(full_path, follow_redirects: request.get?).present?
  end
 end