kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Merge branch 'winh-remove-convertPermissionToBoolean' into 'master' 

Remove convertPermissionToBoolean() from common_utils.js

See merge request gitlab-org/gitlab-ce!25454
This commit is contained in:
Clement Ho 2019-02-25 01:17:25 +00:00
parent a2d7dcae38 532d43d52c
commit ecaa08cc28
2 changed files with 0 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
app/assets/javascripts/lib/utils/common_utils.js
View File

@ -455,21 +455,6 @@ export const historyPushState = newUrl => {
*/
export const parseBoolean = value => (value && value.toString()) === 'true';
/**
* Converts permission provided as strings to booleans.
*
* @param {String} string
* @returns {Boolean}
*/
export const convertPermissionToBoolean = permission => {
if (process.env.NODE_ENV !== 'production') {
// eslint-disable-next-line no-console
console.warn('convertPermissionToBoolean is deprecated! Please use parseBoolean instead.');
}
return parseBoolean(permission);
};
/**
* @callback backOffCallback
* @param {Function} next

7
spec/javascripts/lib/utils/common_utils_spec.js
View File

@ -409,13 +409,6 @@ describe('common_utils', () => {
});
});
describe('convertPermissionToBoolean', () => {
it('should convert a boolean in a string to a boolean', () => {
expect(commonUtils.convertPermissionToBoolean('true')).toEqual(true);
expect(commonUtils.convertPermissionToBoolean('false')).toEqual(false);
});
});
describe('backOff', () => {
beforeEach(() => {
// shortcut our timeouts otherwise these tests will take a long time to finish