From ecac2f1122f093455e7b9e5d054157241dcd5cff Mon Sep 17 00:00:00 2001 From: Lin Jen-Shin Date: Wed, 4 Jan 2017 22:50:01 +0800 Subject: [PATCH] Update the comment: Feedback: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7237#note_20876648 --- app/services/git_operation_service.rb | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/app/services/git_operation_service.rb b/app/services/git_operation_service.rb index 5acfdb0f9e2..f36c0b082e4 100644 --- a/app/services/git_operation_service.rb +++ b/app/services/git_operation_service.rb @@ -26,10 +26,12 @@ class GitOperationService oldrev = Gitlab::Git::BLANK_SHA with_hooks(ref, newrev, oldrev) do |service| + # We want to pass the OID of the tag object to the hooks. For an + # annotated tag we don't know that OID until after the tag object + # (raw_tag) is created in the repository. That is why we have to + # update the value after creating the tag object. Only the + # "post-receive" hook will receive the correct value in this case. raw_tag = repository.rugged.tags.create(tag_name, newrev, options) - - # If raw_tag is an annotated tag, we'll need to update newrev to point - # to the new revision. service.newrev = raw_tag.target_id end end