Improve readability of runner tick queue method

2017-01-20 14:16:13 +01:00 · 2017-01-20 14:16:13 +01:00 · ecb9f978eb
parent 10678525b0
commit ecb9f978eb
1 changed files with 5 additions and 3 deletions
--- a/app/models/ci/runner.rb
+++ b/app/models/ci/runner.rb
@ -126,9 +126,11 @@ module Ci
    end

    def tick_runner_queue
-      new_update = SecureRandom.hex
-      Gitlab::Redis.with { |redis| redis.set(runner_queue_key, new_update, ex: RUNNER_QUEUE_EXPIRY_TIME) }
-      new_update
+      SecureRandom.hex.tap do |new_update|
+        Gitlab::Redis.with do |redis|
+          redis.set(runner_queue_key, new_update, ex: RUNNER_QUEUE_EXPIRY_TIME)
+        end
+      end
    end

    def ensure_runner_queue_value