Process skipped jobs in the pipeline when retrying it

app/services/ci/retry_pipeline_service.rb

@@ -1,22 +1,21 @@
 module Ci
   class RetryPipelineService < ::BaseService
+    include Gitlab::OptimisticLocking
+
     def execute(pipeline)
       unless can?(current_user, :update_pipeline, pipeline)
         raise Gitlab::Access::AccessDeniedError
       end
 
-      pipeline.builds.failed_or_canceled.tap do |builds|
+      pipeline.builds.failed_or_canceled.find_each do |build|
-        stage_idx = builds.order('stage_idx ASC')
+        next unless build.retryable?
-          .pluck('DISTINCT stage_idx').first
 
-        pipeline.mark_as_processable_after_stage(stage_idx)
+        Ci::RetryBuildService.new(project, current_user)
+          .reprocess(build)
+      end
 
-        builds.find_each do |build|
+      pipeline.builds.skipped.find_each do |skipped|
-          next unless build.retryable?
+        retry_optimistic_lock(skipped) { |build| build.process }
-
-          Ci::RetryBuildService.new(project, current_user)
-            .reprocess(build)
-        end
       end
 
       MergeRequests::AddTodoWhenBuildFailsService

lib/gitlab/optimistic_locking.rb

@@ -1,6 +1,6 @@
 module Gitlab
   module OptimisticLocking
-    extend self
+    module_function
 
     def retry_lock(subject, retries = 100, &block)
       loop do
@@ -15,5 +15,7 @@ module Gitlab
         end
       end
     end
+
+    alias :retry_optimistic_lock :retry_lock
   end
 end