Merge branch 'enable-frozen-string-lib-gitlab' into 'master'

Enable some frozen string in lib/gitlab

See merge request gitlab-org/gitlab-ce!22304

changelogs/unreleased/enable-frozen-string-lib-gitlab.yml

@@ -0,0 +1,5 @@
+---
+title: Enable some frozen string in lib/gitlab
+merge_request:
+author: gfyoung
+type: performance

lib/gitlab/auth/activity.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Auth
     ##

lib/gitlab/auth/database/authentication.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # These calls help to authenticate to OAuth provider by providing username and password
 #
 

lib/gitlab/auth/ip_rate_limiter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Auth
     class IpRateLimiter

lib/gitlab/auth/ldap/access.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # LDAP authorization model
 #
 # * Check if we are allowed access (not blocked)

lib/gitlab/auth/ldap/adapter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Auth
     module LDAP

lib/gitlab/auth/ldap/auth_hash.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Class to parse and transform the info provided by omniauth
 #
 module Gitlab

lib/gitlab/auth/ldap/authentication.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # These calls help to authenticate to LDAP by providing username and password
 #
 # Since multiple LDAP servers are supported, it will loop through all of them

lib/gitlab/auth/ldap/config.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Load a specific server configuration
 module Gitlab
   module Auth

lib/gitlab/auth/ldap/dn.rb

@@ -1,4 +1,5 @@
 # -*- ruby encoding: utf-8 -*-
+# frozen_string_literal: true
 
 # Based on the `ruby-net-ldap` gem's `Net::LDAP::DN`
 #

lib/gitlab/auth/ldap/ldap_connection_error.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Auth
     module LDAP

lib/gitlab/auth/ldap/person.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Auth
     module LDAP

lib/gitlab/auth/ldap/user.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # LDAP extension for User model
 #
 # * Find or create user from omniauth.auth data

lib/gitlab/auth/o_auth/auth_hash.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Class to parse and transform the info provided by omniauth
 #
 module Gitlab

lib/gitlab/auth/o_auth/authentication.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # These calls help to authenticate to OAuth provider by providing username and password
 #
 

lib/gitlab/auth/o_auth/identity_linker.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Auth
     module OAuth

lib/gitlab/auth/o_auth/provider.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Auth
     module OAuth

lib/gitlab/auth/o_auth/session.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # :nocov:
 module Gitlab
   module Auth

lib/gitlab/auth/o_auth/user.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # OAuth extension for User model
 #
 # * Find GitLab user based on omniauth uid and provider

lib/gitlab/auth/omniauth_identity_linker_base.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Auth
     class OmniauthIdentityLinkerBase

lib/gitlab/auth/request_authenticator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Use for authentication only, in particular for Rack::Attack.
 # Does not perform authorization of scopes, etc.
 module Gitlab

lib/gitlab/auth/result.rb

@@ -1,4 +1,7 @@
-module Gitlab # rubocop:disable Naming/FileName
+# rubocop:disable Naming/FileName
+# frozen_string_literal: true
+
+module Gitlab
   module Auth
     Result = Struct.new(:actor, :project, :type, :authentication_abilities) do
       def ci?(for_project)

lib/gitlab/auth/saml/auth_hash.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Auth
     module Saml

lib/gitlab/auth/saml/config.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Auth
     module Saml

lib/gitlab/auth/saml/identity_linker.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Auth
     module Saml

lib/gitlab/auth/saml/user.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # SAML extension for User model
 #
 # * Find GitLab user based on SAML uid and provider

lib/gitlab/auth/too_many_ips.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Auth
     class TooManyIps < StandardError

lib/gitlab/auth/unique_ips_limiter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Auth
     class UniqueIpsLimiter

lib/gitlab/auth/user_access_denied_reason.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Auth
     class UserAccessDeniedReason

lib/gitlab/auth/user_auth_finders.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Auth
     AuthenticationError = Class.new(StandardError)

lib/gitlab/badge/base.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Badge
     class Base

lib/gitlab/badge/coverage/metadata.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Badge
     module Coverage

lib/gitlab/badge/coverage/report.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Badge
     module Coverage

lib/gitlab/badge/coverage/template.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Badge
     module Coverage

lib/gitlab/badge/metadata.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Badge
     ##

lib/gitlab/badge/pipeline/metadata.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Badge
     module Pipeline

lib/gitlab/badge/pipeline/status.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Badge
     module Pipeline

lib/gitlab/badge/pipeline/template.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Badge
     module Pipeline

lib/gitlab/badge/template.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Badge
     ##

lib/gitlab/bare_repository_import/importer.rb

@@ -1,10 +1,15 @@
+# frozen_string_literal: true
+
 module Gitlab
   module BareRepositoryImport
     class Importer
       NoAdminError = Class.new(StandardError)
 
       def self.execute(import_path)
-        import_path << '/' unless import_path.ends_with?('/')
+        unless import_path.ends_with?('/')
+          import_path = "#{import_path}/"
+        end
+
         repos_to_import = Dir.glob(import_path + '**/*.git')
 
         unless user = User.admins.order_id_asc.first

lib/gitlab/bare_repository_import/repository.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module BareRepositoryImport
     class Repository
@@ -6,9 +8,12 @@ module Gitlab
       attr_reader :group_path, :project_name, :repo_path
 
       def initialize(root_path, repo_path)
+        unless root_path.ends_with?('/')
+          root_path = "#{root_path}/"
+        end
+
         @root_path = root_path
         @repo_path = repo_path
-        @root_path << '/' unless root_path.ends_with?('/')
 
         full_path =
           if hashed? && !wiki?

lib/gitlab/bitbucket_import/importer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module BitbucketImport
     class Importer

lib/gitlab/bitbucket_import/project_creator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module BitbucketImport
     class ProjectCreator

lib/gitlab/bitbucket_server_import/project_creator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module BitbucketServerImport
     class ProjectCreator

lib/gitlab/cache/ci/project_pipeline_status.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # This class is not backed by a table in the main database.
 # It loads the latest Pipeline for the HEAD of a repository, and caches that
 # in Redis.

lib/gitlab/cache/request_cache.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Cache
     # See https://docs.gitlab.com/ee/development/utilities.html#requestcache

lib/gitlab/checks/change_access.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Checks
     class ChangeAccess

lib/gitlab/checks/commit_check.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Checks
     class CommitCheck

lib/gitlab/checks/force_push.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Checks
     class ForcePush

lib/gitlab/checks/lfs_integrity.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Checks
     class LfsIntegrity

lib/gitlab/checks/matching_merge_request.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Checks
     class MatchingMergeRequest

lib/gitlab/checks/post_push_message.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Checks
     class PostPushMessage

lib/gitlab/checks/project_created.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Checks
     class ProjectCreated < PostPushMessage

lib/gitlab/checks/project_moved.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitlab
   module Checks
     class ProjectMoved < PostPushMessage