kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Add another counter to calculate method call ratio

Browse source 
We should see the ratio drop down when enabling the Feature.

Recommendation by @andrewn
This commit is contained in:
Andreas Brandl 2019-08-30 11:50:26 +02:00
parent 1003cd92cb
commit edde1b708a
No known key found for this signature in database
GPG key ID: F25982B13FEE55DA
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
app/models/concerns/routable.rb
View file

@ -33,6 +33,8 @@ module Routable
# #
# Returns a single object, or nil. # Returns a single object, or nil.
def find_by_full_path(path, follow_redirects: false) def find_by_full_path(path, follow_redirects: false)
increment_counter(:routable_find_by_full_path, 'Number of calls to Routable.find_by_full_path')
if Feature.enabled?(:routable_two_step_lookup) if Feature.enabled?(:routable_two_step_lookup)
# Case sensitive match first (it's cheaper and the usual case) # Case sensitive match first (it's cheaper and the usual case)
# If we didn't have an exact match, we perform a case insensitive search # If we didn't have an exact match, we perform a case insensitive search
@ -59,7 +61,7 @@ module Routable
def where_full_path_in(paths) def where_full_path_in(paths)
return none if paths.empty? return none if paths.empty?
increment_full_path_in_counter increment_counter(:routable_where_full_path_in, 'Number of calls to Routable.where_full_path_in')
wheres = paths.map do |path| wheres = paths.map do |path|
"(LOWER(routes.path) = LOWER(#{connection.quote(path)}))" "(LOWER(routes.path) = LOWER(#{connection.quote(path)}))"
@ -68,11 +70,11 @@ module Routable
joins(:route).where(wheres.join(' OR ')) joins(:route).where(wheres.join(' OR '))
end end
# Temporary instrumentation of method calls for .where_full_path_in # Temporary instrumentation of method calls
def increment_full_path_in_counter def increment_counter(counter, description)
@counter ||= Gitlab::Metrics.counter(:routable_caseinsensitive_lookup_calls, 'Number of calls to Routable.where_full_path_in') @counters[counter] ||= Gitlab::Metrics.counter(counter, description)
@counter.increment @counters[counter].increment
rescue rescue
# ignore the error # ignore the error
end end