From ee750298675f0beed94688a9798d3e0b8362b455 Mon Sep 17 00:00:00 2001 From: Dmitriy Zaporozhets Date: Wed, 19 Feb 2014 09:38:01 +0200 Subject: [PATCH] Move assignee/milestone below description of Issue Signed-off-by: Dmitriy Zaporozhets --- app/assets/stylesheets/generic/issue_box.scss | 7 ++++--- app/views/projects/issues/show.html.haml | 8 ++++---- app/views/projects/merge_requests/show/_mr_box.html.haml | 8 ++++---- features/steps/project/project_merge_requests.rb | 6 ++++-- 4 files changed, 16 insertions(+), 13 deletions(-) diff --git a/app/assets/stylesheets/generic/issue_box.scss b/app/assets/stylesheets/generic/issue_box.scss index 3baad20caab..0e0a365a82d 100644 --- a/app/assets/stylesheets/generic/issue_box.scss +++ b/app/assets/stylesheets/generic/issue_box.scss @@ -29,20 +29,21 @@ line-height: 1.5; margin: 0; color: #333; + padding-bottom: 0; + padding: 15px 25px; } .context { border: none; border-top: 1px solid #eee; + padding: 15px 25px; } .description { - border-top: 1px solid #eee; + padding: 0 25px 15px 25px; } .title, .context, .description { - padding: 15px 25px; - .clearfix { margin: 0; } diff --git a/app/views/projects/issues/show.html.haml b/app/views/projects/issues/show.html.haml index 3455028117d..7aa37eda965 100644 --- a/app/views/projects/issues/show.html.haml +++ b/app/views/projects/issues/show.html.haml @@ -42,15 +42,15 @@ %h4.title = gfm escape_once(@issue.title) - .context - %cite.cgray - = render partial: 'issue_context', locals: { issue: @issue } - - if @issue.description.present? .description .wiki = preserve do = markdown @issue.description + .context + %cite.cgray + = render partial: 'issue_context', locals: { issue: @issue } + - content_for :note_actions do - if can?(current_user, :modify_issue, @issue) diff --git a/app/views/projects/merge_requests/show/_mr_box.html.haml b/app/views/projects/merge_requests/show/_mr_box.html.haml index e05d2215f9a..803e00292b0 100644 --- a/app/views/projects/merge_requests/show/_mr_box.html.haml +++ b/app/views/projects/merge_requests/show/_mr_box.html.haml @@ -15,16 +15,16 @@ %h4.title = gfm escape_once(@merge_request.title) - .context - %cite.cgray - = render partial: 'projects/merge_requests/show/context', locals: { merge_request: @merge_request } - - if @merge_request.description.present? .description .wiki = preserve do = markdown @merge_request.description + .context + %cite.cgray + = render partial: 'projects/merge_requests/show/context', locals: { merge_request: @merge_request } + - if @merge_request.closed? .alert.alert-info %span diff --git a/features/steps/project/project_merge_requests.rb b/features/steps/project/project_merge_requests.rb index cc2648c6204..adf9e77e136 100644 --- a/features/steps/project/project_merge_requests.rb +++ b/features/steps/project/project_merge_requests.rb @@ -55,7 +55,9 @@ class ProjectMergeRequests < Spinach::FeatureSteps end step 'I click link "Close"' do - click_link "Close" + within '.page-title' do + click_link "Close" + end end step 'I submit new merge request "Wiki Feature"' do @@ -163,7 +165,7 @@ class ProjectMergeRequests < Spinach::FeatureSteps end step 'I should see merged request' do - within '.page-title' do + within '.issue-box' do page.should have_content "Merged" end end