kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Fix broken vue i18n strings

This commit is contained in:
André Luís 2019-07-16 02:48:40 +00:00 committed by Kushal Pandya
parent ad5bcd9109
commit ee85e3f466
4 changed files with 39 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
app/assets/javascripts/diffs/components/diff_file.vue
View File

@ -67,6 +67,18 @@ export default {
errorMessage() {
return this.file.viewer.error_message;
},
forkMessage() {
return sprintf(
__(
"You're not allowed to %{tag_start}edit%{tag_end} files in this project directly. Please fork this project, make your changes there, and submit a merge request.",
),
{
tag_start: '<span class="js-file-fork-suggestion-section-action">',
tag_end: '</span>',
},
false,
);
},
},
watch: {
isCollapsed: function fileCollapsedWatch(newVal, oldVal) {
@ -150,12 +162,7 @@ export default {
/>
<div v-if="forkMessageVisible" class="js-file-fork-suggestion-section file-fork-suggestion">
<span class="file-fork-suggestion-note">
{{ sprintf(__("You're not allowed to %{tag_start}edit%{tag_end} files in this project
directly. Please fork this project, make your changes there, and submit a merge request."),
{ tag_start: '<span class="js-file-fork-suggestion-section-action">', tag_end: '</span>' })
}}
</span>
<span class="file-fork-suggestion-note" v-html="forkMessage"></span>
<a
:href="file.fork_path"
class="js-fork-suggestion-button btn btn-grouped btn-inverted btn-success"

21
app/assets/javascripts/issue_show/components/locked_warning.vue
View File

@ -1,18 +1,27 @@
<script>
import { __, sprintf } from '~/locale';
export default {
computed: {
currentPath() {
return window.location.pathname;
},
alertMessage() {
return sprintf(
__(
'Someone edited the issue at the same time you did. Please check out %{linkStart}the issue%{linkEnd} and make sure your changes will not unintentionally remove theirs.',
),
{
linkStart: `<a href="${this.currentPath}" target="_blank" rel="nofollow">`,
linkEnd: `</a>`,
},
false,
);
},
},
};
</script>
<template>
<div class="alert alert-danger">
{{ sprintf(__("Someone edited the issue at the same time you did. Please check out
%{linkStart}%the issue%{linkEnd} and make sure your changes will not unintentionally remove
theirs."), { linkStart: `<a href="${currentPath}" target="_blank" rel="nofollow">` linkEnd: '</a
>', }) }}
</div>
<div class="alert alert-danger" v-html="alertMessage"></div>
</template>

5
changelogs/unreleased/fix-broken-vue-i18n-strings.yml Normal file
View File

@ -0,0 +1,5 @@
---
title: Fix broken warnings while Editing Issues and Edit File on MR
merge_request:
author:
type: fixed

6
locale/gitlab.pot
View File

@ -9733,6 +9733,9 @@ msgstr ""
msgid "Some email servers do not support overriding the email sender name. Enable this option to include the name of the author of the issue, merge request or comment in the email body instead."
msgstr ""
msgid "Someone edited the issue at the same time you did. Please check out %{linkStart}the issue%{linkEnd} and make sure your changes will not unintentionally remove theirs."
msgstr ""
msgid "Someone edited this %{issueType} at the same time you did. The description has been updated and you will need to make your changes again."
msgstr ""
@ -12516,6 +12519,9 @@ msgstr ""
msgid "You'll need to use different branch names to get a valid comparison."
msgstr ""
msgid "You're not allowed to %{tag_start}edit%{tag_end} files in this project directly. Please fork this project, make your changes there, and submit a merge request."
msgstr ""
msgid "You're not allowed to make changes to this project directly. A fork of this project has been created that you can make changes in, so you can submit a merge request."
msgstr ""