Fix bug where dropdowns would not dismiss properly
This commit is contained in:
parent
c18285cec0
commit
f0608878ce
|
@ -29,7 +29,7 @@
|
|||
gl.FilteredSearchManager.addWordToInput(this.getSelectedText(username));
|
||||
}
|
||||
|
||||
this.dismissDropdown();
|
||||
this.dismissDropdown(!dataValueSet);
|
||||
}
|
||||
|
||||
renderContent() {
|
||||
|
|
|
@ -34,16 +34,19 @@
|
|||
|
||||
itemClicked(e) {
|
||||
const selected = e.detail.selected;
|
||||
if (!selected.hasAttribute('data-value')) {
|
||||
|
||||
if (selected.hasAttribute('data-value')) {
|
||||
this.dismissDropdown();
|
||||
} else {
|
||||
const token = selected.querySelector('.js-filter-hint').innerText.trim();
|
||||
const tag = selected.querySelector('.js-filter-tag').innerText.trim();
|
||||
|
||||
if (tag.length) {
|
||||
gl.FilteredSearchManager.addWordToInput(this.getSelectedText(token));
|
||||
}
|
||||
this.dismissDropdown();
|
||||
this.dispatchInputEvent();
|
||||
}
|
||||
|
||||
this.dismissDropdown();
|
||||
}
|
||||
|
||||
renderContent() {
|
||||
|
|
|
@ -26,7 +26,8 @@
|
|||
gl.FilteredSearchManager.addWordToInput(labelName);
|
||||
}
|
||||
|
||||
this.dismissDropdown();
|
||||
// debugger
|
||||
this.dismissDropdown(!dataValueSet);
|
||||
}
|
||||
|
||||
renderContent() {
|
||||
|
|
|
@ -26,7 +26,7 @@
|
|||
gl.FilteredSearchManager.addWordToInput(this.getSelectedText(milestoneName));
|
||||
}
|
||||
|
||||
this.dismissDropdown();
|
||||
this.dismissDropdown(!dataValueSet);
|
||||
}
|
||||
|
||||
renderContent() {
|
||||
|
|
|
@ -77,11 +77,15 @@
|
|||
}
|
||||
|
||||
dismissDropdown() {
|
||||
this.getCurrentHook().list.hide();
|
||||
this.input.focus();
|
||||
}
|
||||
|
||||
dispatchInputEvent() {
|
||||
// Propogate input change to FilteredSearchManager
|
||||
// so that it can determine which dropdowns to open
|
||||
this.input.dispatchEvent(new Event('input'));
|
||||
}
|
||||
}
|
||||
|
||||
render(forceRenderContent) {
|
||||
this.setAsDropdown();
|
||||
|
@ -91,7 +95,6 @@
|
|||
if (firstTimeInitialized || forceRenderContent) {
|
||||
this.renderContent();
|
||||
} else if(this.getCurrentHook().list.list.id !== this.listId) {
|
||||
// this.droplab.changeHookList(this.hookId, `#${this.listId}`);
|
||||
this.renderContent();
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue