From f14814c9815f86a95808f089ff219d4e768641c0 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 28 Apr 2022 18:10:01 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .rubocop_todo/gitlab/namespaced_class.yml | 1 - .rubocop_todo/layout/line_length.yml | 1 - .../destroy_http_integration.mutation.graphql | 2 +- .../reset_http_token.mutation.graphql | 2 +- .../reset_prometheus_token.mutation.graphql | 2 +- .../update_http_integration.mutation.graphql | 6 +- ...te_prometheus_integration.mutation.graphql | 6 +- .../get_http_integration.query.graphql | 2 +- .../board_list_destroy.mutation.graphql | 2 +- .../board_list_update.mutation.graphql | 2 +- .../boards/graphql/board_lists.query.graphql | 2 +- .../board_lists_deferred.query.graphql | 2 +- .../boards/graphql/group_board.query.graphql | 2 +- .../graphql/issue_move_list.mutation.graphql | 2 +- .../boards/graphql/lists_issues.query.graphql | 4 +- .../graphql/project_board.query.graphql | 2 +- ...toggle_resolve_discussion.mutation.graphql | 2 +- .../queries/details.query.graphql | 2 +- .../mutations/todo_mark_done.mutation.graphql | 2 +- .../components/diff_discussion_header.vue | 5 +- ...container_repository_details.query.graphql | 2 +- ...ontainer_repository_metadata.query.graphql | 2 +- ...et_container_repository_tags.query.graphql | 2 +- .../queries/get_package_details.query.graphql | 2 +- .../reviewer_rereview.mutation.graphql | 2 +- ...oggle_attention_requested.mutation.graphql | 2 +- ...e_merge_request_milestone.mutation.graphql | 2 +- .../mutations/delete_snippet.mutation.graphql | 2 +- .../graphql/work_item.query.graphql | 2 +- .../admin/requests_profiles_controller.rb | 21 --- app/controllers/clusters/base_controller.rb | 4 + .../google_api/authorizations_controller.rb | 1 + .../projects/cluster_agents_controller.rb | 1 + .../projects/merge_requests_controller.rb | 7 +- .../infrastructure_registry_controller.rb | 1 + .../serverless/functions_controller.rb | 1 + .../projects/terraform_controller.rb | 1 + .../get_design_list.query.graphql | 2 +- .../snippet_blob_content.query.graphql | 2 +- .../resolvers/ci/runner_status_resolver.rb | 9 +- app/graphql/types/ci/runner_type.rb | 2 +- app/helpers/nav_helper.rb | 2 +- app/models/ci/runner.rb | 7 +- app/models/container_repository.rb | 8 +- .../reset_registration_token_service.rb | 2 + .../batch_cleaner_service.rb | 2 - .../admin/requests_profiles/index.html.haml | 22 --- .../layouts/nav/sidebar/_admin.html.haml | 4 - app/workers/all_queues.yml | 9 -- .../migration/enqueuer_worker.rb | 3 +- app/workers/requests_profiles_worker.rb | 18 --- .../development/lfk_fair_queueing.yml | 8 -- .../development/vsa_reaggregation_worker.yml | 2 +- config/initializers/1_settings.rb | 3 - config/initializers/request_profiler.rb | 1 - config/routes/admin.rb | 1 - ...unner-api-status-renames-not_connected.yml | 15 -- ...d-replaced-with-paused-breaking-change.yml | 4 +- ...us-filter-does-accept-active-or-paused.yml | 2 +- .../15-0-runner-status-legacy-mode.yml | 18 +++ ...0-remove-dependency-proxy-feature-flag.yml | 13 ++ .../15_0/15-0-remove-versions-packagetype.yml | 13 ++ .../geo/replication/datatypes.md | 2 +- doc/api/graphql/reference/index.md | 2 +- doc/api/repository_files.md | 48 ++++++- doc/development/pipelines.md | 13 +- doc/subscriptions/gitlab_dedicated/index.md | 74 ++++++++++ doc/topics/git/feature_branching.md | 2 +- doc/topics/git/git_rebase.md | 27 ++-- doc/topics/git/lfs/index.md | 12 +- doc/topics/git/merge_conflicts.md | 18 +-- doc/topics/git/partial_clone.md | 9 +- doc/topics/git/stash.md | 8 +- doc/topics/git/tags.md | 2 +- doc/topics/git/terminology.md | 6 +- doc/topics/git/useful_git_commands.md | 4 +- doc/update/deprecations.md | 34 +++-- doc/update/removals.md | 24 ++++ lib/api/admin/instance_clusters.rb | 1 + lib/api/ci/jobs.rb | 2 +- lib/api/clusters/agents.rb | 1 + lib/api/files.rb | 18 ++- lib/api/group_clusters.rb | 1 + lib/api/internal/kubernetes.rb | 5 + lib/api/project_clusters.rb | 1 + lib/api/terraform/modules/v1/packages.rb | 1 + lib/api/terraform/state.rb | 1 + lib/api/terraform/state_version.rb | 1 + lib/gitlab/backtrace_cleaner.rb | 1 - lib/gitlab/profiler.rb | 1 - lib/gitlab/request_profiler.rb | 36 ----- lib/gitlab/request_profiler/middleware.rb | 107 -------------- lib/gitlab/request_profiler/profile.rb | 43 ------ locale/gitlab.pot | 9 -- .../api/1_manage/import_github_repo_spec.rb | 2 +- .../project/import_github_repo_spec.rb | 2 +- .../requests_profiles_controller_spec.rb | 72 ---------- .../admin/admin_requests_profiles_spec.rb | 136 ------------------ spec/lib/gitlab/backtrace_cleaner_spec.rb | 1 - .../gitlab/request_profiler/profile_spec.rb | 61 -------- spec/lib/gitlab/request_profiler_spec.rb | 56 -------- spec/requests/api/files_spec.rb | 60 ++++++++ spec/requests/request_profiler_spec.rb | 56 -------- .../batch_cleaner_service_spec.rb | 10 -- .../container_repositories_shared_examples.rb | 28 ++-- .../migration/enqueuer_worker_spec.rb | 41 ++++-- 106 files changed, 463 insertions(+), 854 deletions(-) delete mode 100644 app/controllers/admin/requests_profiles_controller.rb delete mode 100644 app/views/admin/requests_profiles/index.html.haml delete mode 100644 app/workers/requests_profiles_worker.rb delete mode 100644 config/feature_flags/development/lfk_fair_queueing.yml delete mode 100644 data/deprecations/14-6-runner-api-status-renames-not_connected.yml create mode 100644 data/deprecations/15-0-runner-status-legacy-mode.yml create mode 100644 data/removals/15_0/15-0-remove-dependency-proxy-feature-flag.yml create mode 100644 data/removals/15_0/15-0-remove-versions-packagetype.yml create mode 100644 doc/subscriptions/gitlab_dedicated/index.md delete mode 100644 lib/gitlab/request_profiler.rb delete mode 100644 lib/gitlab/request_profiler/middleware.rb delete mode 100644 lib/gitlab/request_profiler/profile.rb delete mode 100644 spec/controllers/admin/requests_profiles_controller_spec.rb delete mode 100644 spec/features/admin/admin_requests_profiles_spec.rb delete mode 100644 spec/lib/gitlab/request_profiler/profile_spec.rb delete mode 100644 spec/lib/gitlab/request_profiler_spec.rb delete mode 100644 spec/requests/request_profiler_spec.rb diff --git a/.rubocop_todo/gitlab/namespaced_class.yml b/.rubocop_todo/gitlab/namespaced_class.yml index aa60c135af9..ba820abbb3e 100644 --- a/.rubocop_todo/gitlab/namespaced_class.yml +++ b/.rubocop_todo/gitlab/namespaced_class.yml @@ -875,7 +875,6 @@ Gitlab/NamespacedClass: - app/workers/repository_import_worker.rb - app/workers/repository_remove_remote_worker.rb - app/workers/repository_update_remote_mirror_worker.rb - - app/workers/requests_profiles_worker.rb - app/workers/run_pipeline_schedule_worker.rb - app/workers/schedule_merge_request_cleanup_refs_worker.rb - app/workers/schedule_migrate_external_diffs_worker.rb diff --git a/.rubocop_todo/layout/line_length.yml b/.rubocop_todo/layout/line_length.yml index 12db16d1f39..e23ca755000 100644 --- a/.rubocop_todo/layout/line_length.yml +++ b/.rubocop_todo/layout/line_length.yml @@ -5862,7 +5862,6 @@ Layout/LineLength: - 'spec/requests/projects_controller_spec.rb' - 'spec/requests/rack_attack_global_spec.rb' - 'spec/requests/recursive_webhook_detection_spec.rb' - - 'spec/requests/request_profiler_spec.rb' - 'spec/requests/users_controller_spec.rb' - 'spec/routing/admin_routing_spec.rb' - 'spec/routing/group_routing_spec.rb' diff --git a/app/assets/javascripts/alerts_settings/graphql/mutations/destroy_http_integration.mutation.graphql b/app/assets/javascripts/alerts_settings/graphql/mutations/destroy_http_integration.mutation.graphql index a3a50651fd0..05bf8eab524 100644 --- a/app/assets/javascripts/alerts_settings/graphql/mutations/destroy_http_integration.mutation.graphql +++ b/app/assets/javascripts/alerts_settings/graphql/mutations/destroy_http_integration.mutation.graphql @@ -1,6 +1,6 @@ #import "../fragments/http_integration_item.fragment.graphql" -mutation destroyHttpIntegration($id: ID!) { +mutation destroyHttpIntegration($id: AlertManagementHttpIntegrationID!) { httpIntegrationDestroy(input: { id: $id }) { errors integration { diff --git a/app/assets/javascripts/alerts_settings/graphql/mutations/reset_http_token.mutation.graphql b/app/assets/javascripts/alerts_settings/graphql/mutations/reset_http_token.mutation.graphql index c0754d8e32b..65245bfb914 100644 --- a/app/assets/javascripts/alerts_settings/graphql/mutations/reset_http_token.mutation.graphql +++ b/app/assets/javascripts/alerts_settings/graphql/mutations/reset_http_token.mutation.graphql @@ -1,6 +1,6 @@ #import "../fragments/http_integration_item.fragment.graphql" -mutation resetHttpIntegrationToken($id: ID!) { +mutation resetHttpIntegrationToken($id: AlertManagementHttpIntegrationID!) { httpIntegrationResetToken(input: { id: $id }) { errors integration { diff --git a/app/assets/javascripts/alerts_settings/graphql/mutations/reset_prometheus_token.mutation.graphql b/app/assets/javascripts/alerts_settings/graphql/mutations/reset_prometheus_token.mutation.graphql index 8f34521b9fd..99179fca1f9 100644 --- a/app/assets/javascripts/alerts_settings/graphql/mutations/reset_prometheus_token.mutation.graphql +++ b/app/assets/javascripts/alerts_settings/graphql/mutations/reset_prometheus_token.mutation.graphql @@ -1,6 +1,6 @@ #import "../fragments/integration_item.fragment.graphql" -mutation resetPrometheusIntegrationToken($id: ID!) { +mutation resetPrometheusIntegrationToken($id: IntegrationsPrometheusID!) { prometheusIntegrationResetToken(input: { id: $id }) { errors integration { diff --git a/app/assets/javascripts/alerts_settings/graphql/mutations/update_http_integration.mutation.graphql b/app/assets/javascripts/alerts_settings/graphql/mutations/update_http_integration.mutation.graphql index 37df9ec25eb..cc9e841ffb9 100644 --- a/app/assets/javascripts/alerts_settings/graphql/mutations/update_http_integration.mutation.graphql +++ b/app/assets/javascripts/alerts_settings/graphql/mutations/update_http_integration.mutation.graphql @@ -1,6 +1,10 @@ #import "../fragments/http_integration_item.fragment.graphql" -mutation updateHttpIntegration($id: ID!, $name: String!, $active: Boolean!) { +mutation updateHttpIntegration( + $id: AlertManagementHttpIntegrationID! + $name: String! + $active: Boolean! +) { httpIntegrationUpdate(input: { id: $id, name: $name, active: $active }) { errors integration { diff --git a/app/assets/javascripts/alerts_settings/graphql/mutations/update_prometheus_integration.mutation.graphql b/app/assets/javascripts/alerts_settings/graphql/mutations/update_prometheus_integration.mutation.graphql index 62761730bd2..95d72e4af91 100644 --- a/app/assets/javascripts/alerts_settings/graphql/mutations/update_prometheus_integration.mutation.graphql +++ b/app/assets/javascripts/alerts_settings/graphql/mutations/update_prometheus_integration.mutation.graphql @@ -1,6 +1,10 @@ #import "../fragments/integration_item.fragment.graphql" -mutation updatePrometheusIntegration($id: ID!, $apiUrl: String!, $active: Boolean!) { +mutation updatePrometheusIntegration( + $id: IntegrationsPrometheusID! + $apiUrl: String! + $active: Boolean! +) { prometheusIntegrationUpdate(input: { id: $id, apiUrl: $apiUrl, active: $active }) { errors integration { diff --git a/app/assets/javascripts/alerts_settings/graphql/queries/get_http_integration.query.graphql b/app/assets/javascripts/alerts_settings/graphql/queries/get_http_integration.query.graphql index 7299e6836d4..5f6ab27cae9 100644 --- a/app/assets/javascripts/alerts_settings/graphql/queries/get_http_integration.query.graphql +++ b/app/assets/javascripts/alerts_settings/graphql/queries/get_http_integration.query.graphql @@ -1,6 +1,6 @@ #import "ee_else_ce/alerts_settings/graphql/fragments/http_integration_payload_data.fragment.graphql" -query getHttpIntegration($projectPath: ID!, $id: ID) { +query getHttpIntegration($projectPath: ID!, $id: AlertManagementHttpIntegrationID!) { project(fullPath: $projectPath) { id alertManagementHttpIntegrations(id: $id) { diff --git a/app/assets/javascripts/boards/graphql/board_list_destroy.mutation.graphql b/app/assets/javascripts/boards/graphql/board_list_destroy.mutation.graphql index ef3fd36e980..5cb1a74d5c7 100644 --- a/app/assets/javascripts/boards/graphql/board_list_destroy.mutation.graphql +++ b/app/assets/javascripts/boards/graphql/board_list_destroy.mutation.graphql @@ -1,4 +1,4 @@ -mutation DestroyBoardList($listId: ID!) { +mutation DestroyBoardList($listId: ListID!) { destroyBoardList(input: { listId: $listId }) { errors } diff --git a/app/assets/javascripts/boards/graphql/board_list_update.mutation.graphql b/app/assets/javascripts/boards/graphql/board_list_update.mutation.graphql index b474c9acb93..13327028065 100644 --- a/app/assets/javascripts/boards/graphql/board_list_update.mutation.graphql +++ b/app/assets/javascripts/boards/graphql/board_list_update.mutation.graphql @@ -1,6 +1,6 @@ #import "./board_list.fragment.graphql" -mutation UpdateBoardList($listId: ID!, $position: Int, $collapsed: Boolean) { +mutation UpdateBoardList($listId: ListID!, $position: Int, $collapsed: Boolean) { updateBoardList(input: { listId: $listId, position: $position, collapsed: $collapsed }) { list { ...BoardListFragment diff --git a/app/assets/javascripts/boards/graphql/board_lists.query.graphql b/app/assets/javascripts/boards/graphql/board_lists.query.graphql index 8780d6fd91a..06e8c8783de 100644 --- a/app/assets/javascripts/boards/graphql/board_lists.query.graphql +++ b/app/assets/javascripts/boards/graphql/board_lists.query.graphql @@ -2,7 +2,7 @@ query BoardLists( $fullPath: ID! - $boardId: ID! + $boardId: BoardID! $filters: BoardIssueInput $isGroup: Boolean = false $isProject: Boolean = false diff --git a/app/assets/javascripts/boards/graphql/board_lists_deferred.query.graphql b/app/assets/javascripts/boards/graphql/board_lists_deferred.query.graphql index bae3220dfad..f48383624c9 100644 --- a/app/assets/javascripts/boards/graphql/board_lists_deferred.query.graphql +++ b/app/assets/javascripts/boards/graphql/board_lists_deferred.query.graphql @@ -1,4 +1,4 @@ -query BoardList($id: ID!, $filters: BoardIssueInput) { +query BoardList($id: ListID!, $filters: BoardIssueInput) { boardList(id: $id, issueFilters: $filters) { id issuesCount diff --git a/app/assets/javascripts/boards/graphql/group_board.query.graphql b/app/assets/javascripts/boards/graphql/group_board.query.graphql index 8d87b83da96..526e3193efe 100644 --- a/app/assets/javascripts/boards/graphql/group_board.query.graphql +++ b/app/assets/javascripts/boards/graphql/group_board.query.graphql @@ -1,6 +1,6 @@ #import "ee_else_ce/boards/graphql/board_scope.fragment.graphql" -query GroupBoard($fullPath: ID!, $boardId: ID!) { +query GroupBoard($fullPath: ID!, $boardId: BoardID!) { workspace: group(fullPath: $fullPath) { id board(id: $boardId) { diff --git a/app/assets/javascripts/boards/graphql/issue_move_list.mutation.graphql b/app/assets/javascripts/boards/graphql/issue_move_list.mutation.graphql index 1658cf09085..89670760450 100644 --- a/app/assets/javascripts/boards/graphql/issue_move_list.mutation.graphql +++ b/app/assets/javascripts/boards/graphql/issue_move_list.mutation.graphql @@ -3,7 +3,7 @@ mutation issueMoveList( $projectPath: ID! $iid: String! - $boardId: ID! + $boardId: BoardID! $fromListId: ID $toListId: ID $moveBeforeId: ID diff --git a/app/assets/javascripts/boards/graphql/lists_issues.query.graphql b/app/assets/javascripts/boards/graphql/lists_issues.query.graphql index 994ea894be3..bf5329c4a8d 100644 --- a/app/assets/javascripts/boards/graphql/lists_issues.query.graphql +++ b/app/assets/javascripts/boards/graphql/lists_issues.query.graphql @@ -2,8 +2,8 @@ query BoardListsEE( $fullPath: ID! - $boardId: ID! - $id: ID + $boardId: BoardID! + $id: ListID $filters: BoardIssueInput $isGroup: Boolean = false $isProject: Boolean = false diff --git a/app/assets/javascripts/boards/graphql/project_board.query.graphql b/app/assets/javascripts/boards/graphql/project_board.query.graphql index 8246d615a6a..2a9142696d2 100644 --- a/app/assets/javascripts/boards/graphql/project_board.query.graphql +++ b/app/assets/javascripts/boards/graphql/project_board.query.graphql @@ -1,6 +1,6 @@ #import "ee_else_ce/boards/graphql/board_scope.fragment.graphql" -query ProjectBoard($fullPath: ID!, $boardId: ID!) { +query ProjectBoard($fullPath: ID!, $boardId: BoardID!) { workspace: project(fullPath: $fullPath) { id board(id: $boardId) { diff --git a/app/assets/javascripts/design_management/graphql/mutations/toggle_resolve_discussion.mutation.graphql b/app/assets/javascripts/design_management/graphql/mutations/toggle_resolve_discussion.mutation.graphql index 124f12ef018..c235e7fbf3d 100644 --- a/app/assets/javascripts/design_management/graphql/mutations/toggle_resolve_discussion.mutation.graphql +++ b/app/assets/javascripts/design_management/graphql/mutations/toggle_resolve_discussion.mutation.graphql @@ -2,7 +2,7 @@ #import "../fragments/discussion_resolved_status.fragment.graphql" #import "../fragments/design_todo_item.fragment.graphql" -mutation toggleResolveDiscussion($id: ID!, $resolve: Boolean!) { +mutation toggleResolveDiscussion($id: DiscussionID!, $resolve: Boolean!) { discussionToggleResolve(input: { id: $id, resolve: $resolve }) { discussion { id diff --git a/app/assets/javascripts/error_tracking/queries/details.query.graphql b/app/assets/javascripts/error_tracking/queries/details.query.graphql index f70e09d76f7..dd21b0f9c92 100644 --- a/app/assets/javascripts/error_tracking/queries/details.query.graphql +++ b/app/assets/javascripts/error_tracking/queries/details.query.graphql @@ -1,4 +1,4 @@ -query errorDetails($fullPath: ID!, $errorId: ID!) { +query errorDetails($fullPath: ID!, $errorId: GitlabErrorTrackingDetailedErrorID!) { project(fullPath: $fullPath) { id sentryErrors { diff --git a/app/assets/javascripts/graphql_shared/mutations/todo_mark_done.mutation.graphql b/app/assets/javascripts/graphql_shared/mutations/todo_mark_done.mutation.graphql index 4d59b4d94cd..e8ad919f4a8 100644 --- a/app/assets/javascripts/graphql_shared/mutations/todo_mark_done.mutation.graphql +++ b/app/assets/javascripts/graphql_shared/mutations/todo_mark_done.mutation.graphql @@ -1,4 +1,4 @@ -mutation todoMarkDone($id: ID!) { +mutation todoMarkDone($id: TodoID!) { todoMarkDone(input: { id: $id }) { errors todo { diff --git a/app/assets/javascripts/notes/components/diff_discussion_header.vue b/app/assets/javascripts/notes/components/diff_discussion_header.vue index 45d97f278dc..5210d2ca287 100644 --- a/app/assets/javascripts/notes/components/diff_discussion_header.vue +++ b/app/assets/javascripts/notes/components/diff_discussion_header.vue @@ -98,13 +98,14 @@ export default {