kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Cleanup polling of merge request widget in tests

This commit is contained in:
Winnie Hellmann 2018-09-25 15:49:05 +02:00
parent cb0f024cd4
commit f183dba7c7
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/vue_merge_request_widget/mr_widget_options.vue
View File

@ -114,6 +114,8 @@ export default {
}, },
beforeDestroy() { beforeDestroy() {
eventHub.$off('mr.discussion.updated', this.checkStatus); eventHub.$off('mr.discussion.updated', this.checkStatus);
this.pollingInterval.destroy();
this.deploymentsInterval.destroy();
}, },
methods: { methods: {
createService(store) { createService(store) {

4
spec/javascripts/vue_mr_widget/mr_widget_options_spec.js
View File

@ -27,6 +27,10 @@ describe('mrWidgetOptions', () => {
}); });
}); });
afterEach(() => {
vm.$destroy();
});
describe('data', () => { describe('data', () => {
it('should instantiate Store and Service', () => { it('should instantiate Store and Service', () => {
expect(vm.mr).toBeDefined(); expect(vm.mr).toBeDefined();