Implement review comments for !11963 from @filipa.

- Disable an ESLint check rather than work around it (by
  converting `OAuthRememberMe` from a regular class to a
  static class.

- Scope `$` calls inside `OAuthRememberMe`
This commit is contained in:
Timothy Andrew 2017-07-03 16:23:28 +00:00
parent 8fa08ea3cd
commit f1caa0b316
2 changed files with 5 additions and 4 deletions

View File

@ -128,7 +128,7 @@ import OAuthRememberMe from './oauth_remember_me';
case 'sessions:new':
new UsernameValidator();
new ActiveTabMemoizer();
new OAuthRememberMe({ container: $("#remember_me") }).bindEvents();
new OAuthRememberMe({ container: $(".omniauth-container") }).bindEvents();
break;
case 'projects:boards:show':
case 'projects:boards:index':

View File

@ -12,13 +12,14 @@ export default class OAuthRememberMe {
}
bindEvents() {
this.container.on('click', this.constructor.toggleRememberMe);
$('#remember_me', this.container).on('click', this.toggleRememberMe);
}
static toggleRememberMe(event) {
// eslint-disable-next-line class-methods-use-this
toggleRememberMe(event) {
const rememberMe = $(event.target).is(':checked');
$('.oauth-login').each((i, element) => {
$('.oauth-login', this.container).each((i, element) => {
const href = $(element).attr('href');
if (rememberMe) {