From 5d90de1cb24160b39c423f8cec9f381f0b1213bb Mon Sep 17 00:00:00 2001 From: Dmitriy Zaporozhets Date: Fri, 21 Jul 2017 07:20:35 +0000 Subject: [PATCH 1/2] Update sidekiq_style_guide.md with removing or renaming queues instructions --- doc/development/sidekiq_style_guide.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/doc/development/sidekiq_style_guide.md b/doc/development/sidekiq_style_guide.md index e3a20f29a09..734bce963e5 100644 --- a/doc/development/sidekiq_style_guide.md +++ b/doc/development/sidekiq_style_guide.md @@ -36,3 +36,10 @@ slow jobs blocking work (even for different jobs) on the shared queue. Each Sidekiq worker must be tested using RSpec, just like any other class. These tests should be placed in `spec/workers`. + +## Removing or renaming queues + +Try to avoid renaming or removing queues in minor and patch releases. +During online update instance can have pending jobs and removing the queue can +lead to those jobs being stuck forever. If you can't write migration for those +sidekiq jobs, please consider doing rename or remove queue in major release only. \ No newline at end of file From 921e5ab0e1c7e8b4023ee103d3ca04f4f9180adb Mon Sep 17 00:00:00 2001 From: Dmitriy Zaporozhets Date: Fri, 21 Jul 2017 17:40:48 +0000 Subject: [PATCH 2/2] Capitalize Sidekiq word in dev doc --- doc/development/sidekiq_style_guide.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/development/sidekiq_style_guide.md b/doc/development/sidekiq_style_guide.md index 734bce963e5..1e9fdbc65e2 100644 --- a/doc/development/sidekiq_style_guide.md +++ b/doc/development/sidekiq_style_guide.md @@ -42,4 +42,4 @@ tests should be placed in `spec/workers`. Try to avoid renaming or removing queues in minor and patch releases. During online update instance can have pending jobs and removing the queue can lead to those jobs being stuck forever. If you can't write migration for those -sidekiq jobs, please consider doing rename or remove queue in major release only. \ No newline at end of file +Sidekiq jobs, please consider doing rename or remove queue in major release only. \ No newline at end of file