From 308e2d3ff213a5d5d75090ad7ddd1cb4812f1ef1 Mon Sep 17 00:00:00 2001 From: "Luke \"Jared\" Bennett" Date: Wed, 3 May 2017 13:18:28 +0000 Subject: [PATCH 1/2] Fixed issue_sidebar_spec.rb click as true click cannot hit the right element and removed sleep --- spec/features/issues/issue_sidebar_spec.rb | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/spec/features/issues/issue_sidebar_spec.rb b/spec/features/issues/issue_sidebar_spec.rb index 8589945ab74..0f76cdc35d9 100644 --- a/spec/features/issues/issue_sidebar_spec.rb +++ b/spec/features/issues/issue_sidebar_spec.rb @@ -151,9 +151,7 @@ feature 'Issue Sidebar', feature: true do end def open_issue_sidebar - page.within('aside.right-sidebar.right-sidebar-collapsed') do - find('.js-sidebar-toggle').click - sleep 1 - end + find('aside.right-sidebar.right-sidebar-collapsed .js-sidebar-toggle').trigger('click') + find('aside.right-sidebar.right-sidebar-expanded') end end From d6f07ce41dd6b078840abadc31dc26d81bb33bcf Mon Sep 17 00:00:00 2001 From: "Luke \"Jared\" Bennett" Date: Wed, 3 May 2017 13:24:10 +0000 Subject: [PATCH 2/2] Revert to real click seeing as that was a bug with only the original branch --- spec/features/issues/issue_sidebar_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/features/issues/issue_sidebar_spec.rb b/spec/features/issues/issue_sidebar_spec.rb index 0f76cdc35d9..2002eff7995 100644 --- a/spec/features/issues/issue_sidebar_spec.rb +++ b/spec/features/issues/issue_sidebar_spec.rb @@ -151,7 +151,7 @@ feature 'Issue Sidebar', feature: true do end def open_issue_sidebar - find('aside.right-sidebar.right-sidebar-collapsed .js-sidebar-toggle').trigger('click') + find('aside.right-sidebar.right-sidebar-collapsed .js-sidebar-toggle').click find('aside.right-sidebar.right-sidebar-expanded') end end