diff --git a/.rubocop_todo/gitlab/no_code_coverage_comment.yml b/.rubocop_todo/gitlab/no_code_coverage_comment.yml index f4d50fda11b..0dcee5f32ee 100644 --- a/.rubocop_todo/gitlab/no_code_coverage_comment.yml +++ b/.rubocop_todo/gitlab/no_code_coverage_comment.yml @@ -7,10 +7,9 @@ Gitlab/NoCodeCoverageComment: - 'app/workers/database/batched_background_migration/single_database_worker.rb' - 'config/initializers/net_http_response_patch.rb' - 'ee/app/models/concerns/geo/replicable_model.rb' - - 'ee/app/services/namespaces/free_user_cap/remove_group_group_links_outside_hierarchy_service.rb' - - 'ee/app/workers/namespaces/free_user_cap/remediation_worker.rb' - 'ee/lib/gitlab/geo/replicator.rb' - 'lib/gitlab/auth/o_auth/session.rb' + - 'lib/gitlab/cleanup/personal_access_tokens.rb' - 'lib/gitlab/cycle_analytics/summary/defaults.rb' - 'lib/gitlab/database/background_migration/health_status/signals.rb' - 'lib/gitlab/seeder.rb' diff --git a/app/assets/javascripts/error_tracking/components/error_details.vue b/app/assets/javascripts/error_tracking/components/error_details.vue index a602c92a840..b02c3cd2cba 100644 --- a/app/assets/javascripts/error_tracking/components/error_details.vue +++ b/app/assets/javascripts/error_tracking/components/error_details.vue @@ -13,7 +13,7 @@ import { GlIcon, } from '@gitlab/ui'; import { mapActions, mapGetters, mapState } from 'vuex'; -import createFlash from '~/flash'; +import { createAlert, VARIANT_WARNING } from '~/flash'; import { __, sprintf, n__ } from '~/locale'; import Tracking from '~/tracking'; import TimeAgoTooltip from '~/vue_shared/components/time_ago_tooltip.vue'; @@ -89,7 +89,7 @@ export default { pollInterval: 2000, update: (data) => data.project.sentryErrors.detailedError, error: () => - createFlash({ + createAlert({ message: __('Failed to load error details from Sentry.'), }), result(res) { @@ -234,9 +234,9 @@ export default { if (Date.now() > this.errorPollTimeout) { this.$apollo.queries.error.stopPolling(); this.errorLoading = false; - createFlash({ + createAlert({ message: __('Could not connect to Sentry. Refresh the page to try again.'), - type: 'warning', + variant: VARIANT_WARNING, }); } }, diff --git a/app/assets/javascripts/error_tracking/store/actions.js b/app/assets/javascripts/error_tracking/store/actions.js index fbfcd6ce2df..603f8611005 100644 --- a/app/assets/javascripts/error_tracking/store/actions.js +++ b/app/assets/javascripts/error_tracking/store/actions.js @@ -1,4 +1,4 @@ -import createFlash from '~/flash'; +import { createAlert } from '~/flash'; import { visitUrl } from '~/lib/utils/url_utility'; import { __ } from '~/locale'; import service from '../services'; @@ -18,7 +18,7 @@ export const updateStatus = ({ commit }, { endpoint, redirectUrl, status }) => return resp.data.result; }) .catch(() => - createFlash({ + createAlert({ message: __('Failed to update issue status'), }), ); diff --git a/app/assets/javascripts/error_tracking/store/details/actions.js b/app/assets/javascripts/error_tracking/store/details/actions.js index 09fa650f64b..1409399940a 100644 --- a/app/assets/javascripts/error_tracking/store/details/actions.js +++ b/app/assets/javascripts/error_tracking/store/details/actions.js @@ -1,4 +1,4 @@ -import createFlash from '~/flash'; +import { createAlert } from '~/flash'; import Poll from '~/lib/utils/poll'; import { __ } from '~/locale'; import service from '../../services'; @@ -26,7 +26,7 @@ export function startPollingStacktrace({ commit }, endpoint) { }, errorCallback: () => { commit(types.SET_LOADING_STACKTRACE, false); - createFlash({ + createAlert({ message: __('Failed to load stacktrace.'), }); }, diff --git a/app/assets/javascripts/error_tracking/store/list/actions.js b/app/assets/javascripts/error_tracking/store/list/actions.js index 418056314f6..f633711add3 100644 --- a/app/assets/javascripts/error_tracking/store/list/actions.js +++ b/app/assets/javascripts/error_tracking/store/list/actions.js @@ -1,4 +1,4 @@ -import createFlash from '~/flash'; +import { createAlert } from '~/flash'; import Poll from '~/lib/utils/poll'; import { __ } from '~/locale'; import Service from '../../services'; @@ -33,7 +33,7 @@ export function startPolling({ state, commit, dispatch }) { }, errorCallback: () => { commit(types.SET_LOADING, false); - createFlash({ + createAlert({ message: __('Failed to load errors from Sentry.'), }); }, diff --git a/app/assets/javascripts/error_tracking_settings/store/actions.js b/app/assets/javascripts/error_tracking_settings/store/actions.js index 972ad58c617..4d6fe767f3a 100644 --- a/app/assets/javascripts/error_tracking_settings/store/actions.js +++ b/app/assets/javascripts/error_tracking_settings/store/actions.js @@ -1,4 +1,4 @@ -import createFlash from '~/flash'; +import { createAlert } from '~/flash'; import axios from '~/lib/utils/axios_utils'; import { refreshCurrentPage } from '~/lib/utils/url_utility'; import { __ } from '~/locale'; @@ -46,7 +46,7 @@ export const requestSettings = ({ commit }) => { export const receiveSettingsError = ({ commit }, { response = {} }) => { const message = response.data && response.data.message ? response.data.message : ''; - createFlash({ + createAlert({ message: `${__('There was an error saving your changes.')} ${message}`, }); commit(types.UPDATE_SETTINGS_LOADING, false); diff --git a/app/assets/javascripts/feature_flags/components/environments_dropdown.vue b/app/assets/javascripts/feature_flags/components/environments_dropdown.vue index 70b60b4b113..ce5f7915dbf 100644 --- a/app/assets/javascripts/feature_flags/components/environments_dropdown.vue +++ b/app/assets/javascripts/feature_flags/components/environments_dropdown.vue @@ -1,7 +1,7 @@