From f3cfb235c76426ce5a18003bb80ba625097bf1d0 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 28 Sep 2022 09:09:28 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .../gitlab/no_code_coverage_comment.yml | 3 +- .../components/error_details.vue | 8 +- .../error_tracking/store/actions.js | 4 +- .../error_tracking/store/details/actions.js | 4 +- .../error_tracking/store/list/actions.js | 4 +- .../error_tracking_settings/store/actions.js | 4 +- .../components/environments_dropdown.vue | 4 +- .../components/new_environments_dropdown.vue | 4 +- .../feature_flags/store/edit/actions.js | 4 +- .../feature_highlight_helper.js | 4 +- .../filtered_search/dropdown_ajax_filter.js | 4 +- .../filtered_search/dropdown_emoji.js | 4 +- .../filtered_search/dropdown_non_user.js | 4 +- .../filtered_search_manager.js | 4 +- .../filtered_search/visual_token_value.js | 6 +- app/assets/javascripts/gpg_badges.js | 4 +- .../grafana_integration/store/actions.js | 4 +- app/assets/javascripts/group.js | 6 +- .../javascripts/groups/components/app.vue | 6 +- .../settings/components/access_dropdown.vue | 4 +- .../ide/components/new_dropdown/modal.vue | 4 +- .../ide/components/repo_editor.vue | 6 +- app/assets/javascripts/ide/stores/actions.js | 6 +- .../ide/stores/actions/merge_request.js | 6 +- .../javascripts/ide/stores/actions/project.js | 6 +- .../ide/stores/modules/commit/actions.js | 4 +- .../terminal/actions/session_controls.js | 6 +- .../terminal/actions/session_status.js | 4 +- .../import_groups/components/import_table.vue | 4 +- .../import_groups/services/status_poller.js | 4 +- .../import_projects/store/actions.js | 12 +- .../components/promote_milestone_modal.vue | 4 +- .../javascripts/milestones/milestone.js | 4 +- .../javascripts/mirrors/mirror_repos.js | 4 +- app/assets/javascripts/mirrors/ssh_mirror.js | 4 +- .../monitoring/components/dashboard.vue | 8 +- .../javascripts/monitoring/stores/actions.js | 30 ++-- .../javascripts/namespaces/leave_by_url.js | 4 +- .../new/components/project_namespace.vue | 4 +- .../creations/new/compare_autocomplete.js | 4 +- .../projects/merge_requests/edit/index.js | 4 +- .../javascripts/pages/projects/project.js | 4 +- .../pages/sessions/new/username_validator.js | 4 +- .../shared/wikis/components/wiki_content.vue | 4 +- .../pages/users/activity_calendar.js | 4 +- .../javascripts/persistent_user_callout.js | 6 +- .../projects/settings/access_dropdown.js | 6 +- .../settings/components/access_dropdown.vue | 6 +- .../settings/repository/branch_rules/app.vue | 4 +- app/assets/javascripts/projects/star.js | 4 +- .../commit_pipeline_status_component.vue | 4 +- .../protected_branch_create.js | 4 +- .../protected_branch_edit.js | 6 +- .../protected_tags/protected_tag_edit.js | 4 +- .../components/related_issues_root.vue | 12 +- .../releases/components/app_index.vue | 4 +- .../releases/components/app_show.vue | 4 +- .../stores/modules/edit_new/actions.js | 14 +- .../components/work_item_assignees.vue | 3 - .../components/work_item_labels.vue | 3 - .../work_items/pages/create_work_item.vue | 43 ------ app/models/bulk_imports/entity.rb | 16 ++- .../_network_rate_limits.html.haml | 2 +- .../application_settings/_outbound.html.haml | 2 +- .../_prometheus.html.haml | 2 +- app/views/shared/issuable/_form.html.haml | 4 +- app/views/shared/web_hooks/_index.html.haml | 25 ++-- app/workers/bulk_import_worker.rb | 5 +- .../bulk_imports/export_request_worker.rb | 73 ++++++++-- doc/administration/auth/atlassian.md | 12 +- doc/administration/auth/authentiq.md | 24 ++-- doc/administration/sidekiq/index.md | 4 + .../blueprints/work_items/index.md | 130 ++++++++++++++++++ .../specification_guide/index.md | 62 +++++---- doc/user/group/epics/manage_epics.md | 2 + doc/user/markdown.md | 1 + .../common/rest/get_badges_query.rb | 5 +- .../groups/extractors/subgroups_extractor.rb | 4 +- .../groups/graphql/get_group_query.rb | 2 +- .../groups/graphql/get_projects_query.rb | 1 + .../pipelines/project_entities_pipeline.rb | 3 +- .../group_attributes_transformer.rb | 99 ++++++------- .../projects/graphql/get_project_query.rb | 1 + locale/gitlab.pot | 3 + spec/factories/bulk_import/entities.rb | 1 + .../commit_pipeline_status_component_spec.js | 4 +- .../components/error_details_spec.js | 8 +- .../error_tracking/store/actions_spec.js | 6 +- .../store/details/actions_spec.js | 6 +- .../error_tracking/store/list/actions_spec.js | 4 +- .../feature_highlight_helper_spec.js | 4 +- .../components/grafana_integration_spec.js | 6 +- spec/frontend/groups/components/app_spec.js | 8 +- .../ide/components/new_dropdown/modal_spec.js | 10 +- .../ide/stores/actions/merge_request_spec.js | 8 +- .../ide/stores/actions/project_spec.js | 6 +- spec/frontend/ide/stores/actions_spec.js | 12 +- .../terminal/actions/session_controls_spec.js | 6 +- .../terminal/actions/session_status_spec.js | 4 +- .../components/import_table_spec.js | 4 +- .../services/status_poller_spec.js | 4 +- .../import_projects/store/actions_spec.js | 10 +- .../components/related_issues_root_spec.js | 8 +- .../promote_milestone_modal_spec.js | 4 +- .../monitoring/components/dashboard_spec.js | 8 +- .../components/dashboard_url_time_spec.js | 4 +- .../frontend/monitoring/store/actions_spec.js | 20 +-- .../new/components/project_namespace_spec.js | 4 +- spec/frontend/persistent_user_callout_spec.js | 6 +- .../repository/branch_rules/app_spec.js | 4 +- .../protected_branch_edit_spec.js | 6 +- .../releases/components/app_index_spec.js | 6 +- .../releases/components/app_show_spec.js | 6 +- .../stores/modules/detail/actions_spec.js | 34 ++--- .../components/work_item_assignees_spec.js | 4 +- .../components/work_item_labels_spec.js | 4 +- .../pipelines/lfs_objects_pipeline_spec.rb | 2 +- .../common/pipelines/uploads_pipeline_spec.rb | 4 +- .../common/rest/get_badges_query_spec.rb | 31 ++++- .../groups/pipelines/group_pipeline_spec.rb | 2 +- .../project_entities_pipeline_spec.rb | 2 + .../group_attributes_transformer_spec.rb | 78 ++++++----- .../pipelines/design_bundle_pipeline_spec.rb | 5 +- .../repository_bundle_pipeline_spec.rb | 5 +- spec/models/bulk_imports/entity_spec.rb | 12 +- spec/spec_helper.rb | 2 + spec/support/helpers/html_escaped_helpers.rb | 31 +++++ .../html_safe_shared_context.rb | 23 ++++ .../views/html_safe_render_shared_context.rb | 39 ------ spec/support/view_component.rb | 7 + .../helpers/html_escaped_helpers_spec.rb | 29 ++++ spec/workers/bulk_import_worker_spec.rb | 3 +- .../export_request_worker_spec.rb | 67 ++++++++- 133 files changed, 856 insertions(+), 561 deletions(-) create mode 100644 doc/architecture/blueprints/work_items/index.md create mode 100644 spec/support/shared_contexts/html_safe_shared_context.rb delete mode 100644 spec/support/shared_contexts/views/html_safe_render_shared_context.rb diff --git a/.rubocop_todo/gitlab/no_code_coverage_comment.yml b/.rubocop_todo/gitlab/no_code_coverage_comment.yml index f4d50fda11b..0dcee5f32ee 100644 --- a/.rubocop_todo/gitlab/no_code_coverage_comment.yml +++ b/.rubocop_todo/gitlab/no_code_coverage_comment.yml @@ -7,10 +7,9 @@ Gitlab/NoCodeCoverageComment: - 'app/workers/database/batched_background_migration/single_database_worker.rb' - 'config/initializers/net_http_response_patch.rb' - 'ee/app/models/concerns/geo/replicable_model.rb' - - 'ee/app/services/namespaces/free_user_cap/remove_group_group_links_outside_hierarchy_service.rb' - - 'ee/app/workers/namespaces/free_user_cap/remediation_worker.rb' - 'ee/lib/gitlab/geo/replicator.rb' - 'lib/gitlab/auth/o_auth/session.rb' + - 'lib/gitlab/cleanup/personal_access_tokens.rb' - 'lib/gitlab/cycle_analytics/summary/defaults.rb' - 'lib/gitlab/database/background_migration/health_status/signals.rb' - 'lib/gitlab/seeder.rb' diff --git a/app/assets/javascripts/error_tracking/components/error_details.vue b/app/assets/javascripts/error_tracking/components/error_details.vue index a602c92a840..b02c3cd2cba 100644 --- a/app/assets/javascripts/error_tracking/components/error_details.vue +++ b/app/assets/javascripts/error_tracking/components/error_details.vue @@ -13,7 +13,7 @@ import { GlIcon, } from '@gitlab/ui'; import { mapActions, mapGetters, mapState } from 'vuex'; -import createFlash from '~/flash'; +import { createAlert, VARIANT_WARNING } from '~/flash'; import { __, sprintf, n__ } from '~/locale'; import Tracking from '~/tracking'; import TimeAgoTooltip from '~/vue_shared/components/time_ago_tooltip.vue'; @@ -89,7 +89,7 @@ export default { pollInterval: 2000, update: (data) => data.project.sentryErrors.detailedError, error: () => - createFlash({ + createAlert({ message: __('Failed to load error details from Sentry.'), }), result(res) { @@ -234,9 +234,9 @@ export default { if (Date.now() > this.errorPollTimeout) { this.$apollo.queries.error.stopPolling(); this.errorLoading = false; - createFlash({ + createAlert({ message: __('Could not connect to Sentry. Refresh the page to try again.'), - type: 'warning', + variant: VARIANT_WARNING, }); } }, diff --git a/app/assets/javascripts/error_tracking/store/actions.js b/app/assets/javascripts/error_tracking/store/actions.js index fbfcd6ce2df..603f8611005 100644 --- a/app/assets/javascripts/error_tracking/store/actions.js +++ b/app/assets/javascripts/error_tracking/store/actions.js @@ -1,4 +1,4 @@ -import createFlash from '~/flash'; +import { createAlert } from '~/flash'; import { visitUrl } from '~/lib/utils/url_utility'; import { __ } from '~/locale'; import service from '../services'; @@ -18,7 +18,7 @@ export const updateStatus = ({ commit }, { endpoint, redirectUrl, status }) => return resp.data.result; }) .catch(() => - createFlash({ + createAlert({ message: __('Failed to update issue status'), }), ); diff --git a/app/assets/javascripts/error_tracking/store/details/actions.js b/app/assets/javascripts/error_tracking/store/details/actions.js index 09fa650f64b..1409399940a 100644 --- a/app/assets/javascripts/error_tracking/store/details/actions.js +++ b/app/assets/javascripts/error_tracking/store/details/actions.js @@ -1,4 +1,4 @@ -import createFlash from '~/flash'; +import { createAlert } from '~/flash'; import Poll from '~/lib/utils/poll'; import { __ } from '~/locale'; import service from '../../services'; @@ -26,7 +26,7 @@ export function startPollingStacktrace({ commit }, endpoint) { }, errorCallback: () => { commit(types.SET_LOADING_STACKTRACE, false); - createFlash({ + createAlert({ message: __('Failed to load stacktrace.'), }); }, diff --git a/app/assets/javascripts/error_tracking/store/list/actions.js b/app/assets/javascripts/error_tracking/store/list/actions.js index 418056314f6..f633711add3 100644 --- a/app/assets/javascripts/error_tracking/store/list/actions.js +++ b/app/assets/javascripts/error_tracking/store/list/actions.js @@ -1,4 +1,4 @@ -import createFlash from '~/flash'; +import { createAlert } from '~/flash'; import Poll from '~/lib/utils/poll'; import { __ } from '~/locale'; import Service from '../../services'; @@ -33,7 +33,7 @@ export function startPolling({ state, commit, dispatch }) { }, errorCallback: () => { commit(types.SET_LOADING, false); - createFlash({ + createAlert({ message: __('Failed to load errors from Sentry.'), }); }, diff --git a/app/assets/javascripts/error_tracking_settings/store/actions.js b/app/assets/javascripts/error_tracking_settings/store/actions.js index 972ad58c617..4d6fe767f3a 100644 --- a/app/assets/javascripts/error_tracking_settings/store/actions.js +++ b/app/assets/javascripts/error_tracking_settings/store/actions.js @@ -1,4 +1,4 @@ -import createFlash from '~/flash'; +import { createAlert } from '~/flash'; import axios from '~/lib/utils/axios_utils'; import { refreshCurrentPage } from '~/lib/utils/url_utility'; import { __ } from '~/locale'; @@ -46,7 +46,7 @@ export const requestSettings = ({ commit }) => { export const receiveSettingsError = ({ commit }, { response = {} }) => { const message = response.data && response.data.message ? response.data.message : ''; - createFlash({ + createAlert({ message: `${__('There was an error saving your changes.')} ${message}`, }); commit(types.UPDATE_SETTINGS_LOADING, false); diff --git a/app/assets/javascripts/feature_flags/components/environments_dropdown.vue b/app/assets/javascripts/feature_flags/components/environments_dropdown.vue index 70b60b4b113..ce5f7915dbf 100644 --- a/app/assets/javascripts/feature_flags/components/environments_dropdown.vue +++ b/app/assets/javascripts/feature_flags/components/environments_dropdown.vue @@ -1,7 +1,7 @@