kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Fix NotificationRecipientService spec for EE

Browse source 
EE checks a license, which needs RequestStore enabled to avoid N+1
queries. However, enabling RequestStore causes Gitaly to complain about N+1
invocations, which we really don't care about here.
This commit is contained in:
Sean McGivern 2018-06-08 11:45:36 +01:00
parent 2c05c8574f
commit f413c4dd26
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
spec/services/notification_recipient_service_spec.rb
View file

@ -19,8 +19,8 @@ describe NotificationRecipientService do
end
end
it 'avoids N+1 queries' do
create_watcher
it 'avoids N+1 queries', :request_store do
Gitlab::GitalyClient.allow_n_plus_1_calls { create_watcher }
service.build_new_note_recipients(note)
@ -28,7 +28,7 @@ describe NotificationRecipientService do
service.build_new_note_recipients(note)
end
create_watcher
Gitlab::GitalyClient.allow_n_plus_1_calls { create_watcher }
expect { service.build_new_note_recipients(note) }.not_to exceed_query_limit(control_count)
end