Fixed: Warnings from static code analysis

2019-02-16 11:52:21 +01:00 · 2019-02-16 11:52:21 +01:00 · f43cb6e79d
parent ff671366cb
commit f43cb6e79d
1 changed files with 3 additions and 5 deletions
--- a/lib/api/helpers.rb
+++ b/lib/api/helpers.rb
@ -397,13 +397,11 @@ module API
    end
    # rubocop: enable CodeReuse/ActiveRecord

-    # rubocop: disable CodeReuse/ActiveRecord
    def order_options_with_tie_breaker
-      {params[:order_by] => params[:sort]}.tap do |order|
-        order['id'] ||= 'desc'
-      end
+      order_options = { params[:order_by] => params[:sort] }
+      order_options['id'] ||= 'desc'
+      order_options
    end
-    # rubocop: enable CodeReuse/ActiveRecord

    def project_finder_params
      finder_params = { without_deleted: true }