From f46d20e5088ca9c58793e3b6044facfa74feb7ed Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 23 Jun 2022 12:09:30 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .rubocop_todo/gitlab/namespaced_class.yml | 1 - Gemfile | 2 +- Gemfile.lock | 4 +- .../batch_comments/components/draft_note.vue | 9 +- .../components/dependency_proxy_settings.vue | 9 +- .../settings/group/constants.js | 3 + .../components/blob_content_viewer.vue | 9 +- .../components/source_viewer/constants.js | 6 + .../source_viewer/source_viewer.vue | 31 +- .../components/work_item_links/index.js | 4 + .../work_item_links/work_item_links_form.vue | 47 +- .../graphql/project_work_items.query.graphql | 13 + .../projects/tracings_controller.rb | 30 -- app/helpers/projects_helper.rb | 1 - app/models/project.rb | 7 - app/models/project_tracing_setting.rb | 15 - .../projects/operations/update_service.rb | 10 - .../issues/_work_item_links.html.haml | 2 +- .../tracings/_tracing_button.html.haml | 2 - app/views/projects/tracings/show.html.haml | 50 --- app/views/shared/wikis/edit.html.haml | 2 + .../import_release_authors_from_github.yml | 2 +- .../development/issues_full_text_search.yml | 2 +- ...lick_house_database_for_error_tracking.yml | 8 + danger/roulette/Dangerfile | 4 + doc/development/internal_api/index.md | 7 +- doc/development/pipelines.md | 2 +- .../infrastructure/iac/terraform_state.md | 3 +- lib/api/entities/hook.rb | 5 + lib/api/helpers.rb | 4 +- lib/api/helpers/web_hooks_helpers.rb | 70 +++ lib/api/hooks/test.rb | 21 + lib/api/hooks/url_variables.rb | 45 ++ lib/api/internal/base.rb | 6 +- lib/api/project_hooks.rb | 53 +-- lib/api/system_hooks.rb | 79 ++-- lib/gitlab/ci/tags/bulk_insert.rb | 2 +- locale/gitlab.pot | 33 +- qa/qa/resource/runner.rb | 7 +- qa/qa/runtime/env.rb | 8 - .../1_manage/login/2fa_recovery_spec.rb | 7 +- .../1_manage/login/log_in_with_2fa_spec.rb | 8 +- scripts/rspec_helpers.sh | 3 + .../projects/tracings_controller_spec.rb | 72 --- spec/factories/project_tracing_settings.rb | 8 - spec/factories/usage_data.rb | 3 - .../merge_request/batch_comments_spec.rb | 12 - spec/features/projects/tracings_spec.rb | 60 --- .../schemas/public_api/v4/project_hook.json | 62 +++ .../schemas/public_api/v4/project_hooks.json | 10 + .../schemas/public_api/v4/system_hook.json | 16 +- .../components/draft_note_spec.js | 11 +- .../dependency_proxy_settings_spec.js | 18 +- .../components/blob_content_viewer_spec.js | 11 + .../source_viewer/source_viewer_spec.js | 29 +- .../work_item_links_form_spec.js | 49 +++ spec/frontend/work_items/mock_data.js | 25 ++ spec/lib/gitlab/ci/tags/bulk_insert_spec.rb | 26 ++ spec/lib/gitlab/import_export/all_models.yml | 3 - .../import_export/safe_model_attributes.yml | 2 - spec/models/project_spec.rb | 1 - spec/models/project_tracing_setting_spec.rb | 40 -- spec/requests/api/internal/base_spec.rb | 79 +++- spec/requests/api/project_hooks_spec.rb | 247 ++--------- spec/requests/api/system_hooks_spec.rb | 229 ++-------- .../operations/update_service_spec.rb | 88 ---- spec/simplecov_env.rb | 2 +- .../wiki/autocomplete_shared_examples.rb | 43 ++ .../user_updates_wiki_page_shared_examples.rb | 2 + .../requests/api/hooks_shared_examples.rb | 415 ++++++++++++++++++ .../projects/tracing/show.html.haml_spec.rb | 59 --- tooling/danger/project_helper.rb | 1 + 72 files changed, 1208 insertions(+), 1051 deletions(-) create mode 100644 app/assets/javascripts/work_items/graphql/project_work_items.query.graphql delete mode 100644 app/controllers/projects/tracings_controller.rb delete mode 100644 app/models/project_tracing_setting.rb delete mode 100644 app/views/projects/tracings/_tracing_button.html.haml delete mode 100644 app/views/projects/tracings/show.html.haml create mode 100644 config/feature_flags/development/use_click_house_database_for_error_tracking.yml create mode 100644 lib/api/helpers/web_hooks_helpers.rb create mode 100644 lib/api/hooks/test.rb create mode 100644 lib/api/hooks/url_variables.rb delete mode 100644 spec/controllers/projects/tracings_controller_spec.rb delete mode 100644 spec/factories/project_tracing_settings.rb delete mode 100644 spec/features/projects/tracings_spec.rb create mode 100644 spec/fixtures/api/schemas/public_api/v4/project_hook.json create mode 100644 spec/fixtures/api/schemas/public_api/v4/project_hooks.json create mode 100644 spec/frontend/work_items/components/work_item_links/work_item_links_form_spec.js delete mode 100644 spec/models/project_tracing_setting_spec.rb create mode 100644 spec/support/shared_examples/features/wiki/autocomplete_shared_examples.rb create mode 100644 spec/support/shared_examples/requests/api/hooks_shared_examples.rb delete mode 100644 spec/views/projects/tracing/show.html.haml_spec.rb diff --git a/.rubocop_todo/gitlab/namespaced_class.yml b/.rubocop_todo/gitlab/namespaced_class.yml index 23ff86ba289..103628c577c 100644 --- a/.rubocop_todo/gitlab/namespaced_class.yml +++ b/.rubocop_todo/gitlab/namespaced_class.yml @@ -285,7 +285,6 @@ Gitlab/NamespacedClass: - 'app/models/project_snippet.rb' - 'app/models/project_statistics.rb' - 'app/models/project_team.rb' - - 'app/models/project_tracing_setting.rb' - 'app/models/project_wiki.rb' - 'app/models/prometheus_alert.rb' - 'app/models/prometheus_alert_event.rb' diff --git a/Gemfile b/Gemfile index 04a3327aa45..8ca232fc1e6 100644 --- a/Gemfile +++ b/Gemfile @@ -407,7 +407,7 @@ group :development, :test do end group :development, :test, :danger do - gem 'gitlab-dangerfiles', '~> 3.3.0', require: false + gem 'gitlab-dangerfiles', '~> 3.4.1', require: false end group :development, :test, :coverage do diff --git a/Gemfile.lock b/Gemfile.lock index e9ebf663153..2c6a35fe072 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -475,7 +475,7 @@ GEM terminal-table (~> 1.5, >= 1.5.1) gitlab-chronic (0.10.5) numerizer (~> 0.2) - gitlab-dangerfiles (3.3.0) + gitlab-dangerfiles (3.4.1) danger (>= 8.4.5) danger-gitlab (>= 8.0.0) rake @@ -1534,7 +1534,7 @@ DEPENDENCIES gitaly (~> 15.1.0.pre.rc1) github-markup (~> 1.7.0) gitlab-chronic (~> 0.10.5) - gitlab-dangerfiles (~> 3.3.0) + gitlab-dangerfiles (~> 3.4.1) gitlab-experiment (~> 0.7.1) gitlab-fog-azure-rm (~> 1.3.0) gitlab-labkit (~> 0.23.0) diff --git a/app/assets/javascripts/batch_comments/components/draft_note.vue b/app/assets/javascripts/batch_comments/components/draft_note.vue index 2b1ab911fbe..300a81caa5c 100644 --- a/app/assets/javascripts/batch_comments/components/draft_note.vue +++ b/app/assets/javascripts/batch_comments/components/draft_note.vue @@ -1,6 +1,7 @@